)]}'
{"id":"openvpn~2201","triplet_id":"openvpn~master~I831224f06e2f35bfcc9d0fec7d8edfc344c59406","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000069":{"account":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"last_update":"2026-11-16 20:16:18.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-16 15:34:28.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I831224f06e2f35bfcc9d0fec7d8edfc344c59406","subject":"dco: always print the status block","status":"NEW","created":"2026-11-16 15:34:28.000000000","updated":"2026-11-16 20:16:18.000000000","submit_type":"CHERRY_PICK","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8e6f2ddbd8bb0dfc8b37182c16f32cff75d0192e","_number":2201,"virtual_id_number":2201,"owner":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"all":[{"value":2,"date":"2026-11-16 20:16:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-16 15:34:28.000000000","updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"real_updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-16 15:34:28.000000000","updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"real_updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-16 20:16:18.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"6930a9328932eb70180fbcc4b6c207af19bfbb7e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"date":"2026-11-16 15:34:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e6f2ddbd8bb0dfc8b37182c16f32cff75d0192e","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-16 20:16:18.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4943e7483a235cc2253817d1e4a607fdd9c421fa","revisions":{"4943e7483a235cc2253817d1e4a607fdd9c421fa":{"kind":"REWORK","_number":1,"created":"2026-11-16 15:34:28.000000000","uploader":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"ref":"refs/changes/01/2201/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/01/2201/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1 \u0026\u0026 git checkout -b change-2201 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/01/2201/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b0668301ed71e90dfed96c4e5bfafdbe2000ed93","subject":"contrib, sample: drop SysV-era init scripts"}],"author":{"name":"Tommaso Bailetti","email":"tommaso.bailetti@nethesis.it","date":"2026-11-16 15:23:14.000000000","tz":60},"committer":{"name":"Tommaso Bailetti","email":"tommaso.bailetti@nethesis.it","date":"2026-11-16 15:23:14.000000000","tz":60},"subject":"dco: always print the status block","message":"dco: always print the status block\n\nWhen DCO is enabled print_status() bails out if dco_get_peer_stats()\nfails, without writing anything. On a client this happens during the\nwhole reconnect after a ping-restart, since there\u0027s no DCO interface,\nso the management \"status\" command never gets an answer, not even\n\"END\", and the --status file isn\u0027t updated either.\n\nPrint the status anyway. On a real DCO error SIGUSR1 is still raised\nby dco_get_peer_stats(), so the session restart keeps working.\n\nGitHub: closes OpenVPN/openvpn#1146\nChange-Id: I831224f06e2f35bfcc9d0fec7d8edfc344c59406\nSigned-off-by: Tommaso Bailetti \u003ctommaso.bailetti@nethesis.it\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
