)]}'
{"id":"openvpn~2204","triplet_id":"openvpn~master~I2088345f10a630241fbddde68336ea7c1f7b449d","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2026-11-17 09:07:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1000069\u003e replied on the change","reason_account":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-16 20:33:32.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I2088345f10a630241fbddde68336ea7c1f7b449d","subject":"dco: don\u0027t access tls_multi in dco_get_peer_stats() during a restart","status":"NEW","created":"2026-11-16 20:33:32.000000000","updated":"2026-11-17 09:07:00.000000000","submit_type":"CHERRY_PICK","total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"732df82ac242e747b88cae1181acee97df120572","_number":2204,"virtual_id_number":2204,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-16 20:33:32.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-16 20:33:32.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 09:07:00.000000000","updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"real_updated_by":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"reviewer":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"state":"CC"}],"messages":[{"id":"0f04189d6fbce4e758b9b2eab5e928458e06a690","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-16 20:33:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"732df82ac242e747b88cae1181acee97df120572","author":{"_account_id":1000069,"name":"Tommaso Bailetti","email":"bailetti.tommaso@gmail.com","username":"Tbaile"},"date":"2026-11-17 09:07:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fe644a439bcc2f81b94365444a6b5ccca68879b3","revisions":{"fe644a439bcc2f81b94365444a6b5ccca68879b3":{"kind":"REWORK","_number":1,"created":"2026-11-16 20:33:32.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/04/2204/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/2204/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1 \u0026\u0026 git checkout -b change-2204 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/04/2204/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4721ed8df56c8d2e97da0079d01e5e2a87054fb8","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-11-16 20:19:17.000000000","tz":60},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2026-11-16 20:27:45.000000000","tz":60},"subject":"dco: don\u0027t access tls_multi in dco_get_peer_stats() during a restart","message":"dco: don\u0027t access tls_multi in dco_get_peer_stats() during a restart\n\nOn a restart init_instance() registers the management callbacks before\nthe restart pause, while c2.tls_multi is still NULL: close_instance()\nfreed it and do_init_crypto_tls() has not created the new one yet.\nA management \"status\" command during the pause therefore calls\ndco_get_peer_stats() without a tls_multi.\n\nWith --persist-tun the DCO interface survives the restart, so the Linux\nand Windows implementations get past their interface checks and\ndereference the NULL tls_multi; FreeBSD hits ASSERT(c-\u003ec2.tls_multi)\neven without --persist-tun. Either way openvpn dies.\n\nReturn an error when there is no tls_multi, as when there is no DCO\ninterface.\n\nReproduced on Linux with a DCO client using --persist-tun:\n\n  (echo \u0027signal SIGUSR1\u0027; sleep 0.5; echo status; sleep 3) | nc 127.0.0.1 7505\n\nsegfaults in dco_get_peer_stats() during the restart pause.\n\nGerrit change 2201 makes print_status() answer even when\ndco_get_peer_stats() fails; together with this change, \"status\" gets\na reply during a reconnect instead of hanging or crashing.\n\nRelated: https://gerrit.openvpn.net/c/openvpn/+/2201\nChange-Id: I2088345f10a630241fbddde68336ea7c1f7b449d\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
