)]}'
{"id":"openvpn~2207","triplet_id":"openvpn~master~I4c6bc877c442b24b918fbda2dcc8003127483bfd","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 08:25:49.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4c6bc877c442b24b918fbda2dcc8003127483bfd","subject":"socks: accept RFC 1929 version in username/password auth reply","status":"NEW","created":"2026-11-17 08:25:49.000000000","updated":"2026-11-17 11:22:14.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1b32e78d89d7f534656078ce71771b996381d790","_number":2207,"virtual_id_number":2207,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 08:25:49.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 08:25:49.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"58358d48674b3a54b2f79ca204416c58e3d93e74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 08:25:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1b32e78d89d7f534656078ce71771b996381d790","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 11:22:14.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e9ba5861902d3020b0b622b7b034cd522f75bfa1","revisions":{"e38117e91353aa30c2714efa36a5e9e639b9803b":{"kind":"REWORK","_number":1,"created":"2026-11-17 08:25:49.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/07/2207/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/07/2207/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1 \u0026\u0026 git checkout -b change-2207 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4721ed8df56c8d2e97da0079d01e5e2a87054fb8","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:25:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:25:06.000000000","tz":120},"subject":"socks: accept RFC 1929 version in username/password auth reply","message":"socks: accept RFC 1929 version in username/password auth reply\n\nSince d104917e the auth reply must carry VER 5, but RFC 1929 servers\nreply with VER 1, so authentication against them always failed. Accept\nVER 1, and keep accepting 5, which some servers send.\n\nChange-Id: I4c6bc877c442b24b918fbda2dcc8003127483bfd\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"e9ba5861902d3020b0b622b7b034cd522f75bfa1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-17 11:22:14.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/07/2207/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/07/2207/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2 \u0026\u0026 git checkout -b change-2207 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/07/2207/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:25:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 11:20:46.000000000","tz":120},"subject":"socks: accept RFC 1929 version in username/password auth reply","message":"socks: accept RFC 1929 version in username/password auth reply\n\nSince d104917e the auth reply must carry VER 5, but RFC 1929 servers\nreply with VER 1, so authentication against them always failed. Accept\nVER 1, and keep accepting 5, which some servers send.\n\nChange-Id: I4c6bc877c442b24b918fbda2dcc8003127483bfd\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}]}
