)]}'
{"id":"openvpn~2208","triplet_id":"openvpn~master~Ibd316e5c3e6a0fb600ec4817aa079554464fd942","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-17 08:56:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 08:36:51.000000000","reason":"Reviewer was added"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ibd316e5c3e6a0fb600ec4817aa079554464fd942","subject":"clinat: locate the TCP/UDP header via the IP header length","status":"NEW","created":"2026-11-17 08:36:51.000000000","updated":"2026-11-17 11:30:28.000000000","submit_type":"CHERRY_PICK","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5d30c70a2fa882ac9e1ec0dd151968908b1c1ade","_number":2208,"virtual_id_number":2208,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"all":[{"value":2,"date":"2026-11-17 11:30:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 08:36:51.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 08:36:51.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 08:56:32.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"b5e4ba58e881003791a3818db325516e3f2092a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 08:36:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3f3e62c5dab5343aabe58ab088da392bfdce0fd","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2026-11-17 08:56:32.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5d30c70a2fa882ac9e1ec0dd151968908b1c1ade","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 11:30:28.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d681e05cb094312a3195b97fae3eebccf0bb0923","revisions":{"7ed989888bbf2b223cac7c153608e78ff8e5ded0":{"kind":"REWORK","_number":1,"created":"2026-11-17 08:36:51.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/08/2208/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/2208/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1 \u0026\u0026 git checkout -b change-2208 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4721ed8df56c8d2e97da0079d01e5e2a87054fb8","subject":"Various trivial -Wsign-conversion fixes (part 2)"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:34:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:34:06.000000000","tz":120},"subject":"clinat: locate the TCP/UDP header via the IP header length","message":"clinat: locate the TCP/UDP header via the IP header length\n\nclient_nat_transform() adjusted the TCP/UDP checksum at a fixed offset\nof 20 bytes. With IP options this rewrote the UDP destination port or\nthe TCP data offset and flags instead, and for non-first fragments it\nmodified payload bytes. Use the header length from the IP header and\nskip the transport checksum for non-first fragments, as mss_fixup_ipv4()\ndoes.\n\nChange-Id: Ibd316e5c3e6a0fb600ec4817aa079554464fd942\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"d681e05cb094312a3195b97fae3eebccf0bb0923":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-17 11:30:28.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/08/2208/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/08/2208/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2 \u0026\u0026 git checkout -b change-2208 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/08/2208/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 08:34:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 11:30:02.000000000","tz":120},"subject":"clinat: locate the TCP/UDP header via the IP header length","message":"clinat: locate the TCP/UDP header via the IP header length\n\nclient_nat_transform() adjusted the TCP/UDP checksum at a fixed offset\nof 20 bytes. With IP options this rewrote the UDP destination port or\nthe TCP data offset and flags instead, and for non-first fragments it\nmodified payload bytes. Use the header length from the IP header and\nskip the transport checksum for non-first fragments, as mss_fixup_ipv4()\ndoes.\n\nChange-Id: Ibd316e5c3e6a0fb600ec4817aa079554464fd942\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
