)]}'
{"src/openvpn/manage.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"60ac611f0023df5e47ebfa3a18897dc762ec2a01","unresolved":true,"context_lines":[{"line_number":3322,"context_line":"            case MS_LISTEN:"},{"line_number":3323,"context_line":"            {"},{"line_number":3324,"context_line":"                const bool paused \u003d (man-\u003esettings.flags \u0026 MF_SERVER) \u0026\u0026 socket_accept_paused();"},{"line_number":3325,"context_line":"                if (man_persist_state(persistent, paused ? 4 : 1))"},{"line_number":3326,"context_line":"                {"},{"line_number":3327,"context_line":"                    event_ctl(es, ev, paused ? 0 : EVENT_READ, arg);"},{"line_number":3328,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"4cc79654_4f56a18f","line":3325,"updated":"2026-11-17 15:36:44.000000000","message":"what is this `4`?\n\nI\u0027m afraid this patch needs a bit of doxygen comment on top of `man_persist_state()` on what this is doing...","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bccca942785822147154036f65fcf78a35f3b789","unresolved":false,"context_lines":[{"line_number":3322,"context_line":"            case MS_LISTEN:"},{"line_number":3323,"context_line":"            {"},{"line_number":3324,"context_line":"                const bool paused \u003d (man-\u003esettings.flags \u0026 MF_SERVER) \u0026\u0026 socket_accept_paused();"},{"line_number":3325,"context_line":"                if (man_persist_state(persistent, paused ? 4 : 1))"},{"line_number":3326,"context_line":"                {"},{"line_number":3327,"context_line":"                    event_ctl(es, ev, paused ? 0 : EVENT_READ, arg);"},{"line_number":3328,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"faf50fa5_3231bd56","line":3325,"in_reply_to":"4cc79654_4f56a18f","updated":"2026-11-18 11:02:00.000000000","message":"Done","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"}],"src/openvpn/multi_io.c":[{"author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"change_message_id":"84ac1248491369276d12673a2c8f96104f7bd50c","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    const time_t delay \u003d socket_accept_paused();"},{"line_number":202,"context_line":"    if (delay \u0026\u0026 m-\u003etop.c2.timeval.tv_sec \u003e\u003d delay)"},{"line_number":203,"context_line":"    {"},{"line_number":204,"context_line":"        m-\u003etop.c2.timeval.tv_sec \u003d delay;"},{"line_number":205,"context_line":"        m-\u003etop.c2.timeval.tv_usec \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9b995612_d1370825","line":202,"updated":"2026-11-17 14:24:27.000000000","message":"This breaks the mingw build (at least the cross-platform one on my Linux machine: `-Wconversion -Werror`).\n\n`tv_sec` is `long` on Windows, `time_t` is 64-bit.\n\nThis needs a `(tv_sec_t)delay` cast, like `context_reschedule_sec()` does.","commit_id":"f535e804ef8c23e7051b8cf566066a35f6598782"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"6841aafa0bdaf18bbbada81761736ed83c8faa3a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    const time_t delay \u003d socket_accept_paused();"},{"line_number":202,"context_line":"    if (delay \u0026\u0026 m-\u003etop.c2.timeval.tv_sec \u003e\u003d delay)"},{"line_number":203,"context_line":"    {"},{"line_number":204,"context_line":"        m-\u003etop.c2.timeval.tv_sec \u003d delay;"},{"line_number":205,"context_line":"        m-\u003etop.c2.timeval.tv_usec \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"3d2d950f_82d7c218","line":202,"in_reply_to":"9b995612_d1370825","updated":"2026-11-17 14:59:12.000000000","message":"Done","commit_id":"f535e804ef8c23e7051b8cf566066a35f6598782"}],"src/openvpn/socket.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"60ac611f0023df5e47ebfa3a18897dc762ec2a01","unresolved":true,"context_lines":[{"line_number":431,"context_line":"#ifdef _WIN32"},{"line_number":432,"context_line":"    const bool out_of_resources \u003d err \u003d\u003d WSAEMFILE || err \u003d\u003d WSAENOBUFS;"},{"line_number":433,"context_line":"#else"},{"line_number":434,"context_line":"    const bool out_of_resources \u003d err \u003d\u003d EMFILE || err \u003d\u003d ENFILE || err \u003d\u003d ENOBUFS || err \u003d\u003d ENOMEM;"},{"line_number":435,"context_line":"#endif"},{"line_number":436,"context_line":"    if (out_of_resources)"},{"line_number":437,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bd369ef8_7e3abf98","line":434,"updated":"2026-11-17 15:36:44.000000000","message":"please sprinkle a few braces over this - there\u0027s too many operators for mere mortals to grok this (`out_of_resources \u003d ( err \u003d\u003d EMFILE || err \u003d\u003d ENFILE ...)`) or maybe just get rid of the temp variable and put it into the `if()` right away (having two `if()` with the #ifdef, not one with #ifdef nested into the condition)","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bccca942785822147154036f65fcf78a35f3b789","unresolved":false,"context_lines":[{"line_number":431,"context_line":"#ifdef _WIN32"},{"line_number":432,"context_line":"    const bool out_of_resources \u003d err \u003d\u003d WSAEMFILE || err \u003d\u003d WSAENOBUFS;"},{"line_number":433,"context_line":"#else"},{"line_number":434,"context_line":"    const bool out_of_resources \u003d err \u003d\u003d EMFILE || err \u003d\u003d ENFILE || err \u003d\u003d ENOBUFS || err \u003d\u003d ENOMEM;"},{"line_number":435,"context_line":"#endif"},{"line_number":436,"context_line":"    if (out_of_resources)"},{"line_number":437,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"83743194_9b5a2146","line":434,"in_reply_to":"bd369ef8_7e3abf98","updated":"2026-11-18 11:02:00.000000000","message":"Done","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"60ac611f0023df5e47ebfa3a18897dc762ec2a01","unresolved":true,"context_lines":[{"line_number":435,"context_line":"#endif"},{"line_number":436,"context_line":"    if (out_of_resources)"},{"line_number":437,"context_line":"    {"},{"line_number":438,"context_line":"        accept_resume \u003d now + 1;"},{"line_number":439,"context_line":"    }"},{"line_number":440,"context_line":"}"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"9d04688c_8537f519","line":438,"updated":"2026-11-17 15:36:44.000000000","message":"can we add some logging here?  This will create spurious \"connection refused\" on the client side - which will show up in logs and will make people ask \"what has happened here?\".  Of course we do not want to log this once per second, so not fully trivial to get right.","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"bccca942785822147154036f65fcf78a35f3b789","unresolved":false,"context_lines":[{"line_number":435,"context_line":"#endif"},{"line_number":436,"context_line":"    if (out_of_resources)"},{"line_number":437,"context_line":"    {"},{"line_number":438,"context_line":"        accept_resume \u003d now + 1;"},{"line_number":439,"context_line":"    }"},{"line_number":440,"context_line":"}"},{"line_number":441,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"15e1375a_8156730c","line":438,"in_reply_to":"9d04688c_8537f519","updated":"2026-11-18 11:02:00.000000000","message":"Done","commit_id":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4"}]}
