)]}'
{"id":"openvpn~2210","triplet_id":"openvpn~master~I978041ea4e6323f5a92d8721809f0fa44b9c2e03","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"listener-busy-loop","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 14:07:34.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-18 17:44:19.000000000","reason":"Someone else replied on the change"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-11-18 11:01:21.000000000","reason":"Vote got outdated and was removed: Code-Review-1"}},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-18 17:44:19.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I978041ea4e6323f5a92d8721809f0fa44b9c2e03","subject":"socket: pause the listeners when accept() runs out of resources","status":"NEW","created":"2026-11-17 14:07:34.000000000","updated":"2026-11-18 17:44:19.000000000","submit_type":"CHERRY_PICK","total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"640d67dd5f0fc5c82c14f1855028e12d9dcd4952","_number":2210,"virtual_id_number":2210,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-18 17:44:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 14:07:34.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 14:07:34.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 14:24:27.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"},{"updated":"2026-11-17 15:36:44.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"b39019533221120322e507c481ac1ae5bd15ff44","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:07:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"84ac1248491369276d12673a2c8f96104f7bd50c","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 14:24:27.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"438e9af08df45078a56999a130f99c29a5c2d512","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:58:24.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6841aafa0bdaf18bbbada81761736ed83c8faa3a","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:59:12.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ec5f98a3a9c10d8a73fa1bbfbb3ce0ef7ab7a60f","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 15:12:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"60ac611f0023df5e47ebfa3a18897dc762ec2a01","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-17 15:36:44.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"402800683b505852bb9aba0187eb21f3b9a93dd5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-18 11:01:21.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2, Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"bccca942785822147154036f65fcf78a35f3b789","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-18 11:02:00.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"640d67dd5f0fc5c82c14f1855028e12d9dcd4952","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-18 17:44:19.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"83a67bd908e799cc6a97f312a842f29b096c02f2","revisions":{"f535e804ef8c23e7051b8cf566066a35f6598782":{"kind":"REWORK","_number":1,"created":"2026-11-17 14:07:34.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/10/2210/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/2210/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1 \u0026\u0026 git checkout -b change-2210 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 12:28:09.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:00:15.000000000","tz":60},"subject":"socket: pause the listeners when accept() runs out of resources","message":"socket: pause the listeners when accept() runs out of resources\n\nWhen accept() fails with EMFILE, Linux and FreeBSD leave the pending\nconnection in the listen queue and the level-triggered listener is\nreported again on every wait. The server keeps creating and destroying\nan instance for it, never gets an empty event set, so the timers do not\nrun and hand-window never reaps the idle connections that hold the\ndescriptors: the server stays at 100% CPU, writes the failure to the log\nin a loop and stops serving new TCP and UDP clients until the peer\ncloses its connections. A management client connecting while the\ndescriptors are exhausted causes the same loop on the management\nlistener.\n\nWhen accept() fails for lack of resources, stop polling the TCP\nlisteners and, in server mode, the management listener for up to a\nsecond.\n\nGitHub: OpenVPN/openvpn#1148\nChange-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"6e544f6320d31ce0143df4a8253cb988a4e4c8b4":{"kind":"REWORK","_number":2,"created":"2026-11-17 14:58:24.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/10/2210/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/2210/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2 \u0026\u0026 git checkout -b change-2210 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"823653286f82e2fbcd1ff1687a8a01b3fb6302e6","subject":"buffer: Switch buf_forward_capacity and buf_set_write to size_t"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 12:28:09.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:33:08.000000000","tz":60},"subject":"socket: pause the listeners when accept() runs out of resources","message":"socket: pause the listeners when accept() runs out of resources\n\nWhen accept() fails with EMFILE, Linux and FreeBSD leave the pending\nconnection in the listen queue and the level-triggered listener is\nreported again on every wait. The server keeps creating and destroying\nan instance for it, never gets an empty event set, so the timers do not\nrun and hand-window never reaps the idle connections that hold the\ndescriptors: the server stays at 100% CPU, writes the failure to the log\nin a loop and stops serving new TCP and UDP clients until the peer\ncloses its connections. A management client connecting while the\ndescriptors are exhausted causes the same loop on the management\nlistener.\n\nWhen accept() fails for lack of resources, stop polling the TCP\nlisteners and, in server mode, the management listener for up to a\nsecond.\n\nGitHub: OpenVPN/openvpn#1148\nChange-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"83a67bd908e799cc6a97f312a842f29b096c02f2":{"kind":"REWORK","_number":3,"created":"2026-11-18 11:01:21.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/10/2210/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/2210/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3 \u0026\u0026 git checkout -b change-2210 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/10/2210/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18483720191ddd0420de73ca7454296977a28808","subject":"mudp: drop unused addr parameter of do_pre_decrypt_check()"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 12:28:09.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-18 10:48:25.000000000","tz":60},"subject":"socket: pause the listeners when accept() runs out of resources","message":"socket: pause the listeners when accept() runs out of resources\n\nWhen accept() fails with EMFILE, Linux and FreeBSD leave the pending\nconnection in the listen queue and the level-triggered listener is\nreported again on every wait. The server keeps creating and destroying\nan instance for it, never gets an empty event set, so the timers do not\nrun and hand-window never reaps the idle connections that hold the\ndescriptors: the server stays at 100% CPU, writes the failure to the log\nin a loop and stops serving new TCP and UDP clients until the peer\ncloses its connections. A management client connecting while the\ndescriptors are exhausted causes the same loop on the management\nlistener.\n\nWhen accept() fails for lack of resources, stop polling the TCP\nlisteners and, in server mode, the management listener for up to a\nsecond. Clients may see failed connections meanwhile, so log a warning,\nat most once a minute.\n\nGitHub: OpenVPN/openvpn#1148\nChange-Id: I978041ea4e6323f5a92d8721809f0fa44b9c2e03\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
