)]}'
{"id":"openvpn~2211","triplet_id":"openvpn~master~I17fafbe65fd3ff510a72ed809c85b0d19343fad2","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"listener-busy-loop","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 14:07:34.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-18 17:27:37.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2026-11-18 17:27:37.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I17fafbe65fd3ff510a72ed809c85b0d19343fad2","subject":"multi: raise the open files limit for --max-clients","status":"NEW","created":"2026-11-17 14:07:34.000000000","updated":"2026-11-18 17:27:37.000000000","submit_type":"CHERRY_PICK","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9943939f98014b86d8fb648cb6ef8c90bfa5949f","_number":2211,"virtual_id_number":2211,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2026-11-18 17:27:37.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 14:07:34.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 14:07:34.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 18:15:15.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"584a58d8d5919707213cd65424cb76c6ea49af37","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:07:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"65c9603349040e27103f16774e66533d7a01ecfe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:58:24.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"1b2f9277611089363d7de98c4c62561b4506ca19","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-17 18:15:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0ae56ea02500a2fe816f22c3bcfcc2f83b58d66e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-18 11:01:21.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b2d0b1bc2c28c1c0f96544d3ec00a4aafdaf0340","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-18 11:02:13.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"9943939f98014b86d8fb648cb6ef8c90bfa5949f","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-18 17:27:37.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3c042b1a83e5b23c394dec93018c80b9fcceea52","revisions":{"1dd934d1f4a8823fe06f12f3b677c26d5a366dbb":{"kind":"REWORK","_number":1,"created":"2026-11-17 14:07:34.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/11/2211/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/11/2211/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1 \u0026\u0026 git checkout -b change-2211 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f535e804ef8c23e7051b8cf566066a35f6598782","subject":"socket: pause the listeners when accept() runs out of resources"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-06 14:00:14.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:00:15.000000000","tz":60},"subject":"multi: raise the open files limit for --max-clients","message":"multi: raise the open files limit for --max-clients\n\nEvery TCP client takes a file descriptor and accept() happens before the\n--max-clients check, so with the default limits (soft limit 1024,\n--max-clients 1024) the server runs out of descriptors before it can\nrefuse a client.\n\nWhen the server has a TCP listener, raise the soft limit to\n--max-clients plus some room for the other descriptors, up to the hard\nlimit, and warn if that is not enough. Processes started by OpenVPN\ninherit the new limit.\n\nNot on macOS, where the event loop uses select() and cannot watch\ndescriptors \u003e\u003d FD_SETSIZE.\n\nGitHub: closes OpenVPN/openvpn#1148\nChange-Id: I17fafbe65fd3ff510a72ed809c85b0d19343fad2\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"73d6fdaccd4651e1b6d73577ed932559f7b5c483":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-17 14:58:24.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/11/2211/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/11/2211/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2 \u0026\u0026 git checkout -b change-2211 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6e544f6320d31ce0143df4a8253cb988a4e4c8b4","subject":"socket: pause the listeners when accept() runs out of resources"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-06 14:00:14.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:33:08.000000000","tz":60},"subject":"multi: raise the open files limit for --max-clients","message":"multi: raise the open files limit for --max-clients\n\nEvery TCP client takes a file descriptor and accept() happens before the\n--max-clients check, so with the default limits (soft limit 1024,\n--max-clients 1024) the server runs out of descriptors before it can\nrefuse a client.\n\nWhen the server has a TCP listener, raise the soft limit to\n--max-clients plus some room for the other descriptors, up to the hard\nlimit, and warn if that is not enough. Processes started by OpenVPN\ninherit the new limit.\n\nNot on macOS, where the event loop uses select() and cannot watch\ndescriptors \u003e\u003d FD_SETSIZE.\n\nGitHub: closes OpenVPN/openvpn#1148\nChange-Id: I17fafbe65fd3ff510a72ed809c85b0d19343fad2\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"3c042b1a83e5b23c394dec93018c80b9fcceea52":{"kind":"REWORK","_number":3,"created":"2026-11-18 11:01:21.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/11/2211/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/11/2211/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3 \u0026\u0026 git checkout -b change-2211 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/11/2211/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"83a67bd908e799cc6a97f312a842f29b096c02f2","subject":"socket: pause the listeners when accept() runs out of resources"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-06 14:00:14.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-18 10:48:25.000000000","tz":60},"subject":"multi: raise the open files limit for --max-clients","message":"multi: raise the open files limit for --max-clients\n\nEvery TCP client takes a file descriptor and accept() happens before the\n--max-clients check, so with the default limits (soft limit 1024,\n--max-clients 1024) the server runs out of descriptors before it can\nrefuse a client.\n\nWhen the server has a TCP listener, raise the soft limit to\n--max-clients plus some room for the other descriptors, up to the hard\nlimit, and warn if that is not enough. Processes started by OpenVPN\ninherit the new limit.\n\nNot on macOS, where the event loop uses select() and cannot watch\ndescriptors \u003e\u003d FD_SETSIZE.\n\nGitHub: closes OpenVPN/openvpn#1148\nChange-Id: I17fafbe65fd3ff510a72ed809c85b0d19343fad2\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
