)]}'
{"id":"openvpn~2212","triplet_id":"openvpn~master~I06302e82cdc7c98503430500daa4ec95f5ce961f","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"listener-busy-loop","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 14:07:35.000000000","reason":"Reviewer was added"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2026-11-17 14:43:45.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I06302e82cdc7c98503430500daa4ec95f5ce961f","subject":"manage: stop polling the listen socket while a client is connected","status":"NEW","created":"2026-11-17 14:07:34.000000000","updated":"2026-11-18 11:01:21.000000000","submit_type":"CHERRY_PICK","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a161ed228a8a7d58483f0bab97529281bbb6e436","_number":2212,"virtual_id_number":2212,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":2,"date":"2026-11-18 11:01:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 14:07:35.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 14:07:35.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 14:43:45.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"9d40ca1d19f3f7e20353a708f739e85a237ff98b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:07:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ed631e32f672fa04d9da1f6e0059772e3b92b502","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 14:43:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a665063a5424adbc7967e8c451f69c7a48a03db1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-17 14:58:24.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a161ed228a8a7d58483f0bab97529281bbb6e436","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2026-11-18 11:01:21.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"72f4ea6e1403cbbdc90cf746c5650030099ff713","revisions":{"d48e8499aa189cc2e576dc15f7e7dd142ff51e4b":{"kind":"REWORK","_number":1,"created":"2026-11-17 14:07:34.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/12/2212/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/2212/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1 \u0026\u0026 git checkout -b change-2212 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1dd934d1f4a8823fe06f12f3b677c26d5a366dbb","subject":"multi: raise the open files limit for --max-clients"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-12 11:30:50.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:00:15.000000000","tz":60},"subject":"manage: stop polling the listen socket while a client is connected","message":"manage: stop polling the listen socket while a client is connected\n\nIn server mode the management listen socket stays in the persistent\nevent set after a client is accepted. A second connection queued on it\nkeeps it readable, so every event wait returns immediately for the\nmanagement, management_io() finds nothing to do on the client socket,\nand the server spins at 100% CPU while timers starve.\n\nRemove sd_top from the event set on accept; it is re-added when the\nstate goes back to MS_LISTEN. Reset the cached state on removal, so the\nnext update registers the right socket even after an accept or close in\na standalone management loop, and skip the removal when nothing is\nregistered.\n\nTrac: #681\nChange-Id: I06302e82cdc7c98503430500daa4ec95f5ce961f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"46980b1ef35880202d8b41e650f4cf73cd45e6ba":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-11-17 14:58:24.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/12/2212/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/2212/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2 \u0026\u0026 git checkout -b change-2212 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"73d6fdaccd4651e1b6d73577ed932559f7b5c483","subject":"multi: raise the open files limit for --max-clients"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-12 11:30:50.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-17 14:33:08.000000000","tz":60},"subject":"manage: stop polling the listen socket while a client is connected","message":"manage: stop polling the listen socket while a client is connected\n\nIn server mode the management listen socket stays in the persistent\nevent set after a client is accepted. A second connection queued on it\nkeeps it readable, so every event wait returns immediately for the\nmanagement, management_io() finds nothing to do on the client socket,\nand the server spins at 100% CPU while timers starve.\n\nRemove sd_top from the event set on accept; it is re-added when the\nstate goes back to MS_LISTEN. Reset the cached state on removal, so the\nnext update registers the right socket even after an accept or close in\na standalone management loop, and skip the removal when nothing is\nregistered.\n\nTrac: #681\nChange-Id: I06302e82cdc7c98503430500daa4ec95f5ce961f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"72f4ea6e1403cbbdc90cf746c5650030099ff713":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-11-18 11:01:21.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/12/2212/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/12/2212/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3 \u0026\u0026 git checkout -b change-2212 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/12/2212/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3c042b1a83e5b23c394dec93018c80b9fcceea52","subject":"multi: raise the open files limit for --max-clients"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-12 11:30:50.000000000","tz":60},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2026-11-18 10:48:25.000000000","tz":60},"subject":"manage: stop polling the listen socket while a client is connected","message":"manage: stop polling the listen socket while a client is connected\n\nIn server mode the management listen socket stays in the persistent\nevent set after a client is accepted. A second connection queued on it\nkeeps it readable, so every event wait returns immediately for the\nmanagement, management_io() finds nothing to do on the client socket,\nand the server spins at 100% CPU while timers starve.\n\nRemove sd_top from the event set on accept; it is re-added when the\nstate goes back to MS_LISTEN. Reset the cached state on removal, so the\nnext update registers the right socket even after an accept or close in\na standalone management loop, and skip the removal when nothing is\nregistered.\n\nTrac: #681\nChange-Id: I06302e82cdc7c98503430500daa4ec95f5ce961f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"OK"}]}
