)]}'
{"id":"openvpn~2214","triplet_id":"openvpn~master~I33123fe621512376410765031fc9ae68cdd91a6c","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000053":{"account":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"last_update":"2026-11-17 17:47:48.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-11-17 17:47:48.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-11-17 17:15:25.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I33123fe621512376410765031fc9ae68cdd91a6c","subject":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()","status":"MERGED","created":"2026-11-17 17:03:12.000000000","updated":"2026-11-17 17:47:48.000000000","submitted":"2026-11-17 17:47:48.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"2214","meta_rev_id":"63d80479d4baf96d7196f54edaf626399c372f80","_number":2214,"virtual_id_number":2214,"owner":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-17 17:03:12.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2026-11-17 17:03:12.000000000","updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"real_updated_by":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-11-17 17:07:52.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"51d5d804f7a1ae95648b2b74938af99165f9050a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 17:03:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3645d219c84514917d96e8e807aface923bba0e2","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-17 17:07:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"aedd779a3ed76c478c527da631413e53c3cef87a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 17:13:46.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"670874cd982616639f7f739c7a8c8b9c49a5e472","author":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-11-17 17:14:14.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"317a3b2bf58a598a4b6ff2886aba43eec2be7081","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-11-17 17:15:25.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"63d80479d4baf96d7196f54edaf626399c372f80","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2026-11-17 17:47:48.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c19bdda311b56048c2de66d827c09eb3a255019e","revisions":{"cfc1a78e40e0a11ab2ef03577f4bb3aabafaf2cb":{"kind":"REWORK","_number":1,"created":"2026-11-17 17:03:12.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/14/2214/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2214/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1 \u0026\u0026 git checkout -b change-2214 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0561f3eacdca44808a82b59bae2ff9578ccbd9fe","subject":"xkey_digest: free the EVP_MD when EVP_Digest() fails"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 16:59:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 17:01:32.000000000","tz":120},"subject":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()","message":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()\n\nSince 7d46ff17 dropped the -Wsign-conversion pragma, LibreSSL and\nAWS-LC builds fail: their SSL_CTX_set1_groups() takes a size_t length,\nbut glistlen is an int. OpenSSL 1.1.1\u0027s macro passes it to\nSSL_CTX_ctrl() as a long, so add openssl_groups_len_t to pick the type\nper library.\n\nChange-Id: I33123fe621512376410765031fc9ae68cdd91a6c\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"3990c07cdf21e87fd14872c86d1633ee38f86ed8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2026-11-17 17:13:46.000000000","uploader":{"_account_id":1000053,"name":"Răzvan Cojocaru","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"ref":"refs/changes/14/2214/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2214/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2 \u0026\u0026 git checkout -b change-2214 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0561f3eacdca44808a82b59bae2ff9578ccbd9fe","subject":"xkey_digest: free the EVP_MD when EVP_Digest() fails"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 16:59:06.000000000","tz":120},"committer":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 17:12:58.000000000","tz":120},"subject":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()","message":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()\n\nSince 7d46ff17 dropped the -Wsign-conversion pragma, LibreSSL and\nAWS-LC CI builds fail: their SSL_CTX_set1_groups() takes a size_t\nlength, but glistlen is an int.\n\nThe buildbot LibreSSL builds pass because the headers also define\nSSL_CTX_set1_groups as a macro, and clang suppresses warnings in\nexpansions of system header macros. CI includes the libraries with\nplain -I, so their headers aren\u0027t system headers and the warning fires.\n\nOpenSSL 1.1.1\u0027s macro passes the length to SSL_CTX_ctrl() as a long,\nso add openssl_groups_len_t to pick the type per library.\n\nChange-Id: I33123fe621512376410765031fc9ae68cdd91a6c\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\n"},"branch":"refs/heads/master"},"c19bdda311b56048c2de66d827c09eb3a255019e":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2026-11-17 17:47:48.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/14/2214/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/2214/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3 \u0026\u0026 git checkout -b change-2214 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/14/2214/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c1328aae934b27305168fe9a7e259f84c21690e","subject":"options: share the reset code of remove_option() and update_option()"}],"author":{"name":"Razvan Cojocaru","email":"razvanc@mailbox.org","date":"2026-11-17 17:25:18.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2026-11-17 17:30:28.000000000","tz":60},"subject":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()","message":"ssl_openssl: fix -Wsign-conversion in tls_ctx_set_tls_groups()\n\nSince 7d46ff17 dropped the -Wsign-conversion pragma, LibreSSL and\nAWS-LC CI builds fail: their SSL_CTX_set1_groups() takes a size_t\nlength, but glistlen is an int.\n\nThe buildbot LibreSSL builds pass because the headers also define\nSSL_CTX_set1_groups as a macro, and clang suppresses warnings in\nexpansions of system header macros. CI includes the libraries with\nplain -I, so their headers aren\u0027t system headers and the warning fires.\n\nOpenSSL 1.1.1\u0027s macro passes the length to SSL_CTX_ctrl() as a long,\nso add openssl_groups_len_t to pick the type per library.\n\nChange-Id: I33123fe621512376410765031fc9ae68cdd91a6c\nSigned-off-by: Razvan Cojocaru \u003crazvanc@mailbox.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2214\nMessage-Id: \u003c20261117172524.11381-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41565.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
