)]}'
{"id":"openvpn~267","triplet_id":"openvpn~master~I6818b153bdeb1eed65870af99b0531e95807fe0f","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-09-10 12:53:54.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-09-10 12:53:54.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-09-10 12:15:07.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I6818b153bdeb1eed65870af99b0531e95807fe0f","subject":"Various fixes for -Wconversion errors","status":"MERGED","created":"2023-05-10 11:16:38.000000000","updated":"2024-09-10 12:53:54.000000000","submitted":"2024-09-10 12:53:54.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"267-wconversion","meta_rev_id":"4106aa21379b20ae744b3cae36b6eed1fee7a398","_number":267,"virtual_id_number":267,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-07 08:45:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-09-07 08:45:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-09-10 10:56:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"96725cec808bb99d2a3a5954418be5265dbe7c59","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-05-10 11:16:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56ff917e8924f7484351e5cecd4e79a0eac4f970","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-05-10 13:14:26.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3a694dfb3d29c05e33db0885659221d99a0d8037","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-11 15:16:58.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"ad9791782ef350f0ae650b4f8dec08c96299acf1","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-07 08:45:02.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"21c8fca1e964cffd1720af723f1be87961220171","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-08 10:42:34.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"7b5263b0e697462154ceabcbba967a1f3a2e3f72","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 10:30:56.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"f5a025e6054b8cbbef5bef484144a92bd8cce0b9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-20 12:58:39.000000000","message":"Patch Set 5: Patch Set 4 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"3dcb8aee349ac5f0b47c3181106f70eab0763776","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-21 10:10:52.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":5},{"id":"e69e8afabe454345d7852355819c0005f3e92bea","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-10 10:56:14.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"0fc41532ae0067cc609175e49fc8ee32498a9dd9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-09-10 12:14:10.000000000","message":"Uploaded patch set 6.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":6},{"id":"1e4f70983300f0d86f3dd2f15130c7b74d3a12fe","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-09-10 12:15:07.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"4106aa21379b20ae744b3cae36b6eed1fee7a398","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-09-10 12:53:54.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"53449cb61ff569c4862926c7999d50f634030fd9","revisions":{"ca73ac37540123d4b17edea60804ec358cc17bac":{"kind":"REWORK","_number":1,"created":"2023-05-10 11:16:38.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/1 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4850745709c5b80ab7d09c03a86c5ceea6d10a2","subject":"Bugfix: dangling pointer passed to pkcs11-helper"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 11:11:07.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"691ac35e2744a00b7665254675a472e785035906":{"kind":"REWORK","_number":2,"created":"2023-05-10 13:14:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/2 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f4850745709c5b80ab7d09c03a86c5ceea6d10a2","subject":"Bugfix: dangling pointer passed to pkcs11-helper"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 13:10:26.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"155bfad9d2c25419a76256330335d659c68363fc":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-11 15:16:58.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/3 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b","subject":"Print a more user-friendly error when tls-crypt-v2 client auth fails"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-11 15:05:29.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9e05f4f7c6863a0dc55a24acd277c95632098cd6":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-10-08 10:42:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/4 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2671dcb69837ae58b3303f11c1b6ba4cee8eea00","subject":"Log OpenSSL errors on failure to set certificate"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-10-07 14:35:23.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"1bec4d1adf032324f6944590c469aeb304ca64f9":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2023-11-20 12:58:39.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/5 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5faf1b2e90fd44c5137a2b8f3da98c7ae482fc1","subject":"Enable key export with mbed TLS 3.x.y"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2023-11-20 12:58:39.000000000","tz":0},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"bbde24c90bf40de2fbe066a481ff37b6a92b7980":{"kind":"REWORK","_number":6,"created":"2024-09-10 12:14:10.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/67/267/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/6 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa1dd09b5fc196499c84d2ef9b0c254ebb1745d8","subject":"Fix more of uninitialized struct user_pass local vars"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-05-10 10:50:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-09-10 12:12:18.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\nv6:\n - remove change of return value of link_socket_write.\n   Move to separate patch.\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"53449cb61ff569c4862926c7999d50f634030fd9":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2024-09-10 12:53:54.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/67/267/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/67/267/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/7 \u0026\u0026 git checkout -b change-267 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/67/267/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/67/267/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa1dd09b5fc196499c84d2ef9b0c254ebb1745d8","subject":"Fix more of uninitialized struct user_pass local vars"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-09-10 12:20:08.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-09-10 12:31:28.000000000","tz":120},"subject":"Various fixes for -Wconversion errors","message":"Various fixes for -Wconversion errors\n\nThese are all fixes I considered \"safe\". They either\n\n- Have sufficient checks/shifts for a cast to be safe\n- Fix the type of a variable without requiring code changes\n- Are in non-critical unittest code\n\nv2:\n - add min_size instead of abusing min_int\nv6:\n - remove change of return value of link_socket_write.\n   Move to separate patch.\n\nChange-Id: I6818b153bdeb1eed65870af99b0531e95807fe0f\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nMessage-Id: \u003c20240910122008.23507-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg29172.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}