)]}'
{"src/openvpn/options.c":[{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"fba3eb41cc5b38c3fe0130d912db5102bfe74583","unresolved":true,"context_lines":[{"line_number":8670,"context_line":"    else if (streq(p[0], \"no-replay\") \u0026\u0026 !p[1])"},{"line_number":8671,"context_line":"    {"},{"line_number":8672,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":8673,"context_line":"        options-\u003ereplay \u003d false;"},{"line_number":8674,"context_line":"    }"},{"line_number":8675,"context_line":"    else if (streq(p[0], \"replay-window\") \u0026\u0026 !p[3])"},{"line_number":8676,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"de812d09_bfa0eea6","side":"PARENT","line":8673,"updated":"2023-09-19 10:00:58.000000000","message":"Shouldn\u0027t we just remove the whole option instead of this special treatment","commit_id":"7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"33fd78067c6dab4b4fc1f75a17f95a331a670827","unresolved":false,"context_lines":[{"line_number":8670,"context_line":"    else if (streq(p[0], \"no-replay\") \u0026\u0026 !p[1])"},{"line_number":8671,"context_line":"    {"},{"line_number":8672,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":8673,"context_line":"        options-\u003ereplay \u003d false;"},{"line_number":8674,"context_line":"    }"},{"line_number":8675,"context_line":"    else if (streq(p[0], \"replay-window\") \u0026\u0026 !p[3])"},{"line_number":8676,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"b2b1c7b1_a18e7eac","side":"PARENT","line":8673,"in_reply_to":"1925c1c4_fb2ff134","updated":"2023-09-22 10:28:22.000000000","message":"Acknowledged","commit_id":"7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"change_message_id":"20401857498a9162e4d353e6cdf70525f6fed100","unresolved":true,"context_lines":[{"line_number":8670,"context_line":"    else if (streq(p[0], \"no-replay\") \u0026\u0026 !p[1])"},{"line_number":8671,"context_line":"    {"},{"line_number":8672,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":8673,"context_line":"        options-\u003ereplay \u003d false;"},{"line_number":8674,"context_line":"    }"},{"line_number":8675,"context_line":"    else if (streq(p[0], \"replay-window\") \u0026\u0026 !p[3])"},{"line_number":8676,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"1925c1c4_fb2ff134","side":"PARENT","line":8673,"in_reply_to":"c8ca9fc5_3d80c702","updated":"2023-09-19 10:19:45.000000000","message":"Ah, so that even with --ignore-unknown-options this is caught, right","commit_id":"7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ab59e577e4e1f20c025246b66e8d4145b512895f","unresolved":true,"context_lines":[{"line_number":8670,"context_line":"    else if (streq(p[0], \"no-replay\") \u0026\u0026 !p[1])"},{"line_number":8671,"context_line":"    {"},{"line_number":8672,"context_line":"        VERIFY_PERMISSION(OPT_P_GENERAL);"},{"line_number":8673,"context_line":"        options-\u003ereplay \u003d false;"},{"line_number":8674,"context_line":"    }"},{"line_number":8675,"context_line":"    else if (streq(p[0], \"replay-window\") \u0026\u0026 !p[3])"},{"line_number":8676,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c8ca9fc5_3d80c702","side":"PARENT","line":8673,"in_reply_to":"de812d09_bfa0eea6","updated":"2023-09-19 10:16:57.000000000","message":"I think the idea here was that this might lead to hard to diagnose errors down the line if the two sides do not agree on the wire protocol, so we error out hard.","commit_id":"7a477c16a7c2a7016c7b15ea98fe3c40e8ef675b"}]}