)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"81a2ca53e862fadb3c36fa54629465771e1dd978","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add siphash reference implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenSSL only supports SIPHASH with OpenSSL 3.1 and newer. The source code of"},{"line_number":10,"context_line":"siphash is quite small and has very liberal CC0 license, so include it instead"},{"line_number":11,"context_line":"of pulling an extra library for it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3b6b323a_6d247042","line":9,"updated":"2023-02-27 15:09:09.000000000","message":"Later commits enables SIPHASH with OpenSSL 3.0 or newer. So this commit message is wrong?","commit_id":"4521da516369a189059e7447c7e531be56a29dce"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"798124916d1fd00b0052326142af86393aad2237","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add siphash reference implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenSSL only supports SIPHASH with OpenSSL 3.1 and newer. The source code of"},{"line_number":10,"context_line":"siphash is quite small and has very liberal CC0 license, so include it instead"},{"line_number":11,"context_line":"of pulling an extra library for it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8be3aec5_ef735522","line":9,"in_reply_to":"3b6b323a_6d247042","updated":"2023-02-28 00:21:23.000000000","message":"OpenSSL 3.0.0 does not support it but some of the later OpenSSL 3.0.x might already have support for it. But the whole API to allow using the SIPHASH alrady exists in OpenSSL 3.0 and theoretically a provider might already be loaded in OpenSSL 3.0 that implements it.","commit_id":"4521da516369a189059e7447c7e531be56a29dce"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"110b9b30a96ecbb26b97a3dde0267626ecc37af8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add siphash reference implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenSSL only supports SIPHASH with OpenSSL 3.1 and newer. The source code of"},{"line_number":10,"context_line":"siphash is quite small and has very liberal CC0 license, so include it instead"},{"line_number":11,"context_line":"of pulling an extra library for it."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"287ffaf0_2acf65be","line":9,"in_reply_to":"8be3aec5_ef735522","updated":"2023-03-01 13:55:48.000000000","message":"Updated the commit message of the OpenSSL siphash commit to indicate why we use \u003e\u003d 3.0 there.","commit_id":"4521da516369a189059e7447c7e531be56a29dce"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"dc514586e7db43f1279fc55908d20a91a1b47477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"42799e83_1493b8d4","updated":"2024-09-22 12:33:54.000000000","message":"Looks good, just a nitpick","commit_id":"9a0182bba221d885c91fc510ec8678c061c608a0"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"0140c566e73c650fe35fe2adfd67e201de9824a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"444a744a_b4160bcd","updated":"2026-03-12 10:20:00.000000000","message":"I confirmed that the content of siphash_reference.c is the same as the reference implementation at https://github.com/veorq/SipHash/blob/master/siphash.c, disregarding coding style changes.\n\nWhat I don\u0027t quite understand is why you added a MIT license on top of the original Public Domain statement.","commit_id":"c8f3b1a0b5918a1cf08c76b2e50f854cbd35282e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f1b217a553e4c3e2ac6540185e3ebdd8e34ad988","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"514d09bc_00cee567","in_reply_to":"444a744a_b4160bcd","updated":"2026-03-12 13:03:49.000000000","message":"Having a license that I know works well and is clear felt better than interpretation of the public domain. But it does not really matter I guess.","commit_id":"c8f3b1a0b5918a1cf08c76b2e50f854cbd35282e"}],"src/openvpn/siphash.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"81a2ca53e862fadb3c36fa54629465771e1dd978","unresolved":true,"context_lines":[{"line_number":9,"context_line":" * and related and neighboring rights to this software to the public domain"},{"line_number":10,"context_line":" * worldwide. This software is distributed without any warranty."},{"line_number":11,"context_line":" *"},{"line_number":12,"context_line":" * You should have received a copy of the CC0 Public Domain Dedication along"},{"line_number":13,"context_line":" * with"},{"line_number":14,"context_line":" * this software. If not, see"},{"line_number":15,"context_line":" * \u003chttp://creativecommons.org/publicdomain/zero/1.0/\u003e."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"cbaf1fc5_141af59a","line":12,"updated":"2023-02-27 15:09:09.000000000","message":"Should we include a copy of the license?","commit_id":"4521da516369a189059e7447c7e531be56a29dce"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"bf340e27ae61f588dcc3832f3e63c851f6ea5c7e","unresolved":false,"context_lines":[{"line_number":9,"context_line":" * and related and neighboring rights to this software to the public domain"},{"line_number":10,"context_line":" * worldwide. This software is distributed without any warranty."},{"line_number":11,"context_line":" *"},{"line_number":12,"context_line":" * You should have received a copy of the CC0 Public Domain Dedication along"},{"line_number":13,"context_line":" * with"},{"line_number":14,"context_line":" * this software. If not, see"},{"line_number":15,"context_line":" * \u003chttp://creativecommons.org/publicdomain/zero/1.0/\u003e."}],"source_content_type":"text/x-csrc","patch_set":3,"id":"89cd2e32_8fe4435e","line":12,"in_reply_to":"cbaf1fc5_141af59a","updated":"2023-03-06 13:00:00.000000000","message":"Done","commit_id":"4521da516369a189059e7447c7e531be56a29dce"}],"src/openvpn/siphash.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e39ecde9c3a70f1deaec5bdbe7078586c17756af","unresolved":true,"context_lines":[{"line_number":21,"context_line":"#include \u003cinttypes.h\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"/* siphash always uses 128-bit keys */"},{"line_number":24,"context_line":"#define SIPHASH_KEY_SIZE  16"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"int siphash(const void *in, size_t inlen, const void *k, uint8_t *out,"},{"line_number":27,"context_line":"            size_t outlen);"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"8af7dd36_37d91fed","line":24,"updated":"2026-03-12 11:38:02.000000000","message":"clang-format is unhappy with this line","commit_id":"c8f3b1a0b5918a1cf08c76b2e50f854cbd35282e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f1b217a553e4c3e2ac6540185e3ebdd8e34ad988","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#include \u003cinttypes.h\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"/* siphash always uses 128-bit keys */"},{"line_number":24,"context_line":"#define SIPHASH_KEY_SIZE  16"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"int siphash(const void *in, size_t inlen, const void *k, uint8_t *out,"},{"line_number":27,"context_line":"            size_t outlen);"}],"source_content_type":"text/x-csrc","patch_set":8,"id":"bf8b155d_9d0dce3c","line":24,"in_reply_to":"8af7dd36_37d91fed","updated":"2026-03-12 13:03:49.000000000","message":"Done","commit_id":"c8f3b1a0b5918a1cf08c76b2e50f854cbd35282e"}],"src/openvpn/siphash_reference.c":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"dc514586e7db43f1279fc55908d20a91a1b47477","unresolved":true,"context_lines":[{"line_number":26,"context_line":"/* Note:  the reference implementation is also available under CC0 license"},{"line_number":27,"context_line":" * (dual licensed) we included the MIT license here since it is shorter */"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":" #include \"siphash.h\""},{"line_number":30,"context_line":"#include \u003cassert.h\u003e"},{"line_number":31,"context_line":"#include \u003cstddef.h\u003e"},{"line_number":32,"context_line":"#include \u003cstdint.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"e1d16c48_b04f967d","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2024-09-22 12:33:54.000000000","message":"one space too many","commit_id":"9a0182bba221d885c91fc510ec8678c061c608a0"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"0140c566e73c650fe35fe2adfd67e201de9824a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"/* Note:  the reference implementation is also available under CC0 license"},{"line_number":27,"context_line":" * (dual licensed) we included the MIT license here since it is shorter */"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":" #include \"siphash.h\""},{"line_number":30,"context_line":"#include \u003cassert.h\u003e"},{"line_number":31,"context_line":"#include \u003cstddef.h\u003e"},{"line_number":32,"context_line":"#include \u003cstdint.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":6,"id":"660adec6_f9b28633","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"e1d16c48_b04f967d","updated":"2026-03-12 10:20:00.000000000","message":"Done","commit_id":"9a0182bba221d885c91fc510ec8678c061c608a0"}]}