)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"18fb1c2a37667e92718ed1f3db14633962c6f3df","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"03502066_396161e3","updated":"2026-07-24 12:42:50.000000000","message":"Let\u0027s discuss this carefully. That is lot of code we never intend anyone to use in the forseeable future...","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"968d15e081fc24cfcaf5699f3f4457264eacb29f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"12e42382_25d4bcdd","in_reply_to":"03502066_396161e3","updated":"2026-07-27 12:54:21.000000000","message":"I changed the commit to only double our implement (or AWS LC) and also removed the whole context stuff from the previous patch and replaced with a fixed sized array.","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e23aa45088b20d122e6b6703acdc1b68dae5e3d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"da752057_7af20764","in_reply_to":"12e42382_25d4bcdd","updated":"2026-07-30 10:08:33.000000000","message":"Acknowledged","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"}],"CMakeLists.txt":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e23aa45088b20d122e6b6703acdc1b68dae5e3d7","unresolved":true,"context_lines":[{"line_number":798,"context_line":"        src/openvpn/siphash_reference.c"},{"line_number":799,"context_line":"        )"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    target_sources(test_ssl PRIVATE"},{"line_number":804,"context_line":"            tests/unit_tests/openvpn/mock_management.c"}],"source_content_type":"text/x-cmake","patch_set":28,"id":"7c17fa3c_8c8925c9","line":801,"updated":"2026-07-30 10:08:33.000000000","message":"Does this still do anything?","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45a728f186118971babe033775912a415833e6c4","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        src/openvpn/siphash_reference.c"},{"line_number":799,"context_line":"        )"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    target_sources(test_ssl PRIVATE"},{"line_number":804,"context_line":"            tests/unit_tests/openvpn/mock_management.c"}],"source_content_type":"text/x-cmake","patch_set":28,"id":"9105e2b1_f784d6bb","line":801,"in_reply_to":"7c17fa3c_8c8925c9","updated":"2026-07-30 18:23:45.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"08b33eb0f99949dbee4e57cd39fc8d81bd755cd8","unresolved":false,"context_lines":[{"line_number":798,"context_line":"        src/openvpn/siphash_reference.c"},{"line_number":799,"context_line":"        )"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    target_compile_definitions(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH)"},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"    target_sources(test_ssl PRIVATE"},{"line_number":804,"context_line":"            tests/unit_tests/openvpn/mock_management.c"}],"source_content_type":"text/x-cmake","patch_set":28,"id":"d73fbd06_86c1cfda","line":801,"in_reply_to":"7c17fa3c_8c8925c9","updated":"2026-08-08 12:59:12.000000000","message":"Done. Removed","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"}],"src/openvpn/siphash.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8666ffec2f43e6c391ba2b82342e95fa2eb0aef1","unresolved":true,"context_lines":[{"line_number":71,"context_line":"siphash(void *ctx, const void *in, size_t inlen, const void *k,"},{"line_number":72,"context_line":"        uint8_t *out, size_t outlen)"},{"line_number":73,"context_line":"{"},{"line_number":74,"context_line":"    if (siphash_cryptolib_available(ctx) \u0026\u0026 false)"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        return siphash_cryptolib(ctx, in, inlen, k, out, outlen);"},{"line_number":77,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":17,"id":"78464d95_63bffb70","line":74,"updated":"2026-07-17 15:16:16.000000000","message":"\u0026\u0026 false","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2c96a29ccfb515dba003c63ccae04d4c6b08dfd7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"siphash(void *ctx, const void *in, size_t inlen, const void *k,"},{"line_number":72,"context_line":"        uint8_t *out, size_t outlen)"},{"line_number":73,"context_line":"{"},{"line_number":74,"context_line":"    if (siphash_cryptolib_available(ctx) \u0026\u0026 false)"},{"line_number":75,"context_line":"    {"},{"line_number":76,"context_line":"        return siphash_cryptolib(ctx, in, inlen, k, out, outlen);"},{"line_number":77,"context_line":"    }"}],"source_content_type":"text/x-csrc","patch_set":17,"id":"688ba2b3_578a30d1","line":74,"in_reply_to":"78464d95_63bffb70","updated":"2026-07-22 10:24:47.000000000","message":"Acknowledged","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"}],"src/openvpn/siphash_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8ef16c2126e7936ffdc768717ff506976d345c44","unresolved":true,"context_lines":[{"line_number":17,"context_line":" *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the"},{"line_number":18,"context_line":" *  GNU General Public License for more details."},{"line_number":19,"context_line":" *"},{"line_number":20,"context_line":" *  You should have received a copy of the GNU General Public License along"},{"line_number":21,"context_line":" *  with this program; if not, write to the Free Software Foundation, Inc.,"},{"line_number":22,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":23,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"35b7160b_cf0664ea","line":20,"updated":"2026-03-12 11:42:11.000000000","message":"This is an old version of the GPL header, please update to the one currently used in the rest of the files.","commit_id":"dfc6c8afd68d67084577f676fb091542356eba55"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"4e495251e1f5be18f35b85891390ec4a7555dd3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":" *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the"},{"line_number":18,"context_line":" *  GNU General Public License for more details."},{"line_number":19,"context_line":" *"},{"line_number":20,"context_line":" *  You should have received a copy of the GNU General Public License along"},{"line_number":21,"context_line":" *  with this program; if not, write to the Free Software Foundation, Inc.,"},{"line_number":22,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":23,"context_line":" */"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"2d5438c5_a914d406","line":20,"in_reply_to":"35b7160b_cf0664ea","updated":"2026-03-19 13:01:11.000000000","message":"Done","commit_id":"dfc6c8afd68d67084577f676fb091542356eba55"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8ef16c2126e7936ffdc768717ff506976d345c44","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    free(sip_context);"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"#else /* if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L */"},{"line_number":124,"context_line":"/* for now, we only have one implementation of SIPHASH in a libray, so put the"},{"line_number":125,"context_line":" * dummy functions also here */"},{"line_number":126,"context_line":"int"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"e0286fcc_9737f6c0","line":123,"updated":"2026-03-12 11:42:11.000000000","message":"The comment here is wrong","commit_id":"dfc6c8afd68d67084577f676fb091542356eba55"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"fcfb75fcfacdd7c62ef3bdb3ca2713c3d4900e38","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    free(sip_context);"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"#else /* if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L */"},{"line_number":124,"context_line":"/* for now, we only have one implementation of SIPHASH in a libray, so put the"},{"line_number":125,"context_line":" * dummy functions also here */"},{"line_number":126,"context_line":"int"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"c361959b_5b6e82b6","line":123,"in_reply_to":"12f675bd_1df71d40","updated":"2026-03-19 13:05:30.000000000","message":"Done","commit_id":"dfc6c8afd68d67084577f676fb091542356eba55"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"b104396ff77f232ad17d498f910b20735d40c93f","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    free(sip_context);"},{"line_number":121,"context_line":"}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"#else /* if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L */"},{"line_number":124,"context_line":"/* for now, we only have one implementation of SIPHASH in a libray, so put the"},{"line_number":125,"context_line":" * dummy functions also here */"},{"line_number":126,"context_line":"int"}],"source_content_type":"text/x-csrc","patch_set":11,"id":"12f675bd_1df71d40","line":123,"in_reply_to":"e0286fcc_9737f6c0","updated":"2026-03-19 13:03:38.000000000","message":"I will remove the comment since clang format does not seem to enforce this it is better to leave it out then to have to update it every time.","commit_id":"dfc6c8afd68d67084577f676fb091542356eba55"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b63bad86cb5ecec06b08cf9bf25a523350ef7ff0","unresolved":true,"context_lines":[{"line_number":24,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":25,"context_line":"#include \"config.h\""},{"line_number":26,"context_line":"#elif defined(_MSC_VER)"},{"line_number":27,"context_line":"#include \"config-msvc.h\""},{"line_number":28,"context_line":"#endif"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"syshead.h\""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"82eb4c8f_745f931e","line":27,"updated":"2026-07-17 14:56:16.000000000","message":"This shows how old this patch is: config-msvc is gone for years, please remove the reference.","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2c96a29ccfb515dba003c63ccae04d4c6b08dfd7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#ifdef HAVE_CONFIG_H"},{"line_number":25,"context_line":"#include \"config.h\""},{"line_number":26,"context_line":"#elif defined(_MSC_VER)"},{"line_number":27,"context_line":"#include \"config-msvc.h\""},{"line_number":28,"context_line":"#endif"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"syshead.h\""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"0d436523_940cec29","line":27,"in_reply_to":"82eb4c8f_745f931e","updated":"2026-07-22 10:24:47.000000000","message":"Done","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b63bad86cb5ecec06b08cf9bf25a523350ef7ff0","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"syshead.h\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#include \"siphash.h\""},{"line_number":33,"context_line":"#include \"buffer.h\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"c865d631_0d7e7379","line":32,"updated":"2026-07-17 14:56:16.000000000","message":"these includes could move below the enable check","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2c96a29ccfb515dba003c63ccae04d4c6b08dfd7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#include \"syshead.h\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"#include \"siphash.h\""},{"line_number":33,"context_line":"#include \"buffer.h\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":17,"id":"c5d23503_7391547a","line":32,"in_reply_to":"c865d631_0d7e7379","updated":"2026-07-22 10:24:47.000000000","message":"I trimmed the includes to just siphash.h and added crypto_backend.h in the OpenSSL path.","commit_id":"d25ee55822a9d23aaa20648ed86b0d14607f3e0e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b46457002e657ea0f261bf6dae599a046639b136","unresolved":true,"context_lines":[{"line_number":79,"context_line":"siphash_cryptolib_init(size_t hash_size)"},{"line_number":80,"context_line":"{"},{"line_number":81,"context_line":"    struct siphash_context *sip;"},{"line_number":82,"context_line":"    ALLOC_OBJ(sip, struct siphash_context);"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    sip-\u003emac \u003d EVP_MAC_fetch(NULL, \"SIPHASH\", NULL);"},{"line_number":85,"context_line":"    if (!sip-\u003emac)"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"2c678f38_a0049ba5","line":82,"updated":"2026-07-24 10:50:42.000000000","message":"Strictly speaking this requires buffer.h","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eba8f41382bb42229165cf100b312bbc82f7f2d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"siphash_cryptolib_init(size_t hash_size)"},{"line_number":80,"context_line":"{"},{"line_number":81,"context_line":"    struct siphash_context *sip;"},{"line_number":82,"context_line":"    ALLOC_OBJ(sip, struct siphash_context);"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    sip-\u003emac \u003d EVP_MAC_fetch(NULL, \"SIPHASH\", NULL);"},{"line_number":85,"context_line":"    if (!sip-\u003emac)"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"757021fb_e8295323","line":82,"in_reply_to":"2c678f38_a0049ba5","updated":"2026-07-24 11:01:45.000000000","message":"Done","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"}],"tests/unit_tests/openvpn/Makefile.am":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e23aa45088b20d122e6b6703acdc1b68dae5e3d7","unresolved":true,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"ssl_testdriver_CFLAGS  \u003d \\"},{"line_number":101,"context_line":"\t-I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \\"},{"line_number":102,"context_line":"\t-DPREFER_OPENSSL_SIPHASH \\"},{"line_number":103,"context_line":"\t@TEST_CFLAGS@"},{"line_number":104,"context_line":"ssl_testdriver_LDFLAGS \u003d @TEST_LDFLAGS@  $(OPTIONAL_CRYPTO_LIBS)"},{"line_number":105,"context_line":"ssl_testdriver_SOURCES \u003d test_ssl.c \\"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"e3e08277_ebd09952","line":102,"updated":"2026-07-30 10:08:33.000000000","message":"Does this still do anything?","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"08b33eb0f99949dbee4e57cd39fc8d81bd755cd8","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"ssl_testdriver_CFLAGS  \u003d \\"},{"line_number":101,"context_line":"\t-I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \\"},{"line_number":102,"context_line":"\t-DPREFER_OPENSSL_SIPHASH \\"},{"line_number":103,"context_line":"\t@TEST_CFLAGS@"},{"line_number":104,"context_line":"ssl_testdriver_LDFLAGS \u003d @TEST_LDFLAGS@  $(OPTIONAL_CRYPTO_LIBS)"},{"line_number":105,"context_line":"ssl_testdriver_SOURCES \u003d test_ssl.c \\"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"e41f1e6b_00a12cee","line":102,"in_reply_to":"e3e08277_ebd09952","updated":"2026-08-08 12:59:12.000000000","message":"Acknowledged. Removed.","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45a728f186118971babe033775912a415833e6c4","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"ssl_testdriver_CFLAGS  \u003d \\"},{"line_number":101,"context_line":"\t-I$(top_srcdir)/include -I$(top_srcdir)/src/compat -I$(top_srcdir)/src/openvpn \\"},{"line_number":102,"context_line":"\t-DPREFER_OPENSSL_SIPHASH \\"},{"line_number":103,"context_line":"\t@TEST_CFLAGS@"},{"line_number":104,"context_line":"ssl_testdriver_LDFLAGS \u003d @TEST_LDFLAGS@  $(OPTIONAL_CRYPTO_LIBS)"},{"line_number":105,"context_line":"ssl_testdriver_SOURCES \u003d test_ssl.c \\"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"13bc8e15_e9fb0f81","line":102,"in_reply_to":"e3e08277_ebd09952","updated":"2026-07-30 18:23:45.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"}],"tests/unit_tests/openvpn/siphash_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e23aa45088b20d122e6b6703acdc1b68dae5e3d7","unresolved":true,"context_lines":[{"line_number":32,"context_line":"#endif"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* OpenSSL siphash is currently 2-3 times slower than the reference"},{"line_number":35,"context_line":" * implementation, so we only use for unit testing that our impelmentation"},{"line_number":36,"context_line":" * and OpenSSL agree*/"},{"line_number":37,"context_line":"#if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L"},{"line_number":38,"context_line":"#include \u003copenssl/evp.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"54f0abd7_e9a26545","line":35,"updated":"2026-07-30 10:08:33.000000000","message":"\"use it\"\n\"implementation\"","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45a728f186118971babe033775912a415833e6c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#endif"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* OpenSSL siphash is currently 2-3 times slower than the reference"},{"line_number":35,"context_line":" * implementation, so we only use for unit testing that our impelmentation"},{"line_number":36,"context_line":" * and OpenSSL agree*/"},{"line_number":37,"context_line":"#if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L"},{"line_number":38,"context_line":"#include \u003copenssl/evp.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"e652f08a_7890d92e","line":35,"in_reply_to":"54f0abd7_e9a26545","updated":"2026-07-30 18:23:45.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"08b33eb0f99949dbee4e57cd39fc8d81bd755cd8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#endif"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"/* OpenSSL siphash is currently 2-3 times slower than the reference"},{"line_number":35,"context_line":" * implementation, so we only use for unit testing that our impelmentation"},{"line_number":36,"context_line":" * and OpenSSL agree*/"},{"line_number":37,"context_line":"#if defined(ENABLE_CRYPTO_OPENSSL) \u0026\u0026 OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L"},{"line_number":38,"context_line":"#include \u003copenssl/evp.h\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"ec1e29bf_2fa77d39","line":35,"in_reply_to":"54f0abd7_e9a26545","updated":"2026-08-08 12:59:12.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"}],"tests/unit_tests/openvpn/siphash_openssl.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"e23aa45088b20d122e6b6703acdc1b68dae5e3d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SipHash reference C implementation"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Copyright (c) 2012-2021 Jean-Philippe Aumasson"},{"line_number":5,"context_line":" * \u003cjeanphilippe.aumasson@gmail.com\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"3f47a563_e861ae7d","line":2,"updated":"2026-07-30 10:08:33.000000000","message":"Wrong copyright header","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"08b33eb0f99949dbee4e57cd39fc8d81bd755cd8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SipHash reference C implementation"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Copyright (c) 2012-2021 Jean-Philippe Aumasson"},{"line_number":5,"context_line":" * \u003cjeanphilippe.aumasson@gmail.com\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"0c92809c_403132bd","line":2,"in_reply_to":"3f47a563_e861ae7d","updated":"2026-08-08 12:59:12.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45a728f186118971babe033775912a415833e6c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * SipHash reference C implementation"},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Copyright (c) 2012-2021 Jean-Philippe Aumasson"},{"line_number":5,"context_line":" * \u003cjeanphilippe.aumasson@gmail.com\u003e"}],"source_content_type":"text/x-csrc","patch_set":28,"id":"c2a5f74c_9ec317f0","line":2,"in_reply_to":"3f47a563_e861ae7d","updated":"2026-07-30 18:23:45.000000000","message":"Done","commit_id":"bd364225ca43bff02e48a74bc08220ff250e1bc1"}],"tests/unit_tests/openvpn/test_crypto.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b63bad86cb5ecec06b08cf9bf25a523350ef7ff0","unresolved":true,"context_lines":[{"line_number":957,"context_line":"        cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_key_overflow,"},{"line_number":958,"context_line":"                                                 crypto_test_epoch_setup,"},{"line_number":959,"context_line":"                                                 crypto_test_epoch_teardown, \u0026prestate_num32),"},{"line_number":960,"context_line":"        cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_edge,"},{"line_number":961,"context_line":"                                                 crypto_test_epoch_setup,"},{"line_number":962,"context_line":"                                                 crypto_test_epoch_teardown, \u0026prestate_num13),"},{"line_number":963,"context_line":"        cmocka_unit_test(epoch_test_derive_data_key)"}],"source_content_type":"text/x-csrc","patch_set":17,"id":"507c0a42_1dbfd977","side":"PARENT","line":960,"updated":"2026-07-17 14:56:16.000000000","message":"Removes this test. Conflict resolution error?","commit_id":"6e4746b5ad1e73d7bf95b650d780b7a07e7a7506"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2c96a29ccfb515dba003c63ccae04d4c6b08dfd7","unresolved":false,"context_lines":[{"line_number":957,"context_line":"        cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_key_overflow,"},{"line_number":958,"context_line":"                                                 crypto_test_epoch_setup,"},{"line_number":959,"context_line":"                                                 crypto_test_epoch_teardown, \u0026prestate_num32),"},{"line_number":960,"context_line":"        cmocka_unit_test_prestate_setup_teardown(crypto_test_epoch_edge,"},{"line_number":961,"context_line":"                                                 crypto_test_epoch_setup,"},{"line_number":962,"context_line":"                                                 crypto_test_epoch_teardown, \u0026prestate_num13),"},{"line_number":963,"context_line":"        cmocka_unit_test(epoch_test_derive_data_key)"}],"source_content_type":"text/x-csrc","patch_set":17,"id":"d94e0796_6dd8a399","side":"PARENT","line":960,"in_reply_to":"507c0a42_1dbfd977","updated":"2026-07-22 10:24:47.000000000","message":"Acknowledged","commit_id":"6e4746b5ad1e73d7bf95b650d780b7a07e7a7506"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"62db6d1dd65b83587907d5302dcddd71a6069cb6","unresolved":true,"context_lines":[{"line_number":932,"context_line":"static void"},{"line_number":933,"context_line":"test_siphash(void **state)"},{"line_number":934,"context_line":"{"},{"line_number":935,"context_line":"    const char *message \u003d \"Look behind you, a Three-Headed Monkey!\";"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    uint8_t out[UT_SIPHASH_HASH_SIZE] \u003d { 0 };"},{"line_number":938,"context_line":"    const uint8_t key[SIPHASH_KEY_SIZE] \u003d { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66 };"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"53a360eb_afdbef74","line":935,"updated":"2026-07-24 10:47:11.000000000","message":"All this test data is duplicated, could be shared between the two tests","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0eba8f41382bb42229165cf100b312bbc82f7f2d","unresolved":false,"context_lines":[{"line_number":932,"context_line":"static void"},{"line_number":933,"context_line":"test_siphash(void **state)"},{"line_number":934,"context_line":"{"},{"line_number":935,"context_line":"    const char *message \u003d \"Look behind you, a Three-Headed Monkey!\";"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"    uint8_t out[UT_SIPHASH_HASH_SIZE] \u003d { 0 };"},{"line_number":938,"context_line":"    const uint8_t key[SIPHASH_KEY_SIZE] \u003d { 0x11, 0x22, 0x33, 0x44, 0x55, 0x66 };"}],"source_content_type":"text/x-csrc","patch_set":20,"id":"436475ab_bd3ca198","line":935,"in_reply_to":"53a360eb_afdbef74","updated":"2026-07-24 11:01:45.000000000","message":"Done","commit_id":"7f223f70b33634472d7e5329855567546ce327ff"}]}