)]}'
{"id":"openvpn~315","triplet_id":"openvpn~release%2F2.6~I6de18261d5dc7f8561612184059656c73f33a5f2","project":"openvpn","branch":"release/2.6","topic":"cmake-2.6","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-09-26 09:49:28.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2023-09-26 15:55:11.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-09-25 09:50:56.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I6de18261d5dc7f8561612184059656c73f33a5f2","subject":"CMake: backport CMake buildsystem from master to release/2.6","status":"MERGED","created":"2023-07-21 13:55:29.000000000","updated":"2023-09-26 15:55:11.000000000","submitted":"2023-09-26 15:55:11.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"315-cmake-2.6","meta_rev_id":"7d90b871b4fc2ac9f8c600a8206bd7341149f10e","_number":315,"virtual_id_number":315,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-21 13:55:32.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-07-24 12:48:53.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"CC"},{"updated":"2023-07-24 12:52:49.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2023-09-18 22:20:36.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"078c66b6fd376b99da56226ff1c87e4a3fb45ea5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-21 13:55:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e15e5e1ebc72f09912352ccb25c912beb91182d","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-24 12:48:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ae43d9b32fc25fb0030885dfddf9ae1e2393e57f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-24 12:52:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3a352497bef3f7366e426fae720e032e87aee3b4","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2023-09-18 22:20:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f1ceaa56d4ad211ff76ec91bd59f4ccb58ccf60b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-19 11:37:17.000000000","message":"Patch Set 1:\n\n(5 comments)","accounts_in_message":[],"_revision_number":1},{"id":"29eb8f9701f2bafbf8b0e3bbf017911154974a37","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-22 16:28:39.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c58087feae88955dcf6f882c705d4ea4154bceda","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-09-25 09:50:56.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e70ea599d37a7ce3cffec0e16728add91b598ba6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-26 09:40:34.000000000","message":"Patch Set 3: Patch Set 2 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"f8d73b33a3441ad87338a98e3f0dc72eb59387b4","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-26 09:49:28.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7d90b871b4fc2ac9f8c600a8206bd7341149f10e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-09-26 15:55:11.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"96ca5a5a2a0b278f6cc47199fc3311143fd9a6b7","revisions":{"0a71acb9a49c805729a26b74adc8ce763bd2b705":{"kind":"REWORK","_number":1,"created":"2023-07-21 13:55:29.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/15/315/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/15/315/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/1 \u0026\u0026 git checkout -b change-315 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/15/315/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7385f406d59a33c7f2919aacfd17834623cf67f3","subject":"buffer: use memcpy in buf_catrunc"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-21 13:19:31.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-21 13:31:55.000000000","tz":120},"subject":"CMake: backport CMake buildsystem from master to release/2.6","message":"CMake: backport CMake buildsystem from master to release/2.6\n\nThis is based on the initial CMake patch by\nArne Schwabe, but extends that to provide\na complete replacement for existing MinGW\nbuild (autotools based) and MSVC build\n(openvpn.sln).\n\nThe following features are added while switching\nthese builds to CMake:\n - vcpkg support for MinGW build, allowing for\n   trivial cross-compilation on Linux\n - Add unittests to MSVC build\n - Rework MSVC config header generation, removing\n   need for separate headers between autotools\n   and MSVC\n\nThe following advantages are reasons for switching\nto CMake over the existing MSVC build:\n - Easier to maintain CMake files without IDE\n   than the sln and vcxproj files\n - Able to maintain MSVC and MinGW build side-by-side\n\nThe plan is to completely remove the existing MSVC\nbuild system but leave the existing autotools builds\nin place as-is, including MinGW support.\n\nCMake is not the intended build system for Unix-like\nplatforms and there are no current plans to switch\nto it.\n\nThis commits squashes a lot of commits from master\ntogether, since most of them are just fixes or\nenhancements for the original CMake commit. The\ndecisions was not to bloat the release/2.6 commit\nhistory with these detours.\n\nIt contains the following commits:\n- add basic CMake based build\n  (commit 0134184012dd46ec44cbca7eb3ece39037ae0bfa by\n   Arne Schwabe)\n- CMake: Add complete MinGW and MSVC build\n  (commit e8881ec6dd63bd80ce05202573eac54ab8657fcb)\n- CMake: Add /Brepro to MSVC link options\n  (commit 5e94e8de4bfaf6637124947a3489710b591e5e26)\n- Do not blindly assume python3 is also the interpreter that runs rst2html\n  (commit 5dbec1c019d14880ae7bf364b062d3589c7fd9e7 by\n   Arne Schwabe)\n- Only add -Wno-stringop-truncation on supported compilers\n  (commit eb3cd5ea36f9bf235da7b8a51fd6ce29780f0e39 by\n   Arne Schwabe)\n- CMake: Throw a clear error when config.h in top-level source directory\n  (commit 0652ae84f4528daa57da344eee28b7385a6659a1)\n- openvpnmsica: link C runtime statically\n  (commit 3be4986ea3d6e27acd3e3a317c15dfe07688e135 by\n   Lev Stipakov)\n- CMake: Support doc builds on Windows machines that do not have .py file association\n  (commit 22213a8834ba5ba5c9818015730edbf3766ad915)\n- README.cmake.md: Add new documentation for CMake buildsystem\n  (commit 53055fd23efb6209b12d3662427158e25247f1fe)\n- Check if the -wrap argument is actually supported by the platform\u0027s ld\n  (commit 4ef76f0ee4e122dcd616e1b1e2d652562ab10756 by\n   Arne Schwabe)\n- GHA: update to run-vcpkg@v11\n  (commit 66e33ee81d1d7fa3495ae3aad6e673766e296687)\n- GHA: refactor mingw UTs and add missing tls_crypt\n  (commit 26c663f12815f55c483dbe660e28448dc63221d1)\n\nChange-Id: I6de18261d5dc7f8561612184059656c73f33a5f2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nCo-authored-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nCo-authored-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"6bc60e66b5e104e035dc3042a90a4a45c3b3997f":{"kind":"REWORK","_number":2,"created":"2023-09-22 16:28:39.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/15/315/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/15/315/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/2 \u0026\u0026 git checkout -b change-315 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/15/315/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5619c36085457aa47df70f1da0ce0d1f74dd103b","subject":"buffer: use memcpy in buf_catrunc"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-21 13:19:31.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-09-22 16:22:05.000000000","tz":120},"subject":"CMake: backport CMake buildsystem from master to release/2.6","message":"CMake: backport CMake buildsystem from master to release/2.6\n\nThis is based on the initial CMake patch by\nArne Schwabe, but extends that to provide\na complete replacement for existing MinGW\nbuild (autotools based) and MSVC build\n(openvpn.sln).\n\nThe following features are added while switching\nthese builds to CMake:\n - vcpkg support for MinGW build, allowing for\n   trivial cross-compilation on Linux\n - Add unittests to MSVC build\n - Rework MSVC config header generation, removing\n   need for separate headers between autotools\n   and MSVC\n\nThe following advantages are reasons for switching\nto CMake over the existing MSVC build:\n - Easier to maintain CMake files without IDE\n   than the sln and vcxproj files\n - Able to maintain MSVC and MinGW build side-by-side\n\nThe plan is to completely remove the existing MSVC\nbuild system but leave the existing autotools builds\nin place as-is, including MinGW support.\n\nCMake is not the intended build system for Unix-like\nplatforms and there are no current plans to switch\nto it.\n\nThis commits squashes a lot of commits from master\ntogether, since most of them are just fixes or\nenhancements for the original CMake commit. The\ndecisions was not to bloat the release/2.6 commit\nhistory with these detours.\n\nIt contains the following commits:\n- add basic CMake based build\n  (commit 0134184012dd46ec44cbca7eb3ece39037ae0bfa by\n   Arne Schwabe)\n- CMake: Add complete MinGW and MSVC build\n  (commit e8881ec6dd63bd80ce05202573eac54ab8657fcb)\n- CMake: Add /Brepro to MSVC link options\n  (commit 5e94e8de4bfaf6637124947a3489710b591e5e26)\n- Do not blindly assume python3 is also the interpreter that runs rst2html\n  (commit 5dbec1c019d14880ae7bf364b062d3589c7fd9e7 by\n   Arne Schwabe)\n- Only add -Wno-stringop-truncation on supported compilers\n  (commit eb3cd5ea36f9bf235da7b8a51fd6ce29780f0e39 by\n   Arne Schwabe)\n- CMake: Throw a clear error when config.h in top-level source directory\n  (commit 0652ae84f4528daa57da344eee28b7385a6659a1)\n- openvpnmsica: link C runtime statically\n  (commit 3be4986ea3d6e27acd3e3a317c15dfe07688e135 by\n   Lev Stipakov)\n- CMake: Support doc builds on Windows machines that do not have .py file association\n  (commit 22213a8834ba5ba5c9818015730edbf3766ad915)\n- README.cmake.md: Add new documentation for CMake buildsystem\n  (commit 53055fd23efb6209b12d3662427158e25247f1fe)\n- Check if the -wrap argument is actually supported by the platform\u0027s ld\n  (commit 4ef76f0ee4e122dcd616e1b1e2d652562ab10756 by\n   Arne Schwabe)\n- GHA: update to run-vcpkg@v11\n  (commit 66e33ee81d1d7fa3495ae3aad6e673766e296687)\n- GHA: refactor mingw UTs and add missing tls_crypt\n  (commit 26c663f12815f55c483dbe660e28448dc63221d1)\n- CMake: various small non-functional improvements\n  (commit 95cc5faa16833acaf12a4d273c5c848984fc73ce)\n- CMake: fix broken daemonization and syslog functionality\n  (commit 8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd)\n- CMake: fix HAVE_DAEMON detection on Linux\n  (commit e363b393f2d1b72590666554e17d928c1603f8d5)\n\nChange-Id: I6de18261d5dc7f8561612184059656c73f33a5f2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nCo-authored-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nCo-authored-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"c2767323eddbb9e6b43a0eb995a6d02dbe22bc2c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-09-26 09:40:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/15/315/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/15/315/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/3 \u0026\u0026 git checkout -b change-315 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/15/315/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cce957a5b6ed11b0fa35a97e0e638ea00f9921ef","subject":"vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-21 13:19:31.000000000","tz":120},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2023-09-26 09:40:34.000000000","tz":0},"subject":"CMake: backport CMake buildsystem from master to release/2.6","message":"CMake: backport CMake buildsystem from master to release/2.6\n\nThis is based on the initial CMake patch by\nArne Schwabe, but extends that to provide\na complete replacement for existing MinGW\nbuild (autotools based) and MSVC build\n(openvpn.sln).\n\nThe following features are added while switching\nthese builds to CMake:\n - vcpkg support for MinGW build, allowing for\n   trivial cross-compilation on Linux\n - Add unittests to MSVC build\n - Rework MSVC config header generation, removing\n   need for separate headers between autotools\n   and MSVC\n\nThe following advantages are reasons for switching\nto CMake over the existing MSVC build:\n - Easier to maintain CMake files without IDE\n   than the sln and vcxproj files\n - Able to maintain MSVC and MinGW build side-by-side\n\nThe plan is to completely remove the existing MSVC\nbuild system but leave the existing autotools builds\nin place as-is, including MinGW support.\n\nCMake is not the intended build system for Unix-like\nplatforms and there are no current plans to switch\nto it.\n\nThis commits squashes a lot of commits from master\ntogether, since most of them are just fixes or\nenhancements for the original CMake commit. The\ndecisions was not to bloat the release/2.6 commit\nhistory with these detours.\n\nIt contains the following commits:\n- add basic CMake based build\n  (commit 0134184012dd46ec44cbca7eb3ece39037ae0bfa by\n   Arne Schwabe)\n- CMake: Add complete MinGW and MSVC build\n  (commit e8881ec6dd63bd80ce05202573eac54ab8657fcb)\n- CMake: Add /Brepro to MSVC link options\n  (commit 5e94e8de4bfaf6637124947a3489710b591e5e26)\n- Do not blindly assume python3 is also the interpreter that runs rst2html\n  (commit 5dbec1c019d14880ae7bf364b062d3589c7fd9e7 by\n   Arne Schwabe)\n- Only add -Wno-stringop-truncation on supported compilers\n  (commit eb3cd5ea36f9bf235da7b8a51fd6ce29780f0e39 by\n   Arne Schwabe)\n- CMake: Throw a clear error when config.h in top-level source directory\n  (commit 0652ae84f4528daa57da344eee28b7385a6659a1)\n- openvpnmsica: link C runtime statically\n  (commit 3be4986ea3d6e27acd3e3a317c15dfe07688e135 by\n   Lev Stipakov)\n- CMake: Support doc builds on Windows machines that do not have .py file association\n  (commit 22213a8834ba5ba5c9818015730edbf3766ad915)\n- README.cmake.md: Add new documentation for CMake buildsystem\n  (commit 53055fd23efb6209b12d3662427158e25247f1fe)\n- Check if the -wrap argument is actually supported by the platform\u0027s ld\n  (commit 4ef76f0ee4e122dcd616e1b1e2d652562ab10756 by\n   Arne Schwabe)\n- GHA: update to run-vcpkg@v11\n  (commit 66e33ee81d1d7fa3495ae3aad6e673766e296687)\n- GHA: refactor mingw UTs and add missing tls_crypt\n  (commit 26c663f12815f55c483dbe660e28448dc63221d1)\n- CMake: various small non-functional improvements\n  (commit 95cc5faa16833acaf12a4d273c5c848984fc73ce)\n- CMake: fix broken daemonization and syslog functionality\n  (commit 8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd)\n- CMake: fix HAVE_DAEMON detection on Linux\n  (commit e363b393f2d1b72590666554e17d928c1603f8d5)\n\nChange-Id: I6de18261d5dc7f8561612184059656c73f33a5f2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nCo-authored-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nCo-authored-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6","description":"Rebase"},"96ca5a5a2a0b278f6cc47199fc3311143fd9a6b7":{"kind":"REWORK","_number":4,"created":"2023-09-26 15:55:11.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/15/315/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/15/315/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/4 \u0026\u0026 git checkout -b change-315 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/15/315/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/15/315/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cce957a5b6ed11b0fa35a97e0e638ea00f9921ef","subject":"vcpkg-ports/pkcs11-helper: Backport MinGW series from master to release/2.6"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-09-26 09:50:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-09-26 15:39:51.000000000","tz":120},"subject":"CMake: backport CMake buildsystem from master to release/2.6","message":"CMake: backport CMake buildsystem from master to release/2.6\n\nThis is based on the initial CMake patch by\nArne Schwabe, but extends that to provide\na complete replacement for existing MinGW\nbuild (autotools based) and MSVC build\n(openvpn.sln).\n\nThe following features are added while switching\nthese builds to CMake:\n - vcpkg support for MinGW build, allowing for\n   trivial cross-compilation on Linux\n - Add unittests to MSVC build\n - Rework MSVC config header generation, removing\n   need for separate headers between autotools\n   and MSVC\n\nThe following advantages are reasons for switching\nto CMake over the existing MSVC build:\n - Easier to maintain CMake files without IDE\n   than the sln and vcxproj files\n - Able to maintain MSVC and MinGW build side-by-side\n\nThe plan is to completely remove the existing MSVC\nbuild system but leave the existing autotools builds\nin place as-is, including MinGW support.\n\nCMake is not the intended build system for Unix-like\nplatforms and there are no current plans to switch\nto it.\n\nThis commits squashes a lot of commits from master\ntogether, since most of them are just fixes or\nenhancements for the original CMake commit. The\ndecisions was not to bloat the release/2.6 commit\nhistory with these detours.\n\nIt contains the following commits:\n- add basic CMake based build\n  (commit 0134184012dd46ec44cbca7eb3ece39037ae0bfa by\n   Arne Schwabe)\n- CMake: Add complete MinGW and MSVC build\n  (commit e8881ec6dd63bd80ce05202573eac54ab8657fcb)\n- CMake: Add /Brepro to MSVC link options\n  (commit 5e94e8de4bfaf6637124947a3489710b591e5e26)\n- Do not blindly assume python3 is also the interpreter that runs rst2html\n  (commit 5dbec1c019d14880ae7bf364b062d3589c7fd9e7 by\n   Arne Schwabe)\n- Only add -Wno-stringop-truncation on supported compilers\n  (commit eb3cd5ea36f9bf235da7b8a51fd6ce29780f0e39 by\n   Arne Schwabe)\n- CMake: Throw a clear error when config.h in top-level source directory\n  (commit 0652ae84f4528daa57da344eee28b7385a6659a1)\n- openvpnmsica: link C runtime statically\n  (commit 3be4986ea3d6e27acd3e3a317c15dfe07688e135 by\n   Lev Stipakov)\n- CMake: Support doc builds on Windows machines that do not have .py file association\n  (commit 22213a8834ba5ba5c9818015730edbf3766ad915)\n- README.cmake.md: Add new documentation for CMake buildsystem\n  (commit 53055fd23efb6209b12d3662427158e25247f1fe)\n- Check if the -wrap argument is actually supported by the platform\u0027s ld\n  (commit 4ef76f0ee4e122dcd616e1b1e2d652562ab10756 by\n   Arne Schwabe)\n- GHA: update to run-vcpkg@v11\n  (commit 66e33ee81d1d7fa3495ae3aad6e673766e296687)\n- GHA: refactor mingw UTs and add missing tls_crypt\n  (commit 26c663f12815f55c483dbe660e28448dc63221d1)\n- CMake: various small non-functional improvements\n  (commit 95cc5faa16833acaf12a4d273c5c848984fc73ce)\n- CMake: fix broken daemonization and syslog functionality\n  (commit 8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd)\n- CMake: fix HAVE_DAEMON detection on Linux\n  (commit e363b393f2d1b72590666554e17d928c1603f8d5)\n\nChange-Id: I6de18261d5dc7f8561612184059656c73f33a5f2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nCo-authored-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nCo-authored-by: Lev Stipakov \u003clev@openvpn.net\u003e\nMessage-Id: \u003c20230926095030.29779-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27107.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}