)]}'
{"id":"openvpn~318","triplet_id":"openvpn~master~I45cd0917d24570ae9e9db7eb6c370756e4595842","project":"openvpn","branch":"master","topic":"coverity-fixes","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-10-08 09:13:59.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-17 14:23:40.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I45cd0917d24570ae9e9db7eb6c370756e4595842","subject":"Fix various \u0027Uninitialized scalar variable\u0027 warnings from Coverity","status":"MERGED","created":"2023-07-28 13:03:21.000000000","updated":"2024-01-17 14:23:40.000000000","submitted":"2024-01-17 14:23:40.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"318-coverity-fixes","meta_rev_id":"4df3be0a8822264ee47a1e423741860b4679517d","_number":318,"virtual_id_number":318,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-28 13:03:22.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-10-07 11:40:08.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"e2284f56179ad8b3e2303020eea0d16b30696ed1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-28 13:03:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"485d9365f8c1370632f24865a43632d9dfe86072","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-08 09:13:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cb6be857d5b89a570a94c9b4fb6c7ef0629f2f75","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-09 10:09:00.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"4c00fd8e587d320751f674c87d980e999cb8786e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 11:08:56.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"4df3be0a8822264ee47a1e423741860b4679517d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-17 14:23:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"327355f5174772ad2c788aaeb2a7b4db39cff385","revisions":{"7852d95351385c0d4a666c874856f31606c802aa":{"kind":"REWORK","_number":1,"created":"2023-07-28 13:03:21.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/18/318/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/318/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/1 \u0026\u0026 git checkout -b change-318 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/318/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b563f4b0c428718fb4cff85e477ce22aecae808c","subject":"pkcs11_openssl: Disable unused code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:44:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:44:57.000000000","tz":120},"subject":"Fix various \"Uninitialized scalar variable\" warnings from Coverity","message":"Fix various \"Uninitialized scalar variable\" warnings from Coverity\n\nThese are all not actually problems, since the\nuninitialized parts are either .unused members of the\nstruct (mroute_addr) or only written to (buflen), but\nstill doesn\u0027t hurt to explicitely initialize them.\n\nChange-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"03c8f4467eba348c0c0fc81ec978e8301e867b0c":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-01-09 11:08:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/18/318/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/318/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/2 \u0026\u0026 git checkout -b change-318 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/318/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f0a17ed8513405af0efb1df2ab2bda3956e01910","subject":"Move get_tmp_dir to win32-util.c and error out on failure"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:44:57.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 11:08:26.000000000","tz":60},"subject":"Fix various \"Uninitialized scalar variable\" warnings from Coverity","message":"Fix various \"Uninitialized scalar variable\" warnings from Coverity\n\nThese are all not actually problems, since the\nuninitialized parts are either .unused members of the\nstruct (mroute_addr) or only written to (buflen), but\nstill doesn\u0027t hurt to explicitely initialize them.\n\nChange-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"327355f5174772ad2c788aaeb2a7b4db39cff385":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2024-01-17 14:23:40.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/18/318/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/18/318/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/3 \u0026\u0026 git checkout -b change-318 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/18/318/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/18/318/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4bcb38c42ae62a3c3511511eb4ffe0d66b8e32eb","subject":"cmake: symlink whole build dir not just .json file"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-10-08 10:36:41.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-17 14:05:30.000000000","tz":60},"subject":"Fix various \u0027Uninitialized scalar variable\u0027 warnings from Coverity","message":"Fix various \u0027Uninitialized scalar variable\u0027 warnings from Coverity\n\nThese are all not actually problems, since the\nuninitialized parts are either .unused members of the\nstruct (mroute_addr) or only written to (buflen), but\nstill doesn\u0027t hurt to explicitely initialize them.\n\nChange-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20231008103641.19864-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27157.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}