)]}'
{"id":"openvpn~320","triplet_id":"openvpn~master~I9f9d0f0d5ab03f8cdfd7ba7200f2d56613cc586d","project":"openvpn","branch":"master","topic":"coverity-fixes","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-08-11 14:52:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9f9d0f0d5ab03f8cdfd7ba7200f2d56613cc586d","subject":"options: Do not hide variables from parent scope","status":"MERGED","created":"2023-07-28 13:03:21.000000000","updated":"2023-08-11 14:52:50.000000000","submitted":"2023-08-11 14:52:50.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"320-coverity-fixes","meta_rev_id":"882978641c96477f108b1c7397b5a36901ea9f5d","_number":320,"virtual_id_number":320,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-28 13:03:23.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-08-10 13:49:43.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"81de86249ed785483b6092fc5551312bcdb593b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-28 13:03:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28f40a71e19d70c57732eb8a3d6c693244a68ad5","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-08-10 13:49:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"882978641c96477f108b1c7397b5a36901ea9f5d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-08-11 14:52:50.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f7c8cc092b8b6f5659cf8abd8d8624fc16f3dda2","revisions":{"0f3ed145e38a7a3a45cc34f9e590f8f9976e6a6f":{"kind":"REWORK","_number":1,"created":"2023-07-28 13:03:21.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/20/320/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/320/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/1 \u0026\u0026 git checkout -b change-320 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/320/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"17d713f7605c24f09e2b2773b01f539b72006bc1","subject":"route: Fix overriding return value of add_route3"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:50:16.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:50:16.000000000","tz":120},"subject":"options: Do not hide variables from parent scope","message":"options: Do not hide variables from parent scope\n\nmsglevel hides the function parameter of the same name,\nwhich could lead to confusion. Use a unique name.\n\nChange-Id: I9f9d0f0d5ab03f8cdfd7ba7200f2d56613cc586d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"f7c8cc092b8b6f5659cf8abd8d8624fc16f3dda2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2023-08-11 14:52:50.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/20/320/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/320/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/2 \u0026\u0026 git checkout -b change-320 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/20/320/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/20/320/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"18826de5737789cb74b48fc40a9ff5cb37d38d98","subject":"Set WINS servers via interactice service"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-07-28 12:50:16.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-08-11 14:47:53.000000000","tz":120},"subject":"options: Do not hide variables from parent scope","message":"options: Do not hide variables from parent scope\n\nmsglevel hides the function parameter of the same name,\nwhich could lead to confusion. Use a unique name.\n\nChange-Id: I9f9d0f0d5ab03f8cdfd7ba7200f2d56613cc586d\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nMessage-Id: \u003cd549c9b5e5d66624ef82f99206898ff8e43a5fb5-HTML@gerrit.openvpn.net\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26902.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}