)]}'
{"id":"openvpn~321","triplet_id":"openvpn~release%2F2.6~I47c22dcb728011dcedaae47cd03a57219e9c7607","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-08-11 14:44:22.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2023-08-11 14:44:22.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-08-07 09:03:20.000000000","reason":"removed on reply"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2023-08-11 14:44:22.000000000","reason":"Change was submitted"},"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2023-08-11 14:44:22.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-08-11 14:44:22.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I47c22dcb728011dcedaae47cd03a57219e9c7607","subject":"Set WINS servers via interactice service","status":"MERGED","created":"2023-07-28 13:18:08.000000000","updated":"2023-08-11 14:44:22.000000000","submitted":"2023-08-11 14:44:22.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":16,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"321","meta_rev_id":"b280475ebac6c5065688b0793577ff1ff30e0fbf","_number":321,"virtual_id_number":321,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-07-28 13:18:08.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-07-28 13:18:08.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-07-31 08:52:19.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"},{"updated":"2023-07-31 08:52:19.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"},{"updated":"2023-07-31 08:52:19.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"},{"updated":"2023-07-31 08:52:19.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"4cbe47af22d951c35bed8fabf8390fadf31a197d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-28 13:18:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6525fea8c5accc882a731b1f1f4389cb3ae70a3","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-31 09:29:57.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"7e28afc340e2cc7db9be4f39687a2fe3b4e9ee1a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-31 11:27:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"78ff8a5a82bba14e1c41f8c21fe5fcbba49f297a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-31 11:28:03.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"55b78243d2cbe1bd3f8015b10363ef849719b909","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-31 11:28:31.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"28b2b058c88986463214c2ea0e65d433fefd0e00","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-07-31 11:30:27.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"de04a6b7fc75df598fab24cf0fcdc7645f7d55b5","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-07-31 11:43:19.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"551e0df2addfacea383c4a6d6e523eb534b5c1ba","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-07-31 15:16:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"73a8a5443c4b45bdaa945fbc71d9b6af29a5a7d4","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-07-31 16:37:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3a3039b1140e7bc820a204de56ed0a33e311d250","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-08-01 06:26:29.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3a0620928fd82856f3d8d45cfe202fe27b940816","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-08-07 09:03:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d984e6fbdde2cc17d7ce3130defad9be72b713ed","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-08-07 09:03:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b280475ebac6c5065688b0793577ff1ff30e0fbf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-08-11 14:44:22.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"64a75e75b8929f1290ba984f60d0c13447a41407","revisions":{"43af15708f8a3ab3417f39aebd52cdf09534dc0d":{"kind":"REWORK","_number":1,"created":"2023-07-28 13:18:08.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/321/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/321/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/1 \u0026\u0026 git checkout -b change-321 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/321/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f0e7dd1444e3d29773c6b701f53afa4cadac970","subject":"configure.ac: fix typ0 in LIBCAPNG_CFALGS"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-27 15:47:06.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-28 13:17:51.000000000","tz":180},"subject":"Set WINS servers via interactice service","message":"Set WINS servers via interactice service\n\nAt the moments WINS servers are set either:\n\n - via DHCP, which works only for tap-windows6 driver\n - via netsh when running without interactice service\n\nThis means that in 2.6 default setup (interactive service and dco)\nWINS is silently ignored.\n\nAdd WINS support for non-DHCP drivers (like dco) by passing\nWINS settings to interactive service and set them there with\nnetsh call, similar approach as we use for setting DNS.\n\nFixes https://github.com/OpenVPN/openvpn/issues/373\n\nChange-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"05605201d9732148fe3ca6c30b0b558ee09d5fa6":{"kind":"REWORK","_number":2,"created":"2023-07-31 11:27:00.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/321/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/321/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/2 \u0026\u0026 git checkout -b change-321 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/321/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a717c0df0c551d62c780c2d9f9d84ebf7aba67dc","subject":"add basic CMake based build"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-27 15:47:06.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-31 11:26:50.000000000","tz":180},"subject":"Set WINS servers via interactice service","message":"Set WINS servers via interactice service\n\nAt the moments WINS servers are set either:\n\n - via DHCP, which works only for tap-windows6 driver\n - via netsh when running without interactice service\n\nThis means that in 2.6 default setup (interactive service and dco)\nWINS is silently ignored.\n\nAdd WINS support for non-DHCP drivers (like dco) by passing\nWINS settings to interactive service and set them there with\nnetsh call, similar approach as we use for setting DNS.\n\nFixes https://github.com/OpenVPN/openvpn/issues/373\n\nChange-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"2135d75a06a93b2c83cd0a6a9a9e198f707862e5":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-07-31 11:28:03.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/321/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/321/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/3 \u0026\u0026 git checkout -b change-321 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/321/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f0e7dd1444e3d29773c6b701f53afa4cadac970","subject":"configure.ac: fix typ0 in LIBCAPNG_CFALGS"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-27 15:47:06.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-31 11:27:50.000000000","tz":180},"subject":"Set WINS servers via interactice service","message":"Set WINS servers via interactice service\n\nAt the moments WINS servers are set either:\n\n - via DHCP, which works only for tap-windows6 driver\n - via netsh when running without interactice service\n\nThis means that in 2.6 default setup (interactive service and dco)\nWINS is silently ignored.\n\nAdd WINS support for non-DHCP drivers (like dco) by passing\nWINS settings to interactive service and set them there with\nnetsh call, similar approach as we use for setting DNS.\n\nFixes https://github.com/OpenVPN/openvpn/issues/373\n\nChange-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"64a75e75b8929f1290ba984f60d0c13447a41407":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2023-08-11 14:44:22.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/21/321/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/321/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/4 \u0026\u0026 git checkout -b change-321 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/21/321/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/21/321/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2f0e7dd1444e3d29773c6b701f53afa4cadac970","subject":"configure.ac: fix typ0 in LIBCAPNG_CFALGS"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-07-27 15:47:06.000000000","tz":180},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-08-11 13:51:49.000000000","tz":120},"subject":"Set WINS servers via interactice service","message":"Set WINS servers via interactice service\n\nAt the moments WINS servers are set either:\n\n - via DHCP, which works only for tap-windows6 driver\n - via netsh when running without interactice service\n\nThis means that in 2.6 default setup (interactive service and dco)\nWINS is silently ignored.\n\nAdd WINS support for non-DHCP drivers (like dco) by passing\nWINS settings to interactive service and set them there with\nnetsh call, similar approach as we use for setting DNS.\n\nFixes https://github.com/OpenVPN/openvpn/issues/373\n\nChange-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20230728131246.694-1-lstipakov@gmail.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26903.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit 18826de5737789cb74b48fc40a9ff5cb37d38d98)\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}