)]}'
{"id":"openvpn~325","triplet_id":"openvpn~master~I4f29953b91cf8e8daf2c9503da44073ad96d0ff5","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-10-13 17:43:52.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-10-09 10:01:50.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I4f29953b91cf8e8daf2c9503da44073ad96d0ff5","subject":"Remove ability to use configurations without TLS by default","status":"MERGED","created":"2023-08-18 13:15:56.000000000","updated":"2023-10-13 17:43:52.000000000","submitted":"2023-10-13 17:43:52.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":25,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"325","meta_rev_id":"72a7a48b3c0b927fc5e81937f173359a328a38e4","_number":325,"virtual_id_number":325,"owner":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-08-18 13:15:56.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-08-18 13:15:56.000000000","updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"real_updated_by":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"8eadc22b0b3088b52c0e98b7a561ca106dcbaaca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-08-18 13:15:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"26073300ad28c5433cc5c2a125b91a3e40eac0d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-08-18 13:16:17.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"fae0cc753da60d1da7048b7a761053d930d20b78","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-08-21 09:26:40.000000000","message":"Patch Set 2: Code-Review-1\n\n(7 comments)","accounts_in_message":[],"_revision_number":2},{"id":"0f53e01c2900047523da435d6ba23c331ddeaa9a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-07 09:47:09.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"57888bd2610ef1975441f43a7c25635a30cd2e0f","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-07 13:10:11.000000000","message":"Patch Set 3: Code-Review+1\n\n(7 comments)","accounts_in_message":[],"_revision_number":3},{"id":"39b5ae48dae7798c274f60d3950016bc1e76275d","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-08 09:47:12.000000000","message":"Patch Set 3:\n\n(6 comments)","accounts_in_message":[],"_revision_number":3},{"id":"942e7c9abdcd7f62092feeabf6cc7d270415bf12","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-08 11:45:35.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8dcf0e0857448b6de0459d94928e33460006f04b","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-08 13:45:03.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"98ceeff8bf361f1adc2498902bd2ac58a0c0a4b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-08 13:48:09.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"6adaf82af1b12d4610ee03d5a9175ff9cee75078","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-09 10:01:50.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"d3ee169d013cc2b9ef7c168aeee243dc624a35f9","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-09 11:00:45.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"72a7a48b3c0b927fc5e81937f173359a328a38e4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-13 17:43:52.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"392da5bdaaa94ca7e3e32f16084b47fc20b2c22d","revisions":{"3ae8758c09eaa8c5ed30a58291914ed5a17b496d":{"kind":"REWORK","_number":1,"created":"2023-08-18 13:15:56.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/25/325/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/325/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/1 \u0026\u0026 git checkout -b change-325 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/25/325/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f910a42b86e90f1893a668ee280422b6587ada1","subject":"Make received OCC exit messages more visible in log."}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 11:49:48.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 13:15:13.000000000","tz":120},"subject":"Remove ability to use configurations without TLS by default","message":"Remove ability to use configurations without TLS by default\n\nOpenVPN 2.6 already warned about this feature being removed. OpenVPN\n2.7 will with this change no longer accept these configurations without\nhaving a --allow-deprecated-insecure-static-crypto added to the command\nline or the configuration itself. This will server as a last and final\nwarning for people who missed the warning message in OpenVPN 2.6.\n\nThis commit also removes the documentation for --secret and the static key\nmode.\n\nChange-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5\n"},"branch":"refs/heads/master"},"6d1c4046f16727b9925abc46b2a12ca383fadf12":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-08-18 13:16:17.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/25/325/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/325/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/2 \u0026\u0026 git checkout -b change-325 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/25/325/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f910a42b86e90f1893a668ee280422b6587ada1","subject":"Make received OCC exit messages more visible in log."}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 11:49:48.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 13:16:10.000000000","tz":120},"subject":"Remove ability to use configurations without TLS by default","message":"Remove ability to use configurations without TLS by default\n\nOpenVPN 2.6 already warned about this feature being removed. OpenVPN\n2.7 will with this change no longer accept these configurations without\nhaving a --allow-deprecated-insecure-static-crypto added to the command\nline or the configuration itself. This will server as a last and final\nwarning for people who missed the warning message in OpenVPN 2.6.\n\nThis commit also removes the documentation for --secret and the static key\nmode.\n\nChange-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"7ededfb1f8b2e5ed2b140d0e1e16847e927c9947":{"kind":"REWORK","_number":3,"created":"2023-10-07 09:47:09.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/25/325/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/325/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/3 \u0026\u0026 git checkout -b change-325 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/25/325/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2671dcb69837ae58b3303f11c1b6ba4cee8eea00","subject":"Log OpenSSL errors on failure to set certificate"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 11:49:48.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-10-07 09:46:45.000000000","tz":120},"subject":"Remove ability to use configurations without TLS by default","message":"Remove ability to use configurations without TLS by default\n\nOpenVPN 2.6 already warned about this feature being removed. OpenVPN\n2.7 will with this change no longer accept these configurations without\nhaving a --allow-deprecated-insecure-static-crypto added to the command\nline or the configuration itself. This will serve as a last and final\nwarning for people who missed the warning message in OpenVPN 2.6.\n\nThis commit also removes the documentation for --secret and the static key\nmode.\n\nChange-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"d45207e173bf8362a5d5cd5f5bb61c49a4f4e56d":{"kind":"REWORK","_number":4,"created":"2023-10-08 13:48:09.000000000","uploader":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/25/325/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/325/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/4 \u0026\u0026 git checkout -b change-325 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/25/325/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2671dcb69837ae58b3303f11c1b6ba4cee8eea00","subject":"Log OpenSSL errors on failure to set certificate"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-08-18 11:49:48.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-10-08 13:48:06.000000000","tz":120},"subject":"Remove ability to use configurations without TLS by default","message":"Remove ability to use configurations without TLS by default\n\nOpenVPN 2.6 already warned about this feature being removed. OpenVPN\n2.7 will with this change no longer accept these configurations without\nhaving a --allow-deprecated-insecure-static-crypto added to the command\nline or the configuration itself. This will serve as a last and final\nwarning for people who missed the warning message in OpenVPN 2.6.\n\nThis commit also removes the documentation for --secret and the static key\nmode.\n\nChange-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"392da5bdaaa94ca7e3e32f16084b47fc20b2c22d":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2023-10-13 17:43:52.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/25/325/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/25/325/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/5 \u0026\u0026 git checkout -b change-325 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/25/325/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/25/325/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9e99ac54a6373a259ed82f45fbbf9e7a1b38ab6b","subject":"doc: fix argument name in --route-delay documentation"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-10-09 10:58:32.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-10-13 15:52:13.000000000","tz":120},"subject":"Remove ability to use configurations without TLS by default","message":"Remove ability to use configurations without TLS by default\n\nOpenVPN 2.6 already warned about this feature being removed. OpenVPN\n2.7 will with this change no longer accept these configurations without\nhaving a --allow-deprecated-insecure-static-crypto added to the command\nline or the configuration itself. This will serve as a last and final\nwarning for people who missed the warning message in OpenVPN 2.6.\n\nThis commit also removes the documentation for --secret and the static key\nmode.\n\nChange-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20231009105832.34762-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27194.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}