)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1d5087ace26bcc7a32c0795867dcaaff6aaecac","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Support for long INFO/INFO_PRE messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current hardcoded limit is not defined anywhere and"},{"line_number":10,"context_line":"the server (CloudConnexa) sends the longer string in some cases."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2139b62117ba69d643b585d2610e8aef15f71d3e"},{"line_number":13,"context_line":"Signed-off-by: Lev Stipakov \u003clev@openvpn.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"90da86d9_5dc75b60","line":10,"updated":"2023-09-04 14:39:24.000000000","message":"\"sends the longer string\" -\u003e \"sends longer messages\"","commit_id":"1e9418d8abbb65a0b5dbb5c16abfba99d3d6f19b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1d5087ace26bcc7a32c0795867dcaaff6aaecac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a302a10_01d236f8","updated":"2023-09-04 14:39:24.000000000","message":"looks technically okay","commit_id":"1e9418d8abbb65a0b5dbb5c16abfba99d3d6f19b"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2daf06e7772b9f0af537090699a17fcbad905e76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00793529_192d22ac","updated":"2023-09-05 13:46:58.000000000","message":"This is something that only affects the properitary Cloud implementation. OpenVPN 2.x will also never send longer URLs since we are currently limited by the MAX_PARAM_SIZE (\u003d256) define on sending URLs to the client.","commit_id":"c5e4c8b6f756553e860ff468176fd37dc577c088"}],"src/openvpn/push.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b1d5087ace26bcc7a32c0795867dcaaff6aaecac","unresolved":true,"context_lines":[{"line_number":243,"context_line":"         * We use \u003eINFOMSG here instead of plain \u003eINFO since INFO is used to"},{"line_number":244,"context_line":"         * for management greeting and we don\u0027t want to confuse the client"},{"line_number":245,"context_line":"         */"},{"line_number":246,"context_line":"        struct buffer out \u003d alloc_buf_gc(1 + 7 + 1 + BLEN(\u0026buf) + 1, \u0026gc);"},{"line_number":247,"context_line":"        buf_printf(\u0026out, \"\u003e%s:%s\", \"INFOMSG\", m);"},{"line_number":248,"context_line":"        management_notify_generic(management, BSTR(\u0026out));"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"cf2407e8_9d3632ee","line":246,"updated":"2023-09-04 14:39:24.000000000","message":"\"1 + 7 + 1\" -\u003e strlen(\"\u003eINFOMSG:\")\nmight even move the \"\u003eINFOMSG:\" into a preprocessor define and then reuse it.","commit_id":"1e9418d8abbb65a0b5dbb5c16abfba99d3d6f19b"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"106601ea82951ea5d1543ffb81fa6a507eef7b4e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"         * We use \u003eINFOMSG here instead of plain \u003eINFO since INFO is used to"},{"line_number":244,"context_line":"         * for management greeting and we don\u0027t want to confuse the client"},{"line_number":245,"context_line":"         */"},{"line_number":246,"context_line":"        struct buffer out \u003d alloc_buf_gc(1 + 7 + 1 + BLEN(\u0026buf) + 1, \u0026gc);"},{"line_number":247,"context_line":"        buf_printf(\u0026out, \"\u003e%s:%s\", \"INFOMSG\", m);"},{"line_number":248,"context_line":"        management_notify_generic(management, BSTR(\u0026out));"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a70eded3_8b1ba798","line":246,"in_reply_to":"cf2407e8_9d3632ee","updated":"2023-09-04 15:44:36.000000000","message":"Acknowledged","commit_id":"1e9418d8abbb65a0b5dbb5c16abfba99d3d6f19b"}]}
