)]}'
{"id":"openvpn~341","triplet_id":"openvpn~master~I171d55da2be868d961caa1d4491e6f1ed10ebe8a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-09-15 13:08:16.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-09-20 20:36:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I171d55da2be868d961caa1d4491e6f1ed10ebe8a","subject":"CMake: fix broken daemonization and syslog functionality","status":"MERGED","created":"2023-09-15 13:04:10.000000000","updated":"2023-09-20 20:36:01.000000000","submitted":"2023-09-20 20:36:01.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"341","meta_rev_id":"d3291ba121dd475a0e365901b729b1b41031864b","_number":341,"virtual_id_number":341,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-15 13:04:11.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-09-15 13:04:11.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-09-15 13:18:58.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"964c9fee00c7f54ea30ecec6988501252b51d8c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-09-15 13:04:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"845753c9e67bc698df548b9a6f137f9d2d3bc524","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-15 13:08:16.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7d8b7eb8508719d53e931b350bef6c8fe3b1aac","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-09-15 13:18:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d3291ba121dd475a0e365901b729b1b41031864b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-09-20 20:36:01.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd","revisions":{"272a4173e1b357a51489501732dcb59dc320e86e":{"kind":"REWORK","_number":1,"created":"2023-09-15 13:04:10.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/41/341/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/341/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/1 \u0026\u0026 git checkout -b change-341 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/341/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0793eb105c5720c4eb31af71c9db81459439e510","subject":"dco: fix crash when --multihome is used with --proto tcp"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-09-15 12:05:40.000000000","tz":0},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-09-15 13:03:11.000000000","tz":120},"subject":"CMake: fix broken daemonization and syslog functionality","message":"CMake: fix broken daemonization and syslog functionality\n\nWhile CMake is not the official way to build OpenVPN on Linux,\nit still make sense to support it. Turns out that\n\n  HAVE_SETSID, HAVE_OPENLOG and HAVE_SYSLOG\n\nwere not set by CMake configure, and --daemon and syslog\nfunctionality was broken.\n\nWhile on it, fix compiler error on unused return value of chdir().\n\nChange-Id: I171d55da2be868d961caa1d4491e6f1ed10ebe8a\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-09-20 20:36:01.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/341/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/341/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/2 \u0026\u0026 git checkout -b change-341 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/341/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/341/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0793eb105c5720c4eb31af71c9db81459439e510","subject":"dco: fix crash when --multihome is used with --proto tcp"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-09-20 12:15:19.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-09-20 20:30:37.000000000","tz":120},"subject":"CMake: fix broken daemonization and syslog functionality","message":"CMake: fix broken daemonization and syslog functionality\n\nWhile CMake is not the official way to build OpenVPN on Linux,\nit still make sense to support it. Turns out that\n\n  HAVE_SETSID, HAVE_OPENLOG and HAVE_SYSLOG\n\nwere not set by CMake configure, and --daemon and syslog\nfunctionality was broken.\n\nWhile on it, fix compiler error on unused return value of chdir().\n\nChange-Id: I171d55da2be868d961caa1d4491e6f1ed10ebe8a\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20230920121519.177949-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27045.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}