)]}'
{"id":"openvpn~342","triplet_id":"openvpn~master~I4e16767ee221e1aefdd18d13b3411c27d8dd844a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-09-21 20:45:17.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2023-09-21 20:45:17.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-09-19 12:22:30.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I4e16767ee221e1aefdd18d13b3411c27d8dd844a","subject":"CMake: various small non-functional improvements","status":"MERGED","created":"2023-09-19 11:44:23.000000000","updated":"2023-09-21 20:45:17.000000000","submitted":"2023-09-21 20:45:17.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"342","meta_rev_id":"23d936e1b4864f16602ecd0038ef3da4555b5c86","_number":342,"virtual_id_number":342,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"}],"reviewers":{"REVIEWER":[{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-19 11:44:24.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-09-19 11:45:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"state":"REVIEWER"},{"updated":"2023-09-19 11:45:02.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"}],"messages":[{"id":"9d18e7dc7c82fdbab97d0dc8e6385d11cb611bc2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-19 11:44:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"584f42713a96abcfdd5a9c95db11892214bc9fd5","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-09-19 11:45:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c6f26611faced0197d848148b1699c34f5d71429","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-09-19 12:22:30.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b0e4c2b1b5e435cd4b374fc60ff8964acf059130","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-09-19 12:22:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"23d936e1b4864f16602ecd0038ef3da4555b5c86","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-09-21 20:45:17.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"95cc5faa16833acaf12a4d273c5c848984fc73ce","revisions":{"00a11a7b4e001933b06e4648780bcdf416a68b62":{"kind":"REWORK","_number":1,"created":"2023-09-19 11:44:23.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/42/342/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/342/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/1 \u0026\u0026 git checkout -b change-342 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/342/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0793eb105c5720c4eb31af71c9db81459439e510","subject":"dco: fix crash when --multihome is used with --proto tcp"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-09-19 11:38:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-09-19 11:38:55.000000000","tz":120},"subject":"CMake: various small non-functional improvements","message":"CMake: various small non-functional improvements\n\nThese are based on review comments for the 2.6 backport.\nBut since they apply to the original master implementation\nas well, I address them in this separate patch.\n\n- Add documentation to contrib/cmake/*.py\n- Fix grammar in README.cmake.md\n- Update a TODO in CMakeLists.txt to better reflect\n  the status quo\n- Fix indentation in unit_tests\u0027 Makefile.am\n\nChange-Id: I4e16767ee221e1aefdd18d13b3411c27d8dd844a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"95cc5faa16833acaf12a4d273c5c848984fc73ce":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2023-09-21 20:45:17.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/42/342/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/42/342/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/2 \u0026\u0026 git checkout -b change-342 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/42/342/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/42/342/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ae6c48d5d52dec8ec6e47cc1cfe89de9f2ffbcd","subject":"CMake: fix broken daemonization and syslog functionality"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-09-19 15:56:35.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-09-21 20:43:54.000000000","tz":120},"subject":"CMake: various small non-functional improvements","message":"CMake: various small non-functional improvements\n\nThese are based on review comments for the 2.6 backport.\nBut since they apply to the original master implementation\nas well, I address them in this separate patch.\n\n- Add documentation to contrib/cmake/*.py\n- Fix grammar in README.cmake.md\n- Update a TODO in CMakeLists.txt to better reflect\n  the status quo\n- Fix indentation in unit_tests\u0027 Makefile.am\n\nChange-Id: I4e16767ee221e1aefdd18d13b3411c27d8dd844a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Lev Stipakov \u003clstipakov@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/342\nMessage-Id: \u003c20230919155635.708557-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27043.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}