)]}'
{"id":"openvpn~363","triplet_id":"openvpn~master~Ic7ec25ac0503a91d5869b8da966d0065f264af22","project":"openvpn","branch":"master","topic":"cert-errors","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-10-02 08:30:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ic7ec25ac0503a91d5869b8da966d0065f264af22","subject":"Log OpenSSL errors on failure to set certificate","status":"MERGED","created":"2023-10-01 18:02:48.000000000","updated":"2023-10-02 08:30:05.000000000","submitted":"2023-10-02 08:30:05.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"363-cert-errors","meta_rev_id":"80a3a3e06c449f9f747d97dc49191c4cf13647d2","_number":363,"virtual_id_number":363,"owner":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-01 18:02:48.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-10-01 18:02:48.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"500ce8fd7d29c2f22024d4bda74cd3203ac06920","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-10-01 18:02:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e9aa940e06c40ecf0ef4cac23904686d1f59df8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-10-01 19:06:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5e7ee6a01bb8c3b7fdce194af747f8dc95da746f","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-10-01 19:07:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"bd88ced723cc08f3557ab25204220c9fc9628405","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2023-10-01 19:08:26.000000000","message":"Removed Code-Review+2 by \u003cGERRIT_ACCOUNT_1000009\u003e\n","accounts_in_message":[{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"_revision_number":2},{"id":"80a3a3e06c449f9f747d97dc49191c4cf13647d2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-02 08:30:05.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2671dcb69837ae58b3303f11c1b6ba4cee8eea00","revisions":{"d8b3a9a1345cb0e1c62a02f9a5b62df45b8850f4":{"kind":"REWORK","_number":1,"created":"2023-10-01 18:02:48.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/63/363/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/363/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/1 \u0026\u0026 git checkout -b change-363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/363/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"607ae9b821665dadb6bd0a3ceb6288bda10d5e67","subject":"GHA: new workflow to submit scan to Coverity Scan service"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2023-09-29 22:09:06.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2023-10-01 18:02:42.000000000","tz":-240},"subject":"Log OpenSSL errors on failure to set certificate","message":"Log OpenSSL errors on failure to set certificate\n\nCurrently we log a bogus error message saying private key password verification\nfailed when SSL_CTX_use_cert_and_key() fails in pkcs11_openssl.c. Instead print\nOpenSSL error queue and exit promptly.\n\nAlso log OpenSSL errors when SSL_CTX_use_certiifcate() fails in cryptoapi.c\nand elsewhere. Such logging could be useful especially when the ceritficate is\nrejected by OpenSSL due to stricter security restrictions in recent versions\nof the library.\n\nChange-Id: Ic7ec25ac0503a91d5869b8da966d0065f264af22\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"c1489990d8e8ab95ca5e2c11b1b55bb19ba201f8":{"kind":"REWORK","_number":2,"created":"2023-10-01 19:06:43.000000000","uploader":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"ref":"refs/changes/63/363/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/363/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/2 \u0026\u0026 git checkout -b change-363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/363/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"607ae9b821665dadb6bd0a3ceb6288bda10d5e67","subject":"GHA: new workflow to submit scan to Coverity Scan service"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2023-09-29 22:09:06.000000000","tz":-240},"committer":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2023-10-01 19:01:49.000000000","tz":-240},"subject":"Log OpenSSL errors on failure to set certificate","message":"Log OpenSSL errors on failure to set certificate\n\nCurrently we log a bogus error message saying private key password verification\nfailed when SSL_CTX_use_cert_and_key() fails in pkcs11_openssl.c. Instead print\nOpenSSL error queue and exit promptly.\n\nAlso log OpenSSL errors when SSL_CTX_use_certiifcate() fails in cryptoapi.c\nand elsewhere. Such logging could be useful especially when the ceritficate is\nrejected by OpenSSL due to stricter security restrictions in recent versions\nof the library.\n\nChange-Id: Ic7ec25ac0503a91d5869b8da966d0065f264af22\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\n"},"branch":"refs/heads/master"},"2671dcb69837ae58b3303f11c1b6ba4cee8eea00":{"kind":"REWORK","_number":3,"created":"2023-10-02 08:30:05.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/63/363/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/63/363/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/3 \u0026\u0026 git checkout -b change-363 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/63/363/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/63/363/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"607ae9b821665dadb6bd0a3ceb6288bda10d5e67","subject":"GHA: new workflow to submit scan to Coverity Scan service"}],"author":{"name":"Selva Nair","email":"selva.nair@gmail.com","date":"2023-10-01 17:49:20.000000000","tz":-240},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-10-02 08:08:56.000000000","tz":120},"subject":"Log OpenSSL errors on failure to set certificate","message":"Log OpenSSL errors on failure to set certificate\n\nCurrently we log a bogus error message saying private key password\nverification failed when SSL_CTX_use_cert_and_key() fails in\npkcs11_openssl.c. Instead print OpenSSL error queue and exit promptly.\n\nAlso log OpenSSL errors when SSL_CTX_use_certiifcate() fails in\ncryptoapi.c and elsewhere. Such logging could be useful especially when\nthe ceritficate is rejected by OpenSSL due to stricter security\nrestrictions in recent versions of the library.\n\nChange-Id: Ic7ec25ac0503a91d5869b8da966d0065f264af22\nSigned-off-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nAcked-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nMessage-Id: \u003c20231001174920.54154-1-selva.nair@gmail.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27122.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}