)]}'
{"id":"openvpn~368","triplet_id":"openvpn~release%2F2.6~I8cb2cb083e3cdadf187b7874979d79af3974e759","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-10-22 10:49:05.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-10-22 10:49:05.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-10-22 10:49:05.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I8cb2cb083e3cdadf187b7874979d79af3974e759","subject":"dco: warn if DATA_V1 packets are sent to userspace","status":"MERGED","created":"2023-10-07 13:26:36.000000000","updated":"2023-10-22 10:49:05.000000000","submitted":"2023-10-22 10:49:05.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"368","meta_rev_id":"443b081af9d3342fc0c5bbd059f473635ace46bd","_number":368,"virtual_id_number":368,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-07 13:26:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-10-07 13:26:36.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-10-08 10:46:06.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2023-10-22 06:51:27.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"1b7fb1b6c138e557d891c6063ceebfadffd42f00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-10-07 13:26:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bfbb1d984ef2e5c69b4bff0e9ae7d0c356c34030","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-07 13:37:59.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"914e972fc4246a8b09b87c9bf38ea75f4521db41","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-08 10:46:06.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cafd60ba0443d3733a634e3c7ab5ce075f530d01","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-09 10:06:37.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"7600425edad23da4e2fdab976af9e637919cd164","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-10-16 12:08:26.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"180d993c8c4758036754b5779ba88907b7119816","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-10-16 12:09:26.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"eb3634d5f7e01e009f43799440b57fd934dbc29d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-22 06:51:27.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"443b081af9d3342fc0c5bbd059f473635ace46bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-22 10:49:05.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e78f88d8ea113585ca16945ef0361710b838ec7d","revisions":{"d8d2d6bdd34610b7ef8e3d5e9fabb5eed6da83e0":{"kind":"REWORK","_number":1,"created":"2023-10-07 13:26:36.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/68/368/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/368/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/1 \u0026\u0026 git checkout -b change-368 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/368/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ebfa5f3811e92863a3bbcc53b7a3f1b29dff1bc1","subject":"Log OpenSSL errors on failure to set certificate"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-07 12:58:54.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-07 13:24:03.000000000","tz":120},"subject":"dco: warn if DATA_V1 packets are sent to userspace","message":"dco: warn if DATA_V1 packets are sent to userspace\n\nServers 2.4.0 - 2.4.4 support peer-id and AEAD ciphers,\nbut only send DATA_V1 packets. With DCO enabled on the\nclient, connection is established but not working.\n\nThis is because DCO driver(s) are unable to handle\nDATA_V1 packets and forwards them to userspace, where\nthey silently disappear since crypto context is in\nDCO and not in userspace.\n\nStarting from 2.4.5 server sends DATA_V2 so problem\ndoesn\u0027t happen.\n\nWe cannot switch to non-DCO on the fly, so we log this\nand advice user to upgrade the server to 2.4.5 or newer.\n\nThis fixes https://github.com/OpenVPN/openvpn/issues/422\n\nChange-Id: I8cb2cb083e3cdadf187b7874979d79af3974e759\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"fa4083692fefb9c94ff9366cdabe56fa52c62b72":{"kind":"REWORK","_number":2,"created":"2023-10-16 12:08:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/68/368/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/368/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/2 \u0026\u0026 git checkout -b change-368 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/368/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ebfa5f3811e92863a3bbcc53b7a3f1b29dff1bc1","subject":"Log OpenSSL errors on failure to set certificate"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-07 12:58:54.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-16 12:05:14.000000000","tz":180},"subject":"dco: warn if DATA_V1 packets are sent to userspace","message":"dco: warn if DATA_V1 packets are sent to userspace\n\nServers 2.4.0 - 2.4.4 support peer-id and AEAD ciphers,\nbut only send DATA_V1 packets. With DCO enabled on the\nclient, connection is established but not working.\n\nThis is because DCO driver(s) are unable to handle\nDATA_V1 packets and forwards them to userspace, where\nthey silently disappear since crypto context is in\nDCO and not in userspace.\n\nStarting from 2.4.5 server sends DATA_V2 so problem\ndoesn\u0027t happen.\n\nWe cannot switch to non-DCO on the fly, so we log this\nand advice user to upgrade the server to 2.4.5 or newer.\n\nThis fixes https://github.com/OpenVPN/openvpn/issues/422\n\nChange-Id: I8cb2cb083e3cdadf187b7874979d79af3974e759\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"a94fdc73c8b5aeda0405a2e9b27c88c313c3e107":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-10-16 12:09:26.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/68/368/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/368/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/3 \u0026\u0026 git checkout -b change-368 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/368/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c54e1b226e9d6709cdc2b243e6a961a6cd47c7c6","subject":"dco-win: get driver version"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-07 12:58:54.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-16 12:09:17.000000000","tz":180},"subject":"dco: warn if DATA_V1 packets are sent to userspace","message":"dco: warn if DATA_V1 packets are sent to userspace\n\nServers 2.4.0 - 2.4.4 support peer-id and AEAD ciphers,\nbut only send DATA_V1 packets. With DCO enabled on the\nclient, connection is established but not working.\n\nThis is because DCO driver(s) are unable to handle\nDATA_V1 packets and forwards them to userspace, where\nthey silently disappear since crypto context is in\nDCO and not in userspace.\n\nStarting from 2.4.5 server sends DATA_V2 so problem\ndoesn\u0027t happen.\n\nWe cannot switch to non-DCO on the fly, so we log this\nand advice user to upgrade the server to 2.4.5 or newer.\n\nThis fixes https://github.com/OpenVPN/openvpn/issues/422\n\nChange-Id: I8cb2cb083e3cdadf187b7874979d79af3974e759\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"e78f88d8ea113585ca16945ef0361710b838ec7d":{"kind":"REWORK","_number":4,"created":"2023-10-22 10:49:05.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/68/368/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/368/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/4 \u0026\u0026 git checkout -b change-368 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/68/368/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/68/368/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8bbc2926e620bcf995e6697e614a2716b572c07d","subject":"Remove openssl engine method for loading the key"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-10-22 08:27:40.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-10-22 08:59:35.000000000","tz":120},"subject":"dco: warn if DATA_V1 packets are sent to userspace","message":"dco: warn if DATA_V1 packets are sent to userspace\n\nServers 2.4.0 - 2.4.4 support peer-id and AEAD ciphers,\nbut only send DATA_V1 packets. With DCO enabled on the\nclient, connection is established but not working.\n\nThis is because DCO driver(s) are unable to handle\nDATA_V1 packets and forwards them to userspace, where\nthey silently disappear since crypto context is in\nDCO and not in userspace.\n\nStarting from 2.4.5 server sends DATA_V2 so problem\ndoesn\u0027t happen.\n\nWe cannot switch to non-DCO on the fly, so we log this\nand advice user to upgrade the server to 2.4.5 or newer.\n\nGithub: fixes OpenVPN/openvpn#422\n\nChange-Id: I8cb2cb083e3cdadf187b7874979d79af3974e759\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20231022082751.8868-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27272.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n(cherry picked from commit df7beea404df48745a608c584d863c5a377b7a1e)\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}