)]}'
{"id":"openvpn~370","triplet_id":"openvpn~master~I445a93e84dc54b865b757038d22318ac427fce96","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-10-27 15:41:53.000000000","reason":"\u003cGERRIT_ACCOUNT_1000003\u003e replied on the change","reason_account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-10-24 11:29:27.000000000","reason":"removed on reply"},"1000030":{"account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2023-10-29 21:50:24.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I445a93e84dc54b865b757038d22318ac427fce96","subject":"Add support for mbedtls 3.X.Y","status":"MERGED","created":"2023-10-17 17:05:54.000000000","updated":"2023-10-29 21:50:24.000000000","submitted":"2023-10-29 21:50:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":36,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"370","meta_rev_id":"00bdf64720f4dd9d47597de1e5d129f4de5a36fe","_number":370,"virtual_id_number":370,"owner":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-17 17:05:54.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-10-17 17:05:54.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-10-17 17:05:54.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"9f0c4ad72864e888edc5ac710465343bbec85047","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-17 17:05:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1df1c41b6aaa6c199c9709cfdca746f795ecef0c","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-18 10:44:43.000000000","message":"Patch Set 1: Code-Review-1\n\n(12 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6c864e5bf597a11489904bb4c7d48b5487b52086","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-18 10:45:38.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0a2e235153f224a7edaec3f01160abb8b1a2fe88","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 12:14:53.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"faa8b1d4f4159c0bce8cc57d3ab481a96cef860a","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 12:18:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b04a9e27449e554d4d66415e5cc7d710cbc0a229","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 16:58:06.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a985b88ad3ebb9ed4a2cc0154b8398d790f851ba","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 17:02:51.000000000","message":"Patch Set 2:\n\n(11 comments)","accounts_in_message":[],"_revision_number":2},{"id":"87f88602cd851ee87b56fc01de1370ba64f25355","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 17:03:40.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"2378e86effa0fdbd5943c5a0fe5965cacb3d587d","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-18 17:16:45.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3b591ac8fee6e01f0524602f560c7435c37afeda","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-18 17:22:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"08634ddc270b95e22dcfa9e73971c54767f54e62","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-19 17:23:53.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"e59f5467ffb60df13e70cc097719bc3da6a12423","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-19 17:24:27.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"8b2bf558d8db8e914a2e3b668f47551c8adaa5a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-19 17:25:38.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"bf77cff5656ddd2fd96259b77a7d1ec49ff7666e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-19 17:28:06.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"7676efd3a3f93ac09f484400114f8c72c3cd360b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-20 15:01:24.000000000","message":"Patch Set 6:\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"7b2ec9c14464f32f4147abf6bcfcf8f9d537367d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-23 17:37:06.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b095249d6041925a83c9685bef333bd232440b8f","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2023-10-23 17:37:42.000000000","message":"Patch Set 7:\n\n(2 comments)","accounts_in_message":[],"_revision_number":7},{"id":"f9864b19b3a15345d696f485df8c5db0c55aab73","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-24 11:29:27.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"a2262164b71aaa840822b8b4737405744bb41577","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-25 12:18:44.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":7},{"id":"4bd8472dd60412980ad50f28c92193e568f19445","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-27 15:41:53.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"00bdf64720f4dd9d47597de1e5d129f4de5a36fe","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-29 21:50:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"ace7a4f1c271550bb8ad276663e045ab97a46f16","revisions":{"f2e1bec7076b9354b30ca53971501d08c280a3a8":{"kind":"REWORK","_number":1,"created":"2023-10-17 17:05:54.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/1 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8e5f8a4c4f8e01dc7317ac87a85d3204882d6bf","subject":"dco-win: get driver version"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-17 17:05:22.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nAlso bumping the minimum mbed TLS version to 2.16.12. That version is\nunsupported, but it\u0027s the latest long-term support release to still be\nreleased under the GPL.\n\nThis commit breaks compatibility for mbed TLS version 2.x.y. A\ncompatibility header will be added in a follow-up commit.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"27c243e5f202a8d523b8485c52747632bdb0139e":{"kind":"REWORK","_number":2,"created":"2023-10-18 16:58:06.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/2 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e8e5f8a4c4f8e01dc7317ac87a85d3204882d6bf","subject":"dco-win: get driver version"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-18 16:27:27.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nAlso bumping the minimum mbed TLS version to 2.16.0, since Ubuntu 20.04\nis still on version 2.16.4.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"6f6d018fe1aa59f11a7ae48f9a8012c6bfbc9e52":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-10-18 17:03:40.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/3 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e7427bcbb9b16b52d81c65b01d440a8ecd1e6ea7","subject":"Remove openssl engine method for loading the key"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-18 17:03:30.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nAlso bumping the minimum mbed TLS version to 2.16.0, since Ubuntu 20.04\nis still on version 2.16.4.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"285d0ef09ac90bf26a646a4a4112be5cf4fb2f41":{"kind":"REWORK","_number":4,"created":"2023-10-19 17:23:53.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/4 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"00685421aefcc294581d6e74371e744acdce6bbf","subject":"mss/mtu: make all size calculations use size_t"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-19 17:23:43.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nAlso bumping the minimum mbed TLS version to 2.16.0, since Ubuntu 20.04\nis still on version 2.16.4.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"82d8568695960fd463e6eecc26b988a165a97a0a":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2023-10-19 17:25:38.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/5 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"00685421aefcc294581d6e74371e744acdce6bbf","subject":"mss/mtu: make all size calculations use size_t"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-19 17:25:20.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"3d1846f3aedfc315c98eb92c1616aa52d8f4bc74":{"kind":"REWORK","_number":6,"created":"2023-10-19 17:28:06.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/6 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"00685421aefcc294581d6e74371e744acdce6bbf","subject":"mss/mtu: make all size calculations use size_t"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-19 17:28:01.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"92c707ea8193369d0f65241256f5b79228cead2a":{"kind":"REWORK","_number":7,"created":"2023-10-23 17:37:06.000000000","uploader":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"ref":"refs/changes/70/370/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/7 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c827f9d83a7246971f435d0053b0252e49770f11","subject":"dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to Patchwork"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-08 09:17:37.000000000","tz":120},"committer":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-23 17:26:14.000000000","tz":120},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\n"},"branch":"refs/heads/master"},"ace7a4f1c271550bb8ad276663e045ab97a46f16":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":8,"created":"2023-10-29 21:50:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/70/370/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/70/370/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/8 \u0026\u0026 git checkout -b change-370 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/70/370/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/70/370/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b088913e5854aba4e71f459844a1aa147d82b8a","subject":"Add --enable-werror to all platforms in Github Actions"}],"author":{"name":"Max Fillinger","email":"max@max-fillinger.net","date":"2023-10-25 12:18:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-10-29 19:11:17.000000000","tz":60},"subject":"Add support for mbedtls 3.X.Y","message":"Add support for mbedtls 3.X.Y\n\nMost struct fields in mbedtls 3 are private and now need accessor\nfunctions. Most of it was straightforward to adapt, but for two things\nthere were no accessor functions yet:\n\n * Netscape certificate type\n * key usage (you can check key usage, but not get the raw bytes)\n\nI decided to remove Netscape certificate type checks when using OpenVPN\nwith mbedtls. The key usage bytes were printed in an error message, and\nI removed that part from it.\n\nAdding the random number functions to the load private key function may\nlook weird, but the purpose is to make side channels for elliptic curve\noperations harder to exploit.\n\nChange-Id: I445a93e84dc54b865b757038d22318ac427fce96\nSigned-off-by: Max Fillinger \u003cmax@max-fillinger.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20231025121830.1030959-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27295.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}