)]}'
{"id":"openvpn~375","triplet_id":"openvpn~master~I204b396dea9f22d68e8e091d181a85ffebde4c17","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-10-22 11:03:23.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-10-20 14:34:41.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I204b396dea9f22d68e8e091d181a85ffebde4c17","subject":"Add undefined and abort on error to clang sanitize builds","status":"MERGED","created":"2023-10-18 17:21:39.000000000","updated":"2023-10-22 11:03:23.000000000","submitted":"2023-10-22 11:03:23.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"375","meta_rev_id":"4f2d6fb554b2b9d1a9840ffcaf71bad83eba7469","_number":375,"virtual_id_number":375,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-10-18 17:21:39.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-10-18 17:21:39.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"ddc095e519d562cdc53a7344cccb20d8e1faafc4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-10-18 17:21:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"814dd0b23e9c197cd72098c96cb12432657c5645","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-10-20 14:34:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4f2d6fb554b2b9d1a9840ffcaf71bad83eba7469","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-10-22 11:03:23.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"44d5cd038cb5b62dafc4aa784cfa2ccb7d670df7","revisions":{"1dc095d0b8caf752b449bfee0a7dd7201b7eb9d8":{"kind":"REWORK","_number":1,"created":"2023-10-18 17:21:39.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/75/375/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/375/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/1 \u0026\u0026 git checkout -b change-375 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/375/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"613f4a7c9fda4dd6f0063caefab6c03d4a628667","subject":"Change type of frame.mss_fix to uint16_t"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-01-18 11:32:20.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-10-18 17:21:33.000000000","tz":120},"subject":"Add undefined and abort on error to clang sanaitize builds","message":"Add undefined and abort on error to clang sanaitize builds\n\nThe -fno-sanitize-recover\u003dall flag ensures that for all errors we actually\nabort the tests in the automated testing and not just print some errors in red\nthat nobody sess. Also add the undefined tests to catch more bugs.\n\nFor libreSSL we do not add the udefined behaviour as we have (even with the\nlatest LibreSSL version) an undefined behaviour in LibreSSL itself.\n\nChange-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17\n"},"branch":"refs/heads/master"},"44d5cd038cb5b62dafc4aa784cfa2ccb7d670df7":{"kind":"REWORK","_number":2,"created":"2023-10-22 11:03:23.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/75/375/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/375/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/2 \u0026\u0026 git checkout -b change-375 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/75/375/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/75/375/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"df7beea404df48745a608c584d863c5a377b7a1e","subject":"dco: warn if DATA_V1 packets are sent to userspace"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-10-22 10:57:56.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-10-22 11:02:16.000000000","tz":120},"subject":"Add undefined and abort on error to clang sanitize builds","message":"Add undefined and abort on error to clang sanitize builds\n\nThe -fno-sanitize-recover\u003dall flag ensures that for all errors we actually\nabort the tests in the automated testing and not just print some errors in red\nthat nobody sees. Also add the undefined tests to catch more bugs.\n\nFor libreSSL we do not add the udefined behaviour as we have (even with the\nlatest LibreSSL version) an undefined behaviour in LibreSSL itself.\n\nChange-Id: I204b396dea9f22d68e8e091d181a85ffebde4c17\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20231022105756.21080-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27278.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}