)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8e429de3031bd20d90fa04b1d11bf4d5e413d374","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When installing mbed TLS 2.x and 3.x in parallel, it is useful to point"},{"line_number":10,"context_line":"cmake to the version that should be used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7fd9e730e87210d2b7d090c8f9c7c6734bd7374e"},{"line_number":13,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"aad177a5_630f5dc4","line":11,"updated":"2023-12-07 10:41:13.000000000","message":"Add a comment here that this also fixes existing issues with mbedTLS support in CMake build.","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ae003e4b96e91f7454fb176ed05b7d9a17ce4109","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When installing mbed TLS 2.x and 3.x in parallel, it is useful to point"},{"line_number":10,"context_line":"cmake to the version that should be used."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7fd9e730e87210d2b7d090c8f9c7c6734bd7374e"},{"line_number":13,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"6f04d272_ba7cbaef","line":11,"in_reply_to":"aad177a5_630f5dc4","updated":"2023-12-07 18:23:03.000000000","message":"Done","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0ffd50cb079e1ae1bc076e3d318071e8a197c171","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30048663_8bf9ee5c","updated":"2023-10-30 16:49:07.000000000","message":"Tested that this indeed fixes the build.","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"69e451d9d73db958c82c7d9a28f8369b84e801ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5cc1542d_6e0351c3","updated":"2023-10-28 14:56:15.000000000","message":"This already supports mbed TLS 3.5.0 with the extra function checks but is safe to apply before that as it also unbreaks mbed TLS 2.8.x","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"48f6552f03fee649de1f923d31d96fcc04c4d468","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"502a5e50_bbd1d602","updated":"2023-11-28 13:26:09.000000000","message":"Currently mbedTLS build with CMake is completely broken, so can\u0027t test. Need to rebase this on additional fixes, first.","commit_id":"d5ba9dc40679f2d66f0f09f4dcc82fd855cee9db"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8ece9c267dc1e328f5d0ed2e3bee67666ab098d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c62d791b_d5c1b5fe","updated":"2023-11-28 13:33:26.000000000","message":"Mark comments as done that apply to parts of the change that are not in the current version anymore.","commit_id":"d5ba9dc40679f2d66f0f09f4dcc82fd855cee9db"}],"CMakeLists.txt":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0ffd50cb079e1ae1bc076e3d318071e8a197c171","unresolved":true,"context_lines":[{"line_number":252,"context_line":"        if(NOT (MBED_LIBRARY_PATH STREQUAL \"\"))"},{"line_number":253,"context_line":"            target_link_directories(${target} PRIVATE ${MBED_LIBRARY_PATH})"},{"line_number":254,"context_line":"        endif ()"},{"line_number":255,"context_line":"        "},{"line_number":256,"context_line":"        target_link_libraries(${target} PRIVATE -lmbedtls -lmbedx509 -lmbedcrypto)"},{"line_number":257,"context_line":"    elseif (${WOLFSSL})"},{"line_number":258,"context_line":"        pkg_search_module(wolfssl wolfssl REQUIRED)"}],"source_content_type":"text/x-cmake","patch_set":1,"id":"8db2876b_008bceb0","line":255,"updated":"2023-10-30 16:49:07.000000000","message":"Trailing whitespace","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"04648b2b2dba8a35a460b4837dc48a7a6b741457","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        if(NOT (MBED_LIBRARY_PATH STREQUAL \"\"))"},{"line_number":253,"context_line":"            target_link_directories(${target} PRIVATE ${MBED_LIBRARY_PATH})"},{"line_number":254,"context_line":"        endif ()"},{"line_number":255,"context_line":"        "},{"line_number":256,"context_line":"        target_link_libraries(${target} PRIVATE -lmbedtls -lmbedx509 -lmbedcrypto)"},{"line_number":257,"context_line":"    elseif (${WOLFSSL})"},{"line_number":258,"context_line":"        pkg_search_module(wolfssl wolfssl REQUIRED)"}],"source_content_type":"text/x-cmake","patch_set":1,"id":"648426f1_aa309c74","line":255,"in_reply_to":"8db2876b_008bceb0","updated":"2023-11-29 12:20:28.000000000","message":"Done","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8e429de3031bd20d90fa04b1d11bf4d5e413d374","unresolved":true,"context_lines":[{"line_number":258,"context_line":"        if(NOT (MBED_LIBRARY_PATH STREQUAL \"\"))"},{"line_number":259,"context_line":"            target_link_directories(${target} PRIVATE ${MBED_LIBRARY_PATH})"},{"line_number":260,"context_line":"        endif ()"},{"line_number":261,"context_line":"        "},{"line_number":262,"context_line":"        target_link_libraries(${target} PRIVATE -lmbedtls -lmbedx509 -lmbedcrypto)"},{"line_number":263,"context_line":"    elseif (${WOLFSSL})"},{"line_number":264,"context_line":"        pkg_search_module(wolfssl wolfssl REQUIRED)"}],"source_content_type":"text/x-cmake","patch_set":5,"id":"99fc6c7c_42c8d650","line":261,"updated":"2023-12-07 10:41:13.000000000","message":"spurious whitespace","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ae003e4b96e91f7454fb176ed05b7d9a17ce4109","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        if(NOT (MBED_LIBRARY_PATH STREQUAL \"\"))"},{"line_number":259,"context_line":"            target_link_directories(${target} PRIVATE ${MBED_LIBRARY_PATH})"},{"line_number":260,"context_line":"        endif ()"},{"line_number":261,"context_line":"        "},{"line_number":262,"context_line":"        target_link_libraries(${target} PRIVATE -lmbedtls -lmbedx509 -lmbedcrypto)"},{"line_number":263,"context_line":"    elseif (${WOLFSSL})"},{"line_number":264,"context_line":"        pkg_search_module(wolfssl wolfssl REQUIRED)"}],"source_content_type":"text/x-cmake","patch_set":5,"id":"0e0af093_732576f5","line":261,"in_reply_to":"99fc6c7c_42c8d650","updated":"2023-12-07 18:23:03.000000000","message":"Done","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"}],"config.h.cmake.in":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"0ffd50cb079e1ae1bc076e3d318071e8a197c171","unresolved":true,"context_lines":[{"line_number":386,"context_line":"/* Define to 1 if you have the `vsnprintf\u0027 function. */"},{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine HAVE_CTR_DRBG_UPDATE_RET"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"/* Path to ifconfig tool */"}],"source_content_type":"text/x-properties","patch_set":1,"id":"11eae537_c69ab078","line":389,"updated":"2023-10-30 16:49:07.000000000","message":"Outdated comment?","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8ece9c267dc1e328f5d0ed2e3bee67666ab098d7","unresolved":false,"context_lines":[{"line_number":386,"context_line":"/* Define to 1 if you have the `vsnprintf\u0027 function. */"},{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine HAVE_CTR_DRBG_UPDATE_RET"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"/* Path to ifconfig tool */"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1e8800b8_c7e25722","line":389,"in_reply_to":"11eae537_c69ab078","updated":"2023-11-28 13:33:26.000000000","message":"Done","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"5ee8f0c4365c110b6d0a678c8a6cab54fa17d0f8","unresolved":true,"context_lines":[{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine HAVE_CTR_DRBG_UPDATE_RET"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"/* Path to ifconfig tool */"},{"line_number":393,"context_line":"#define IFCONFIG_PATH \"@IFCONFIG_PATH@\""}],"source_content_type":"text/x-properties","patch_set":1,"id":"fcaebfd4_9a7211d4","line":390,"updated":"2023-10-30 15:50:22.000000000","message":"In mbed TLS 3, the function mbedtls_ctr_drbg_update_ret does not exist, but mbedtls_ctr_drbg_update now has a return value.","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8ece9c267dc1e328f5d0ed2e3bee67666ab098d7","unresolved":false,"context_lines":[{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine HAVE_CTR_DRBG_UPDATE_RET"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"/* Path to ifconfig tool */"},{"line_number":393,"context_line":"#define IFCONFIG_PATH \"@IFCONFIG_PATH@\""}],"source_content_type":"text/x-properties","patch_set":1,"id":"e0fe93c2_c51086fe","line":390,"in_reply_to":"fcaebfd4_9a7211d4","updated":"2023-11-28 13:33:26.000000000","message":"Done","commit_id":"80946dffa6ce8803563b4a20539246c7b7d1e244"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8e429de3031bd20d90fa04b1d11bf4d5e413d374","unresolved":true,"context_lines":[{"line_number":386,"context_line":"/* Define to 1 if you have the `vsnprintf\u0027 function. */"},{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine01 HAVE_MBEDTLS_PSA_CRYPTO_H"},{"line_number":391,"context_line":"#define HAVE_MBEDTLS_SSL_TLS_PRF 1"},{"line_number":392,"context_line":"#cmakedefine01 HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB"}],"source_content_type":"text/x-properties","patch_set":5,"id":"341beb5a_169b2e4a","line":389,"updated":"2023-12-07 10:41:13.000000000","message":"obsolete comment","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ae003e4b96e91f7454fb176ed05b7d9a17ce4109","unresolved":false,"context_lines":[{"line_number":386,"context_line":"/* Define to 1 if you have the `vsnprintf\u0027 function. */"},{"line_number":387,"context_line":"#undef HAVE_VSNPRINTF"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"/* we always assume a recent mbed TLS version */"},{"line_number":390,"context_line":"#cmakedefine01 HAVE_MBEDTLS_PSA_CRYPTO_H"},{"line_number":391,"context_line":"#define HAVE_MBEDTLS_SSL_TLS_PRF 1"},{"line_number":392,"context_line":"#cmakedefine01 HAVE_MBEDTLS_SSL_SET_EXPORT_KEYS_CB"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ba7c404c_16e8f83c","line":389,"in_reply_to":"341beb5a_169b2e4a","updated":"2023-12-07 18:23:03.000000000","message":"Done","commit_id":"b6566d0959c3b27c0bb1b8057a982de38f0c1f37"}]}