)]}'
{"id":"openvpn~379","triplet_id":"openvpn~master~I0dcb2dac4136f194da7050a8ea8495e9faba9dd9","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"ntlm","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-11-20 10:53:04.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-12-30 16:31:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0dcb2dac4136f194da7050a8ea8495e9faba9dd9","subject":"Remove support for NTLM v1 proxy authentication","status":"MERGED","created":"2023-11-03 17:18:07.000000000","updated":"2023-12-30 16:31:29.000000000","submitted":"2023-12-30 16:31:29.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"379-ntlm","meta_rev_id":"e1b5798164d29a0333658267388b1835e157015e","_number":379,"virtual_id_number":379,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-03 17:18:08.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-03 17:18:08.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"39a0094e66979d93bcfcf24285be91d97577f0bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-03 17:18:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8a1e4a043ec23885ff9698aa7cc6d8bb906f1b48","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-06 13:01:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8efd0d1b96059e205df7481d7e983d178ead628c","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 10:53:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9bb6691507e7420e7d4901d185f59521b3415b9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-04 11:26:07.000000000","message":"Patch Set 3: Patch Set 2 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"db4f07d40022b0f8ec7ec0f883a4c09bbfb8449f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-05 11:05:43.000000000","message":"Patch Set 4: Patch Set 3 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"e1b5798164d29a0333658267388b1835e157015e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-12-30 16:31:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"21910ebc2ee8a6138eb2af8d38056d2b94e59f9c","revisions":{"f2b6d619acb806bc8c889c133b4bf504b4896ff5":{"kind":"REWORK","_number":1,"created":"2023-11-03 17:18:07.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/79/379/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/379/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/1 \u0026\u0026 git checkout -b change-379 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/379/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7caa75928b38efbcc95d072fb367a22c8c55b903","subject":"configure: allow to disable NTLM"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-03 17:02:55.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-03 17:17:39.000000000","tz":60},"subject":"Remove support for NTLM v1 proxy authentication","message":"Remove support for NTLM v1 proxy authentication\n\nDue to the limitation of the protocol it is not\nconsidered secure. Better to use basic auth instead\nof a false sense of security. NTLM v2 remains\nsupported for now.\n\nChange-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"61c7cda35f9b23bafe1ec4c09202b2e660d30c23":{"kind":"REWORK","_number":2,"created":"2023-11-06 13:01:57.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/79/379/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/379/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/2 \u0026\u0026 git checkout -b change-379 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/379/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7caa75928b38efbcc95d072fb367a22c8c55b903","subject":"configure: allow to disable NTLM"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-03 17:02:55.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-06 13:01:17.000000000","tz":60},"subject":"Remove support for NTLM v1 proxy authentication","message":"Remove support for NTLM v1 proxy authentication\n\nDue to the limitation of the protocol it is not\nconsidered secure. Better to use basic auth instead\nof a false sense of security. NTLM v2 remains\nsupported for now.\n\nChange-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"bfd2c5628d0f8f36e638b618c2f8b9dd0c1bb46e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-12-04 11:26:07.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/79/379/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/379/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/3 \u0026\u0026 git checkout -b change-379 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/379/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3381f1846371b7ed10cdd2c42b1448471fe01950","subject":"configure: allow to disable NTLM"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-03 17:02:55.000000000","tz":60},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2023-12-04 11:26:07.000000000","tz":0},"subject":"Remove support for NTLM v1 proxy authentication","message":"Remove support for NTLM v1 proxy authentication\n\nDue to the limitation of the protocol it is not\nconsidered secure. Better to use basic auth instead\nof a false sense of security. NTLM v2 remains\nsupported for now.\n\nChange-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"a5584904961a12b0e5b59e36b28b807a7e3d9d1a":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-12-05 11:05:43.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/79/379/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/379/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/4 \u0026\u0026 git checkout -b change-379 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/379/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e1fb9cd9ee546271d3a45bd7610fcf0d7e772b05","subject":"configure: allow to disable NTLM"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-03 17:02:55.000000000","tz":60},"committer":{"name":"flichtenheld","email":"frank@lichtenheld.com","date":"2023-12-05 11:05:43.000000000","tz":0},"subject":"Remove support for NTLM v1 proxy authentication","message":"Remove support for NTLM v1 proxy authentication\n\nDue to the limitation of the protocol it is not\nconsidered secure. Better to use basic auth instead\nof a false sense of security. NTLM v2 remains\nsupported for now.\n\nChange-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"21910ebc2ee8a6138eb2af8d38056d2b94e59f9c":{"kind":"REWORK","_number":5,"created":"2023-12-30 16:31:29.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/79/379/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/79/379/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/5 \u0026\u0026 git checkout -b change-379 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/79/379/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/79/379/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"30751632b5d919d6a01a625be48060ee23b4f968","subject":"misc: make get_auth_challenge static"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-12-30 14:37:33.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-12-30 16:06:14.000000000","tz":60},"subject":"Remove support for NTLM v1 proxy authentication","message":"Remove support for NTLM v1 proxy authentication\n\nDue to the limitation of the protocol it is not\nconsidered secure. Better to use basic auth instead\nof a false sense of security. NTLM v2 remains\nsupported for now.\n\nChange-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20231230143733.4426-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27862.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}