)]}'
{"id":"openvpn~421","triplet_id":"openvpn~master~Iede3e7c028cbb715e28bc88c7e583f84dadc02c8","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"topology-subnet","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-11-29 12:18:35.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-04-03 17:27:28.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"Iede3e7c028cbb715e28bc88c7e583f84dadc02c8","subject":"Change default of \"topology\" to \"subnet\"","status":"MERGED","created":"2023-11-06 17:32:47.000000000","updated":"2024-04-03 17:27:28.000000000","submitted":"2024-04-03 17:27:28.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"421-topology-subnet","meta_rev_id":"02044454f6fad51f60b481cf061f3ca8f9676c37","_number":421,"virtual_id_number":421,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-06 17:32:47.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-06 17:32:47.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"934ef9cebba15f9aee3eadc35b81d2b1cc304b93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-06 17:32:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66fd1e3332d0d0cc112360043411914bc13b1b2e","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-28 13:41:37.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82c55b30af9dee1e4aa8aaab11bcffca6e78ea52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-28 17:08:00.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6d2978e6dc69bd234615944a46988494b790850f","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-29 12:18:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d441dbd9a0c76ad92d9bcbbfce37cce0ca176b75","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-01 11:20:33.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"02044454f6fad51f60b481cf061f3ca8f9676c37","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-04-03 17:27:28.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"32e6586687a548174b88b64fe54bfae6c74d4c19","revisions":{"0add0b58ee6b28d5bf743759d3e1d513793e4482":{"kind":"REWORK","_number":1,"created":"2023-11-06 17:32:47.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/21/421/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/421/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/1 \u0026\u0026 git checkout -b change-421 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/421/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c8b27859d488fdcb0a887175f075b4a2875f81e9","subject":"tun: use is_tun_p2p more consistently"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-06 17:29:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-06 17:32:26.000000000","tz":60},"subject":"Change default of \"topology\" to \"subnet\"","message":"Change default of \"topology\" to \"subnet\"\n\nChange-Id: Iede3e7c028cbb715e28bc88c7e583f84dadc02c8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6bcc519c2184a4231c13faf481638c4cdd24e610":{"kind":"REWORK","_number":2,"created":"2023-11-28 17:08:00.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/21/421/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/421/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/2 \u0026\u0026 git checkout -b change-421 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/421/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c8b27859d488fdcb0a887175f075b4a2875f81e9","subject":"tun: use is_tun_p2p more consistently"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-06 17:29:16.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-11-28 17:04:27.000000000","tz":60},"subject":"Change default of \"topology\" to \"subnet\"","message":"Change default of \"topology\" to \"subnet\"\n\nChange-Id: Iede3e7c028cbb715e28bc88c7e583f84dadc02c8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"32e6586687a548174b88b64fe54bfae6c74d4c19":{"kind":"REWORK","_number":3,"created":"2024-04-03 17:27:28.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/21/421/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/421/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/3 \u0026\u0026 git checkout -b change-421 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/421/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/421/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e2ff9161e1b1b3e8c83bf01e3c488e0601834c0c","subject":"forked-test-driver: Show test output always"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2023-12-01 11:20:22.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-04-03 15:28:46.000000000","tz":120},"subject":"Change default of \"topology\" to \"subnet\"","message":"Change default of \"topology\" to \"subnet\"\n\nChange-Id: Iede3e7c028cbb715e28bc88c7e583f84dadc02c8\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20231201112022.15337-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27627.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}