)]}'
{"id":"openvpn~427","triplet_id":"openvpn~master~I24f43ad319bd1ca530fe17442d02a97412eb75c7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-11-15 14:45:30.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-11-13 20:02:21.000000000","reason":"removed on reply"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-11-15 14:45:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I24f43ad319bd1ca530fe17442d02a97412eb75c7","subject":"Make --dns options apply for tap-windows6 driver","status":"MERGED","created":"2023-11-13 16:01:29.000000000","updated":"2023-11-15 14:45:30.000000000","submitted":"2023-11-15 14:45:30.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"426","meta_rev_id":"627afdb781df4b1009cb63332b0d297ddcbc3e81","_number":427,"virtual_id_number":427,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-13 16:01:29.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-13 16:01:29.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-11-13 16:01:29.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"e425cdd2ea8b44423893d4470e26a90cbeec89ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-11-13 16:01:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d27bcd3851d4614e0d37ffa60ea038b029551626","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-13 20:02:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"627afdb781df4b1009cb63332b0d297ddcbc3e81","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-11-15 14:45:30.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"60def50420b050e628f4388e3c9ff771eb70a549","revisions":{"c24037309c43f4a611f6e095fd1eda8ee70f668e":{"kind":"REWORK","_number":1,"created":"2023-11-13 16:01:29.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/27/427/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/427/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/1 \u0026\u0026 git checkout -b change-427 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/427/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20c42b89f6d38a4426b5fe67f59acaadcb9ac314","subject":"doc: Correct typos in multiple documentation files"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-10 10:02:10.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-13 16:00:48.000000000","tz":120},"subject":"Make --dns options apply for tap-windows6 driver","message":"Make --dns options apply for tap-windows6 driver\n\nWhen tap-windows6 driver is used, both --dhcp-option and\n--dns options are applied with DHCP. When processing --dns options,\nwe don\u0027t set \"tuntap_options.dhcp_options\" member, which is required\nfor DHCP string to be sent to the driver. As a result, --dns options\nare not applied at all.\n\nFix by adding missing assignment of tuntap_options.dhcp_options.\n\nFixes https://github.com/OpenVPN/openvpn/issues/447\n\nChange-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"60def50420b050e628f4388e3c9ff771eb70a549":{"kind":"REWORK","_number":2,"created":"2023-11-15 14:45:30.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/27/427/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/27/427/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/2 \u0026\u0026 git checkout -b change-427 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/27/427/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/27/427/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a903ebe9361d451daee71c225e141f4e1b67107d","subject":"Do not check key_state buffers that are in S_UNDEF state"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-15 12:06:23.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-11-15 14:35:55.000000000","tz":60},"subject":"Make --dns options apply for tap-windows6 driver","message":"Make --dns options apply for tap-windows6 driver\n\nWhen tap-windows6 driver is used, both --dhcp-option and\n--dns options are applied with DHCP. When processing --dns options,\nwe don\u0027t set \"tuntap_options.dhcp_options\" member, which is required\nfor DHCP string to be sent to the driver. As a result, --dns options\nare not applied at all.\n\nFix by adding missing assignment of tuntap_options.dhcp_options.\n\nGithub: fixes OpenVPN/openvpn#447\n\nChange-Id: I24f43ad319bd1ca530fe17442d02a97412eb75c7\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20231115120623.6442-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27402.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}