)]}'
{"id":"openvpn~429","triplet_id":"openvpn~master~I53eaee85d7b284af6bc63da5f6d8f310ddd96c47","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-11-14 15:08:18.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-11-14 15:08:18.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2023-11-14 15:08:18.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I53eaee85d7b284af6bc63da5f6d8f310ddd96c47","subject":"config.h: fix incorrect defines for _wopen()","status":"MERGED","created":"2023-11-14 12:18:42.000000000","updated":"2023-11-14 15:08:18.000000000","submitted":"2023-11-14 15:08:18.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"429","meta_rev_id":"3930ee742096050390e72e437470c723f2c66cb3","_number":429,"virtual_id_number":429,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-14 12:18:43.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-14 12:18:43.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-11-14 12:18:43.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2023-11-14 14:13:38.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"c8f9c7e4c1efd2d11c8f0cf349961dfbecd24766","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2023-11-14 12:18:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8043e801a9297a3808a8d0f345b7a314177d565","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-11-14 14:13:38.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3930ee742096050390e72e437470c723f2c66cb3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-11-14 15:08:18.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2fcfb77a8111cce9308bb893f52ecdb77de91e7c","revisions":{"fafb21c987532b5e1212703217b8dd03a1462b43":{"kind":"REWORK","_number":1,"created":"2023-11-14 12:18:42.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/29/429/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/429/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/1 \u0026\u0026 git checkout -b change-429 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/429/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20c42b89f6d38a4426b5fe67f59acaadcb9ac314","subject":"doc: Correct typos in multiple documentation files"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-14 12:10:21.000000000","tz":120},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-14 12:10:21.000000000","tz":120},"subject":"config.h: fix incorrect defines for _wopen()","message":"config.h: fix incorrect defines for _wopen()\n\nThis is a regression from commit\n\n  01341840 (\"add basic CMake based build\")\n\nS_IRUSR and S_IWUSR should NOT be defined as 0 but\nas _S_IREAD and _S_IWRITE, as it was already fixed in commit\n\n  077445d0 (\"Fix some more wrong defines in config-msvc.h\")\n\nThose are used as permission mode when opening a file. Passing\nzero makes file read-only, which break for example --status-file\nfunctionality.\n\nFixes https://github.com/OpenVPN/openvpn/issues/454\n\nChange-Id: I53eaee85d7b284af6bc63da5f6d8f310ddd96c47\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"2fcfb77a8111cce9308bb893f52ecdb77de91e7c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-11-14 15:08:18.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/29/429/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/29/429/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/2 \u0026\u0026 git checkout -b change-429 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/29/429/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/29/429/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"20c42b89f6d38a4426b5fe67f59acaadcb9ac314","subject":"doc: Correct typos in multiple documentation files"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2023-11-14 14:16:53.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-11-14 14:20:01.000000000","tz":60},"subject":"config.h: fix incorrect defines for _wopen()","message":"config.h: fix incorrect defines for _wopen()\n\nThis is a regression from commit\n\n  01341840 (\"add basic CMake based build\")\n\nS_IRUSR and S_IWUSR should NOT be defined as 0 but\nas _S_IREAD and _S_IWRITE, as it was already fixed in commit\n\n  077445d0 (\"Fix some more wrong defines in config-msvc.h\")\n\nThose are used as permission mode when opening a file. Passing\nzero makes file read-only, which break for example --status-file\nfunctionality.\n\nGithub: fixes OpenVPN/openvpn#454\nTrac: #1430\n\nChange-Id: I53eaee85d7b284af6bc63da5f6d8f310ddd96c47\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20231114141653.10486-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27393.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}