)]}'
{"id":"openvpn~440","triplet_id":"openvpn~master~I81ec69d12abc9a661875c93c7f1bd97e525df55f","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-11-15 13:48:09.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-11-15 13:48:09.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I81ec69d12abc9a661875c93c7f1bd97e525df55f","subject":"Using the same wait function for both TCP and UDP","status":"ABANDONED","created":"2023-11-15 13:44:47.000000000","updated":"2024-09-24 20:42:13.000000000","total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":true,"meta_rev_id":"f5eac737025fb989b8884de0eb47e6e59ef0d8ba","_number":440,"virtual_id_number":440,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-15 13:44:51.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-15 13:44:51.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2023-11-15 13:44:51.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"c25405bb02c99380bbab51e1a46bd624c11e200f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2023-11-15 13:44:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28ccb6f6fdaf3d06cb32d2f6ee94f9f620582db4","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2023-11-15 13:48:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"487568570bc196e0020dbab6cd9e4c7998cea965","tag":"autogenerated:gerrit:restore","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2023-11-15 14:31:01.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"8ca2c903d34c313d010fe2388c08933d4b660e5e","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2023-11-15 14:31:05.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"f5eac737025fb989b8884de0eb47e6e59ef0d8ba","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2024-09-24 20:42:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"31df3e484be25bed43e2f133aad9f39d375565b9","revisions":{"31df3e484be25bed43e2f133aad9f39d375565b9":{"kind":"REWORK","_number":1,"created":"2023-11-15 13:44:47.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/40/440/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/40/440/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/440/1 \u0026\u0026 git checkout -b change-440 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/440/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/440/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/440/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/40/440/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/40/440/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"659fb4cdc3c477681ecc82d9a211c3ac627c202f","subject":"mroute: properly print protocol at the end of the string"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2023-09-15 15:36:22.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2023-11-15 13:44:48.000000000","tz":60},"subject":"Using the same wait function for both TCP and UDP","message":"Using the same wait function for both TCP and UDP\n\nFORWARD: added a new function to collect UDP flags.\n\nMTCP: the mtcp structure has been modified to carry around those flags.\n      The second wait function (in UDP case) has been removed.\n\nMULTI: properly remove TCP instances by checking the multi_instance\n       protocol instead of the global one.\n\nTLS: set the tls_option xmit_hold bool value to true only in case of\n     TCP child instance to avoid checking the global protocol\n     value.\n\nINIT: initialize the c-\u003ec2.event_set in the inherit_context_top()\n      by default and not only in case of UDP since we could have\n      multiple different sockets.\n\nChange-Id: I81ec69d12abc9a661875c93c7f1bd97e525df55f\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}