)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ef92d4d19d18aa7a9fce8f84e20ff08357ab687","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove compat versionhelpers.h and remove cmake/configure check for it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cmake file defined that file to be never present in contrast to the"},{"line_number":10,"context_line":"old msvc-config.h that always had it present. Also interactive.c includes"},{"line_number":11,"context_line":"versionhelpers.h without the check, so we always assume it to be present"},{"line_number":12,"context_line":"anyway. Remove also the comapt implementation taken from mingw"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ac1dbdba_a1bab3b8","line":10,"updated":"2023-11-20 11:27:24.000000000","message":"interactive.c does not include it without the check?","commit_id":"0b57cf049a3c4840d7104a95007bd393c08ae177"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"796c133d4665854fdae313066a652d8373db5bc2","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove compat versionhelpers.h and remove cmake/configure check for it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cmake file defined that file to be never present in contrast to the"},{"line_number":10,"context_line":"old msvc-config.h that always had it present. Also interactive.c includes"},{"line_number":11,"context_line":"versionhelpers.h without the check, so we always assume it to be present"},{"line_number":12,"context_line":"anyway. Remove also the comapt implementation taken from mingw"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b2ce1fb4_43a25ec3","line":10,"in_reply_to":"ac1dbdba_a1bab3b8","updated":"2023-11-20 11:49:42.000000000","message":"Yeah. interactive.c is just\n\n#include \u003cmstcpip.h\u003e\n\n#include \u003cversionhelpers.h\u003e\n\n#include \"openvpn-msg.h\"","commit_id":"0b57cf049a3c4840d7104a95007bd393c08ae177"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"f098c9fc92d0b48a2b596157ba27a3bad7082cd9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove compat versionhelpers.h and remove cmake/configure check for it"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cmake file defined that file to be never present in contrast to the"},{"line_number":10,"context_line":"old msvc-config.h that always had it present. Also interactive.c includes"},{"line_number":11,"context_line":"versionhelpers.h without the check, so we always assume it to be present"},{"line_number":12,"context_line":"anyway. Remove also the comapt implementation taken from mingw"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ad40222e_e26eea37","line":10,"in_reply_to":"b2ce1fb4_43a25ec3","updated":"2023-11-20 11:50:33.000000000","message":"argh. SOrry. I messed that up thinking that I have not modified that that was not part of the patch. sorry. Will rewrite the commit message.","commit_id":"0b57cf049a3c4840d7104a95007bd393c08ae177"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ae7602b3247e685e8e46d31c4b863cbbdd50e12","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The cmake file defined that file to be never present in contrast to the"},{"line_number":10,"context_line":"old msvc-config.h that always had it present."},{"line_number":11,"context_line":"Remove also the comapt implementation taken from mingw. All our current"},{"line_number":12,"context_line":"build environment already have that header in place."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6d2ffebd_108c2911","line":11,"updated":"2023-11-20 12:06:34.000000000","message":"\"compat\"","commit_id":"d589ba4d5a2acf1df56015d220cafedb5e5677a8"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ae7602b3247e685e8e46d31c4b863cbbdd50e12","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The cmake file defined that file to be never present in contrast to the"},{"line_number":10,"context_line":"old msvc-config.h that always had it present."},{"line_number":11,"context_line":"Remove also the comapt implementation taken from mingw. All our current"},{"line_number":12,"context_line":"build environment already have that header in place."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"96f8a775_b2f3fbf2","line":12,"updated":"2023-11-20 12:06:34.000000000","message":"\"environments\"","commit_id":"d589ba4d5a2acf1df56015d220cafedb5e5677a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ef92d4d19d18aa7a9fce8f84e20ff08357ab687","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"096638f5_065ce394","updated":"2023-11-20 11:27:24.000000000","message":"Code looks good, but commit message seems wrong?","commit_id":"0b57cf049a3c4840d7104a95007bd393c08ae177"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ae7602b3247e685e8e46d31c4b863cbbdd50e12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f43d808b_48e1e736","updated":"2023-11-20 12:06:34.000000000","message":"Two little typos in the commit message. But code looks good.","commit_id":"d589ba4d5a2acf1df56015d220cafedb5e5677a8"}]}