)]}'
{"id":"openvpn~445","triplet_id":"openvpn~master~I9c85ccab6d51064ebff2c391740ba8c2d044ed1a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-12-02 16:40:59.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-11-20 12:06:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I9c85ccab6d51064ebff2c391740ba8c2d044ed1a","subject":"Remove compat versionhelpers.h and remove cmake/configure check for it","status":"MERGED","created":"2023-11-20 10:51:19.000000000","updated":"2023-12-02 16:40:59.000000000","submitted":"2023-12-02 16:40:59.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":7,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"445","meta_rev_id":"1fe3f08c92b029839898e153d8637691b63eda72","_number":445,"virtual_id_number":445,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-20 10:51:19.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-20 10:51:19.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"689d5fb1df98c69aa63ce9e6ccc6a8e5bb210161","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 10:51:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ef92d4d19d18aa7a9fce8f84e20ff08357ab687","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-20 11:27:24.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"796c133d4665854fdae313066a652d8373db5bc2","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 11:49:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f098c9fc92d0b48a2b596157ba27a3bad7082cd9","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 11:50:33.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"933422056e46fa9ae986b98f0f073ca9717cecc1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 11:51:31.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5ae7602b3247e685e8e46d31c4b863cbbdd50e12","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-20 12:06:34.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7373fcaeb0d5299e7964835fcb1e745956877805","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-28 10:40:00.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"1fe3f08c92b029839898e153d8637691b63eda72","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-12-02 16:40:59.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a68595a582b2c6c220b4f4502753d5f4154000d8","revisions":{"0b57cf049a3c4840d7104a95007bd393c08ae177":{"kind":"REWORK","_number":1,"created":"2023-11-20 10:51:19.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/45/445/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/445/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/1 \u0026\u0026 git checkout -b change-445 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/445/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5faf1b2e90fd44c5137a2b8f3da98c7ae482fc1","subject":"Enable key export with mbed TLS 3.x.y"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-18 13:28:46.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-20 10:51:11.000000000","tz":120},"subject":"Remove compat versionhelpers.h and remove cmake/configure check for it","message":"Remove compat versionhelpers.h and remove cmake/configure check for it\n\nThe cmake file defined that file to be never present in contrast to the\nold msvc-config.h that always had it present. Also interactive.c includes\nversionhelpers.h without the check, so we always assume it to be present\nanyway. Remove also the comapt implementation taken from mingw\n\nChange-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a\n"},"branch":"refs/heads/master"},"d589ba4d5a2acf1df56015d220cafedb5e5677a8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-11-20 11:51:31.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/45/445/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/445/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/2 \u0026\u0026 git checkout -b change-445 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/445/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b5faf1b2e90fd44c5137a2b8f3da98c7ae482fc1","subject":"Enable key export with mbed TLS 3.x.y"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-18 13:28:46.000000000","tz":120},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-20 11:50:58.000000000","tz":120},"subject":"Remove compat versionhelpers.h and remove cmake/configure check for it","message":"Remove compat versionhelpers.h and remove cmake/configure check for it\n\nThe cmake file defined that file to be never present in contrast to the\nold msvc-config.h that always had it present.\nRemove also the comapt implementation taken from mingw. All our current\nbuild environment already have that header in place.\n\nChange-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a\n"},"branch":"refs/heads/master"},"a68595a582b2c6c220b4f4502753d5f4154000d8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2023-12-02 16:40:59.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/445/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/445/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/3 \u0026\u0026 git checkout -b change-445 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/445/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/445/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"efbedf213f659c48cfd55765360fdab7a6488dad","subject":"Minimal Solaris/OpenIndiana support to Cmake and clean up -Werror"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-28 10:39:50.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-12-02 16:29:25.000000000","tz":60},"subject":"Remove compat versionhelpers.h and remove cmake/configure check for it","message":"Remove compat versionhelpers.h and remove cmake/configure check for it\n\nThe cmake file defined that file to be never present in contrast to the\nold msvc-config.h that always had it present.\nRemove also the compat implementation taken from mingw. All our current\nbuild environments already have that header in place.\n\nChange-Id: I9c85ccab6d51064ebff2c391740ba8c2d044ed1a\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nMessage-Id: \u003c20231128103950.62407-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27573.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}