)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"217c86daa317847ffd4b5b274a55daea3e420f76","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Arne Schwabe \u003carne@rfc2549.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-11 16:53:26 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove dead list test code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7511bc43cd6a0bcb89476f27d5822ab4a78d0d21"},{"line_number":10,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"83ad6747_f9b562f8","line":7,"updated":"2023-12-11 18:01:39.000000000","message":"commit message needs update for the new version of the patch","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5c212c19f36650ed1935305c4b65f28efcec2b84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Arne Schwabe \u003carne@rfc2549.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-11 16:53:26 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove dead list test code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7511bc43cd6a0bcb89476f27d5822ab4a78d0d21"},{"line_number":10,"context_line":"Signed-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4169cbdc_e4c58b8c","line":7,"in_reply_to":"83ad6747_f9b562f8","updated":"2024-02-02 12:36:13.000000000","message":"Done","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4dd6bae3e709ac36f0439c7325cceae419aed36b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a7a7fbc_3db8a431","updated":"2023-11-22 17:45:47.000000000","message":"As discussed in IRC, need to decide whether the code should be moved to UT.","commit_id":"83fcdcee4454b7fc200f396d4572ff644953e103"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"217c86daa317847ffd4b5b274a55daea3e420f76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a515f8a4_13c76e15","updated":"2023-12-11 18:01:39.000000000","message":"New list test is not enabled for mingw in GHA build.yaml. It would be difficult to enable due to the -DSOURCEDIR solution. Need to discuss how to handle that first, before going ahead.","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4ad74eb95967c0b17f976929283335bbed6fa7da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"331723f1_d635a1d4","updated":"2024-02-02 11:18:30.000000000","message":"Still open comments and questions","commit_id":"58591bcf16b9a399c94864049c3a684edbafd361"}],"CMakeLists.txt":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4ad74eb95967c0b17f976929283335bbed6fa7da","unresolved":true,"context_lines":[{"line_number":750,"context_line":"        src/openvpn/list.c"},{"line_number":751,"context_line":"        )"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    target_compile_definitions(test_misc PRIVATE \"-DSOURCEDIR\u003d\\\"${CMAKE_SOURCE_DIR}\\\"\")"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    target_sources(test_ncp PRIVATE"},{"line_number":756,"context_line":"        src/openvpn/crypto_mbedtls.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"65c92932_e39b460b","line":753,"updated":"2024-02-02 11:18:30.000000000","message":"Shouldn\u0027t be required anymore due to #509","commit_id":"58591bcf16b9a399c94864049c3a684edbafd361"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5c212c19f36650ed1935305c4b65f28efcec2b84","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        src/openvpn/list.c"},{"line_number":751,"context_line":"        )"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"    target_compile_definitions(test_misc PRIVATE \"-DSOURCEDIR\u003d\\\"${CMAKE_SOURCE_DIR}\\\"\")"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"    target_sources(test_ncp PRIVATE"},{"line_number":756,"context_line":"        src/openvpn/crypto_mbedtls.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"afbc220f_9d790a94","line":753,"in_reply_to":"65c92932_e39b460b","updated":"2024-02-02 12:36:13.000000000","message":"Done","commit_id":"58591bcf16b9a399c94864049c3a684edbafd361"}],"tests/unit_tests/openvpn/test_misc.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"11d0c70f0658b51a79d9a647109e6e243fd082e9","unresolved":true,"context_lines":[{"line_number":200,"context_line":"                        ALLOC_OBJ_GC(w, struct word, \u0026gc);"},{"line_number":201,"context_line":"                        w-\u003eword \u003d string_alloc(wordbuf, \u0026gc);"},{"line_number":202,"context_line":"                        w-\u003en \u003d 1;"},{"line_number":203,"context_line":"                        ASSERT(hash_add(hash, w-\u003eword, w, false));"},{"line_number":204,"context_line":"                        ASSERT(hash_add(nhash, w-\u003eword, (void *) ((ptr_type )(random() \u0026 0x0F) + 1), false));"},{"line_number":205,"context_line":"                    }"},{"line_number":206,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"06c0770f_7c7fbf6a","line":203,"updated":"2023-12-11 16:25:12.000000000","message":"Should probably use the cmocka assert_true here?","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"682960e273c54f8b1026567b5f594b9ed64a9f09","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                        ALLOC_OBJ_GC(w, struct word, \u0026gc);"},{"line_number":201,"context_line":"                        w-\u003eword \u003d string_alloc(wordbuf, \u0026gc);"},{"line_number":202,"context_line":"                        w-\u003en \u003d 1;"},{"line_number":203,"context_line":"                        ASSERT(hash_add(hash, w-\u003eword, w, false));"},{"line_number":204,"context_line":"                        ASSERT(hash_add(nhash, w-\u003eword, (void *) ((ptr_type )(random() \u0026 0x0F) + 1), false));"},{"line_number":205,"context_line":"                    }"},{"line_number":206,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"7dac6168_d24ef656","line":203,"in_reply_to":"06c0770f_7c7fbf6a","updated":"2024-02-05 13:43:11.000000000","message":"Done","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"11d0c70f0658b51a79d9a647109e6e243fd082e9","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            hash_iterator_free(\u0026hi);"},{"line_number":260,"context_line":"        }"},{"line_number":261,"context_line":"        ASSERT(count \u003d\u003d hash_n_elements(hash));"},{"line_number":262,"context_line":"    }"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    /* test hash_remove_by_value function */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"57543554_99e77fac","line":261,"updated":"2023-12-11 16:25:12.000000000","message":"should use assert_int_equal","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"682960e273c54f8b1026567b5f594b9ed64a9f09","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            hash_iterator_free(\u0026hi);"},{"line_number":260,"context_line":"        }"},{"line_number":261,"context_line":"        ASSERT(count \u003d\u003d hash_n_elements(hash));"},{"line_number":262,"context_line":"    }"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    /* test hash_remove_by_value function */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"e8916ca3_ce20ce1e","line":261,"in_reply_to":"57543554_99e77fac","updated":"2024-02-05 13:43:11.000000000","message":"Done","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"11d0c70f0658b51a79d9a647109e6e243fd082e9","unresolved":true,"context_lines":[{"line_number":265,"context_line":"    {"},{"line_number":266,"context_line":"        for (ptr_type i \u003d 1; i \u003c\u003d 16; ++i)"},{"line_number":267,"context_line":"        {"},{"line_number":268,"context_line":"            hash_remove_by_value(nhash, (void *) i);"},{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":"    }"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0a20d288_80ec1771","line":268,"updated":"2023-12-11 16:25:12.000000000","message":"can we test that this was successful?","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"682960e273c54f8b1026567b5f594b9ed64a9f09","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    {"},{"line_number":266,"context_line":"        for (ptr_type i \u003d 1; i \u003c\u003d 16; ++i)"},{"line_number":267,"context_line":"        {"},{"line_number":268,"context_line":"            hash_remove_by_value(nhash, (void *) i);"},{"line_number":269,"context_line":"        }"},{"line_number":270,"context_line":"    }"},{"line_number":271,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1c366976_7d353c43","line":268,"in_reply_to":"0a20d288_80ec1771","updated":"2024-02-05 13:43:11.000000000","message":"Done","commit_id":"3cb29fb002b9038922e2264b6aa8db6e58005d92"}]}