)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5cfe5e6bc88158d9d47c8f9011e96411a04ab365","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3ca6d50_9546559b","updated":"2023-11-20 13:12:13.000000000","message":"Good change, but should recurse","commit_id":"0867c42f4975e317e7f33e7931c3a0ae0da1e675"}],"src/openvpn/ssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5cfe5e6bc88158d9d47c8f9011e96411a04ab365","unresolved":true,"context_lines":[{"line_number":2933,"context_line":"        }"},{"line_number":2934,"context_line":"        else"},{"line_number":2935,"context_line":"        {"},{"line_number":2936,"context_line":"            if (!read_incoming_tls_ciphertext(\u0026entry-\u003ebuf, ks, \u0026continue_tls_process))"},{"line_number":2937,"context_line":"            {"},{"line_number":2938,"context_line":"                goto error;"},{"line_number":2939,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"bdfcf50c_c5c3ee11","line":2936,"updated":"2023-11-20 13:12:13.000000000","message":"Should rename argument of read_incoming_tls_ciphertext as well","commit_id":"0867c42f4975e317e7f33e7931c3a0ae0da1e675"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a0752893f19126891c6d7866f4c5e240bcf4d970","unresolved":false,"context_lines":[{"line_number":2933,"context_line":"        }"},{"line_number":2934,"context_line":"        else"},{"line_number":2935,"context_line":"        {"},{"line_number":2936,"context_line":"            if (!read_incoming_tls_ciphertext(\u0026entry-\u003ebuf, ks, \u0026continue_tls_process))"},{"line_number":2937,"context_line":"            {"},{"line_number":2938,"context_line":"                goto error;"},{"line_number":2939,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4493eb6f_5624d2ca","line":2936,"in_reply_to":"bdfcf50c_c5c3ee11","updated":"2023-11-20 17:15:44.000000000","message":"Done","commit_id":"0867c42f4975e317e7f33e7931c3a0ae0da1e675"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5cfe5e6bc88158d9d47c8f9011e96411a04ab365","unresolved":true,"context_lines":[{"line_number":2944,"context_line":"    struct buffer *buf \u003d \u0026ks-\u003eplaintext_read_buf;"},{"line_number":2945,"context_line":"    if (!buf-\u003elen)"},{"line_number":2946,"context_line":"    {"},{"line_number":2947,"context_line":"        if (!read_incoming_tls_plaintext(ks, buf, wakeup, \u0026continue_tls_process))"},{"line_number":2948,"context_line":"        {"},{"line_number":2949,"context_line":"            goto error;"},{"line_number":2950,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2662067f_27eb71a1","line":2947,"updated":"2023-11-20 13:12:13.000000000","message":"Should rename argument of read_incoming_tls_plaintext as well","commit_id":"0867c42f4975e317e7f33e7931c3a0ae0da1e675"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a0752893f19126891c6d7866f4c5e240bcf4d970","unresolved":false,"context_lines":[{"line_number":2944,"context_line":"    struct buffer *buf \u003d \u0026ks-\u003eplaintext_read_buf;"},{"line_number":2945,"context_line":"    if (!buf-\u003elen)"},{"line_number":2946,"context_line":"    {"},{"line_number":2947,"context_line":"        if (!read_incoming_tls_plaintext(ks, buf, wakeup, \u0026continue_tls_process))"},{"line_number":2948,"context_line":"        {"},{"line_number":2949,"context_line":"            goto error;"},{"line_number":2950,"context_line":"        }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1e69d0fc_7323711d","line":2947,"in_reply_to":"2662067f_27eb71a1","updated":"2023-11-20 17:15:44.000000000","message":"Done","commit_id":"0867c42f4975e317e7f33e7931c3a0ae0da1e675"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"019a1b9adbd5af6a8955eef962335c9dbc4af424","unresolved":true,"context_lines":[{"line_number":3004,"context_line":"        buf \u003d reliable_get_buf_output_sequenced(ks-\u003esend_reliable);"},{"line_number":3005,"context_line":"        if (buf)"},{"line_number":3006,"context_line":"        {"},{"line_number":3007,"context_line":"            if (!write_outgoing_tls_ciphertext(session, \u0026state_change))"},{"line_number":3008,"context_line":"            {"},{"line_number":3009,"context_line":"                goto error;"},{"line_number":3010,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"17cb7023_b42d55a5","line":3007,"updated":"2023-11-20 14:54:58.000000000","message":"Still says state_change, breaking the build","commit_id":"f5aac3fb0a0d726e021f9ab76c86e49ca057381e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a0752893f19126891c6d7866f4c5e240bcf4d970","unresolved":false,"context_lines":[{"line_number":3004,"context_line":"        buf \u003d reliable_get_buf_output_sequenced(ks-\u003esend_reliable);"},{"line_number":3005,"context_line":"        if (buf)"},{"line_number":3006,"context_line":"        {"},{"line_number":3007,"context_line":"            if (!write_outgoing_tls_ciphertext(session, \u0026state_change))"},{"line_number":3008,"context_line":"            {"},{"line_number":3009,"context_line":"                goto error;"},{"line_number":3010,"context_line":"            }"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c4c12c6f_b4fe17bb","line":3007,"in_reply_to":"17cb7023_b42d55a5","updated":"2023-11-20 17:15:44.000000000","message":"That is what you get for only testing the whole patch set and not each commit.","commit_id":"f5aac3fb0a0d726e021f9ab76c86e49ca057381e"}]}
