)]}'
{"id":"openvpn~452","triplet_id":"openvpn~master~Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-12-02 19:50:38.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-11-21 14:41:04.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585","subject":"Rename state_change to continue_tls_process","status":"MERGED","created":"2023-11-20 13:02:31.000000000","updated":"2023-12-02 19:50:38.000000000","submitted":"2023-12-02 19:50:38.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"452","meta_rev_id":"2c870bd1d082050b6c35cf0c4254aae3ff21be3b","_number":452,"virtual_id_number":452,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-20 13:02:32.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-20 13:02:32.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"3fc65116eb849196b9fd77975a7050e6f9a5ff46","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 13:02:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5cfe5e6bc88158d9d47c8f9011e96411a04ab365","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-20 13:12:13.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2902b7e9b5a3853ad276b0e1cdd276fb783085ca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 13:26:26.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"019a1b9adbd5af6a8955eef962335c9dbc4af424","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-20 14:54:58.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ec19e429941700d4ad7631c4c9f7ae2f8882314f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 17:10:59.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"a0752893f19126891c6d7866f4c5e240bcf4d970","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-20 17:15:44.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"318b6052e4980faaf3b9da234f545f136b83c4f9","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-21 14:41:04.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"bacd50e6238dfac1aab7bee17b3c58011fea3276","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-28 10:37:13.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"2c870bd1d082050b6c35cf0c4254aae3ff21be3b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-12-02 19:50:38.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"8ba03f91388970754f3536866f9687759b07a63c","revisions":{"0867c42f4975e317e7f33e7931c3a0ae0da1e675":{"kind":"REWORK","_number":1,"created":"2023-11-20 13:02:31.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/452/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/452/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/1 \u0026\u0026 git checkout -b change-452 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/452/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb20770f280a6098ea726ae9de69b5ed5a74f5e4","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-03 14:11:32.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-20 12:44:23.000000000","tz":120},"subject":"Rename state_change to continue_tls_process","message":"Rename state_change to continue_tls_process\n\nThe name state_change is more confusing than helpful as it not really\nindicates if there was a state change but rather if processing should\nbe continued. There even some states that are definitively state changes\n(setting to_link buffer) that require continue_tls_process to be set\nto false.\n\nChange-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585\n"},"branch":"refs/heads/master"},"f5aac3fb0a0d726e021f9ab76c86e49ca057381e":{"kind":"REWORK","_number":2,"created":"2023-11-20 13:26:26.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/452/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/452/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/2 \u0026\u0026 git checkout -b change-452 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/452/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb20770f280a6098ea726ae9de69b5ed5a74f5e4","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-03 14:11:32.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-20 13:21:36.000000000","tz":120},"subject":"Rename state_change to continue_tls_process","message":"Rename state_change to continue_tls_process\n\nThe name state_change is more confusing than helpful as it not really\nindicates if there was a state change but rather if processing should\nbe continued. There even some states that are definitively state changes\n(setting to_link buffer) that require continue_tls_process to be set\nto false.\n\nChange-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585\n"},"branch":"refs/heads/master"},"0c0d7cd4ba49fe2f2d15cc55a07a5832d36a9889":{"kind":"REWORK","_number":3,"created":"2023-11-20 17:10:59.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/52/452/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/452/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/3 \u0026\u0026 git checkout -b change-452 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/452/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6bf7433be6aafe63827a0b31c30b7f64472036da","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-03 14:11:32.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-20 17:09:06.000000000","tz":60},"subject":"Rename state_change to continue_tls_process","message":"Rename state_change to continue_tls_process\n\nThe name state_change is more confusing than helpful as it not really\nindicates if there was a state change but rather if processing should\nbe continued. There even some states that are definitively state changes\n(setting to_link buffer) that require continue_tls_process to be set\nto false.\n\nChange-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585\n"},"branch":"refs/heads/master"},"8ba03f91388970754f3536866f9687759b07a63c":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2023-12-02 19:50:38.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/52/452/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/52/452/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/4 \u0026\u0026 git checkout -b change-452 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/52/452/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/52/452/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a68595a582b2c6c220b4f4502753d5f4154000d8","subject":"Remove compat versionhelpers.h and remove cmake/configure check for it"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-28 10:37:04.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-12-02 16:45:40.000000000","tz":60},"subject":"Rename state_change to continue_tls_process","message":"Rename state_change to continue_tls_process\n\nThe name state_change is more confusing than helpful as it not really\nindicates if there was a state change but rather if processing should\nbe continued. There even some states that are definitively state changes\n(setting to_link buffer) that require continue_tls_process to be set\nto false.\n\nChange-Id: Ib6d713f2eb08a4c39d97de3e1a4a832cedc09585\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nMessage-Id: \u003c20231128103704.61046-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27571.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}