)]}'
{"id":"openvpn~456","triplet_id":"openvpn~master~Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3","project":"openvpn","branch":"master","topic":"tls10prf","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2023-12-26 19:41:15.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2023-12-08 11:05:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3","subject":"Extend the error message when TLS 1.0 PRF fails","status":"MERGED","created":"2023-11-21 18:18:34.000000000","updated":"2023-12-26 19:41:15.000000000","submitted":"2023-12-26 19:41:15.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"456-tls10prf","meta_rev_id":"2f3aa975592c2f167ff8906b20ea1f9faed9908a","_number":456,"virtual_id_number":456,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-21 18:18:35.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-11-21 18:18:35.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"5d543918d5598fbf64776723ca7352db62ca8ec1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-21 18:18:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"620cbb70fa7781fa1d140a523377557e4cd54656","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-21 19:35:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d82b0082bca4d07465af04694b224750ceb45b5c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-22 10:45:13.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"8e07ff0dbd972c076397bc6958416bf9d8197bf7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-23 12:39:57.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent tree, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"3185f5b8ddf8a9853828028f39424b2b804750a8","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-11-28 11:10:36.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"23b80c83186a1c701da9356a6d0a0ae8a69ef273","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-28 13:39:16.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"9492cdb1be787368a597eaf1c661664a6001b694","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-28 13:40:26.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":5},{"id":"f248143bcb68035d6bb509ec2e2aedf1b575eefe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-11-29 12:17:19.000000000","message":"Uploaded patch set 6: New patch set was added with same tree, parent tree, and commit message as Patch Set 5.","accounts_in_message":[],"_revision_number":6},{"id":"e0b27b0f4ed7aa22c6b90f27fb787486fef12597","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-01 11:11:21.000000000","message":"Patch Set 6: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"17aad33097614ec1afe2850be11fc1bb7dce4db3","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-01 12:12:01.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"a15e6238202d4040fb008ef19993d91bed1789c2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-01 12:19:04.000000000","message":"Uploaded patch set 7: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":7},{"id":"54216320179d0ac182faff69b2730092faf208fe","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-07 10:50:43.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"b0df7ec98efedfd63c6545c0eb9027a5faa0cce3","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-07 18:23:41.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"2e86db42f659c4135d6bb13e9e7afbc554be22e6","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-08 11:05:51.000000000","message":"Patch Set 7: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":7},{"id":"e160d7a2a8cdc3233a65ca53606b95ecb13536db","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-11 17:17:51.000000000","message":"Patch Set 8: Patch Set 7 was rebased\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR is:MIN\")\n","accounts_in_message":[],"_revision_number":8},{"id":"e74c297af109333e9c72950a29451d7aa63f16ae","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-13 10:52:24.000000000","message":"Patch Set 8: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":8},{"id":"20afd10eae59500a5221b99a82bf3ad9fb59bdaf","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-13 10:53:19.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":8},{"id":"2f3aa975592c2f167ff8906b20ea1f9faed9908a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2023-12-26 19:41:15.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"6ff816142c1acdaee149c4daabb297fefc2ccde0","revisions":{"49075848c908990ac946f990ff65c3406878de05":{"kind":"REWORK","_number":1,"created":"2023-11-21 18:18:34.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/1 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"78e0c5f2f57a18e8ea60951696a458a4b3ff3621","subject":"sample-keys: renew for the next 10 years"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:18:29.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\n"},"branch":"refs/heads/master"},"3fe3e2d474d4b8162e5cd8b008abf7eb35e680f3":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2023-11-21 19:35:58.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/2 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"57172d84096cc03e4a5a0658b9abb15d4173859d","subject":"Introduce report_command_status helper function"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 19:35:41.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"c857a436bb8019dc39c2a7475d9e468219d9e2f2":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-11-22 10:45:13.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/3 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1cb1b47b138b9f654cd0bca5de6d08dbca61888","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-22 10:45:07.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"274ab5ab12d2317e626b32e2d040a5ca539e65f1":{"kind":"NO_CHANGE","_number":4,"created":"2023-11-23 12:39:57.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/4 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1cb1b47b138b9f654cd0bca5de6d08dbca61888","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-23 12:39:39.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"2d04a96c0084d094b53cedde9ce4103db9ac818c":{"kind":"REWORK","_number":5,"created":"2023-11-28 13:40:26.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/5 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1cb1b47b138b9f654cd0bca5de6d08dbca61888","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-28 13:40:15.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"8ec7c68d2a054b724fd4210059692ceba9e3495c":{"kind":"NO_CHANGE","_number":6,"created":"2023-11-29 12:17:19.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/6 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1cb1b47b138b9f654cd0bca5de6d08dbca61888","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-29 12:16:40.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more system will drop TLS 1.0 PRF support. We are already seeing\npeople stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding of TLS or\nthe OpenVPN protocol. Improve a on this message to give a normal user a chance\nto understand that the peer needs to be OpenVPN 2.6.x or newer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"ddb0cfddb3e34336bcf8225ac1864d00219f7f62":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2023-12-01 12:19:04.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/7 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a1cb1b47b138b9f654cd0bca5de6d08dbca61888","subject":"Log SSL alerts more prominently"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-01 12:15:13.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more systems will drop TLS 1.0 PRF support. We are already\nseeing people stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding\nof TLS or the OpenVPN protocol. Improve this message to give a normal\nuser a chance to understand that the peer needs to be OpenVPN 2.6.x or\nnewer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"ab00dcdb4e2c24898729334f1b2af13ccde87386":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2023-12-11 17:17:51.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/56/456/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/8 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3094d8fb061c56ea73eda00c464fa81cdcd55c94","subject":"Move tls_get_cipher_name_pair and get_num_elements to ssl_utils.c"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-11-21 18:13:46.000000000","tz":60},"committer":{"name":"plaisthos","email":"arne-openvpn@rfc2549.org","date":"2023-12-11 17:17:51.000000000","tz":0},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more systems will drop TLS 1.0 PRF support. We are already\nseeing people stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding\nof TLS or the OpenVPN protocol. Improve this message to give a normal\nuser a chance to understand that the peer needs to be OpenVPN 2.6.x or\nnewer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"6ff816142c1acdaee149c4daabb297fefc2ccde0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":9,"created":"2023-12-26 19:41:15.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/56/456/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/456/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/9 \u0026\u0026 git checkout -b change-456 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/456/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/456/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c590868a721881dd21bfb77ecf846e6c8720e4ef","subject":"tun.c: don\u0027t attempt to delete DNS and WINS servers if they\u0027re not set"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-13 10:53:08.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2023-12-26 19:37:25.000000000","tz":60},"subject":"Extend the error message when TLS 1.0 PRF fails","message":"Extend the error message when TLS 1.0 PRF fails\n\nThis error will probably become more and more common in the future when\nmore and more systems will drop TLS 1.0 PRF support. We are already\nseeing people stumbling upon this (see GitHub issue #460)\n\nThe current error messages\n\n  TLS Error: PRF calcuation failed\n  TLS Error: generate_key_expansion failed\n\nare not very helpful for people that do not have deep understanding\nof TLS or the OpenVPN protocol. Improve this message to give a normal\nuser a chance to understand that the peer needs to be OpenVPN 2.6.x or\nnewer.\n\nChange-Id: Ib3b64b52beed69dc7740f191b0e9a9dc9af5b7f3\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20231213105308.121460-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27796.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}