)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b67b6af47b4f3d3ee5c9b5fdb8bd8614e29133e7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"us now with three different implementation for 1.0.2, 1.1.x and 3.x."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This was initially done to maybe still have a working TLS 1.0 PRF when"},{"line_number":13,"context_line":"using OpenSSL 3.0, it gives the same error as with the older API but"},{"line_number":14,"context_line":"since moving to a new API is always good, we use the new API when using"},{"line_number":15,"context_line":"OpenSSL 3.0. We also print the internal OpenSSL error message when"},{"line_number":16,"context_line":"the KDF fails."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"13568f5e_b6cd455d","line":13,"updated":"2023-11-28 14:00:19.000000000","message":"missing \"in FIPS mode\"? My understanding is that this still works with \"normal\" OpenSSL 3?","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"67629304985354bcf3eb1fc3d29c37af0bdae69b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"us now with three different implementation for 1.0.2, 1.1.x and 3.x."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This was initially done to maybe still have a working TLS 1.0 PRF when"},{"line_number":13,"context_line":"using OpenSSL 3.0, it gives the same error as with the older API but"},{"line_number":14,"context_line":"since moving to a new API is always good, we use the new API when using"},{"line_number":15,"context_line":"OpenSSL 3.0. We also print the internal OpenSSL error message when"},{"line_number":16,"context_line":"the KDF fails."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ae29b807_47365dcf","line":13,"in_reply_to":"13568f5e_b6cd455d","updated":"2023-11-29 12:15:50.000000000","message":"Done","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b67b6af47b4f3d3ee5c9b5fdb8bd8614e29133e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bded0bdb_e2474090","updated":"2023-11-28 14:00:19.000000000","message":"I have my doubts whether this change is worth it if it doesn\u0027t actually fixes anything?\nAnyway, currently not -Werrror clean, so not mergeable right now.","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"67629304985354bcf3eb1fc3d29c37af0bdae69b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba76d707_0ecfd29c","in_reply_to":"bded0bdb_e2474090","updated":"2023-11-29 12:15:50.000000000","message":"One advantage is that we at least are now compatible with compiling against an OpenSSL that has been compiled with OPENSSL_NO_MD5. Otherwise we fail at the EVP_md5_sha1 function call.","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1353e4917cc3721d33cf1c06e6651e96bcf4c7d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"64f7f525_d9689c14","updated":"2023-12-01 12:42:25.000000000","message":"Resetting my vote since my concern about general usefulness was addressed. Will need to do some actual testing before being able to ack.","commit_id":"6ec91e6c5d26d8dd54fc0dd50fe62d3b6bbba3b4"}],"src/openvpn/crypto_openssl.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"b67b6af47b4f3d3ee5c9b5fdb8bd8614e29133e7","unresolved":true,"context_lines":[{"line_number":1401,"context_line":"    params[0] \u003d OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST,"},{"line_number":1402,"context_line":"                                                 SN_md5_sha1, strlen(SN_md5_sha1));"},{"line_number":1403,"context_line":"    params[1] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SECRET,"},{"line_number":1404,"context_line":"                                                  secret, (size_t) secret_len);"},{"line_number":1405,"context_line":"    params[2] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SEED,"},{"line_number":1406,"context_line":"                                                  seed, (size_t) seed_len);"},{"line_number":1407,"context_line":"    params[3] \u003d OSSL_PARAM_construct_end();"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"d48aa189_6936623c","line":1404,"updated":"2023-11-28 14:00:19.000000000","message":"../../../src/openvpn/crypto_openssl.c:1404:51: warning: passing argument 2 of ‘OSSL_PARAM_construct_octet_string’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]\n 1404 |                                                   secret, (size_t) secret_len);","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"67629304985354bcf3eb1fc3d29c37af0bdae69b","unresolved":false,"context_lines":[{"line_number":1401,"context_line":"    params[0] \u003d OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST,"},{"line_number":1402,"context_line":"                                                 SN_md5_sha1, strlen(SN_md5_sha1));"},{"line_number":1403,"context_line":"    params[1] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SECRET,"},{"line_number":1404,"context_line":"                                                  secret, (size_t) secret_len);"},{"line_number":1405,"context_line":"    params[2] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SEED,"},{"line_number":1406,"context_line":"                                                  seed, (size_t) seed_len);"},{"line_number":1407,"context_line":"    params[3] \u003d OSSL_PARAM_construct_end();"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"fd9542a8_f818ca77","line":1404,"in_reply_to":"d48aa189_6936623c","updated":"2023-11-29 12:15:50.000000000","message":"Done","commit_id":"c400f4ef5025ee1d59762df4e71b46898107999a"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"1353e4917cc3721d33cf1c06e6651e96bcf4c7d9","unresolved":true,"context_lines":[{"line_number":1403,"context_line":"    params[0] \u003d OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST,"},{"line_number":1404,"context_line":"                                                 SN_md5_sha1, strlen(SN_md5_sha1));"},{"line_number":1405,"context_line":"    params[1] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SECRET,"},{"line_number":1406,"context_line":"                                                 (uint8_t *) secret, (size_t) secret_len);"},{"line_number":1407,"context_line":"    params[2] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SEED,"},{"line_number":1408,"context_line":"                                                  (uint8_t *) seed, (size_t) seed_len);"},{"line_number":1409,"context_line":"    params[3] \u003d OSSL_PARAM_construct_end();"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c42d2a0a_ac343d16","line":1406,"updated":"2023-12-01 12:42:25.000000000","message":"Makes format-check unhappy","commit_id":"6ec91e6c5d26d8dd54fc0dd50fe62d3b6bbba3b4"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"de972dd516378c1b11b448b4726b5b273ee1c0ca","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"    params[0] \u003d OSSL_PARAM_construct_utf8_string(OSSL_KDF_PARAM_DIGEST,"},{"line_number":1404,"context_line":"                                                 SN_md5_sha1, strlen(SN_md5_sha1));"},{"line_number":1405,"context_line":"    params[1] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SECRET,"},{"line_number":1406,"context_line":"                                                 (uint8_t *) secret, (size_t) secret_len);"},{"line_number":1407,"context_line":"    params[2] \u003d OSSL_PARAM_construct_octet_string(OSSL_KDF_PARAM_SEED,"},{"line_number":1408,"context_line":"                                                  (uint8_t *) seed, (size_t) seed_len);"},{"line_number":1409,"context_line":"    params[3] \u003d OSSL_PARAM_construct_end();"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"c96ab8f9_d5967aa5","line":1406,"in_reply_to":"c42d2a0a_ac343d16","updated":"2024-01-05 13:56:11.000000000","message":"Done","commit_id":"6ec91e6c5d26d8dd54fc0dd50fe62d3b6bbba3b4"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"05864bdb2806cba9fad0bc89971213b35a11e92f","unresolved":true,"context_lines":[{"line_number":1421,"context_line":"    ret \u003d false;"},{"line_number":1422,"context_line":"out:"},{"line_number":1423,"context_line":"    EVP_KDF_free(kdf);"},{"line_number":1424,"context_line":"    EVP_KDF_free(kdf);"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"    return ret;"},{"line_number":1427,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"00addad7_5d09b653","line":1424,"updated":"2023-12-20 16:59:16.000000000","message":"double free?","commit_id":"6ec91e6c5d26d8dd54fc0dd50fe62d3b6bbba3b4"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"de972dd516378c1b11b448b4726b5b273ee1c0ca","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"    ret \u003d false;"},{"line_number":1422,"context_line":"out:"},{"line_number":1423,"context_line":"    EVP_KDF_free(kdf);"},{"line_number":1424,"context_line":"    EVP_KDF_free(kdf);"},{"line_number":1425,"context_line":""},{"line_number":1426,"context_line":"    return ret;"},{"line_number":1427,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":7,"id":"648e41e0_161b8fa0","line":1424,"in_reply_to":"00addad7_5d09b653","updated":"2024-01-05 13:56:11.000000000","message":"Done","commit_id":"6ec91e6c5d26d8dd54fc0dd50fe62d3b6bbba3b4"}]}