)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"eb749ca76e01284cc014ff03ea97fc694e9843e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed9c6636_baac9a4f","updated":"2023-12-18 18:18:14.000000000","message":"To be honest, I find a message telling me \"is pkg-config installed (using /usr/bin/pkg-config)?\" to be even more confusing.\n\nIf we already know we have pkg-config, we shouldn\u0027t ask - and if we know we do not have pkg-config, we shouldn\u0027t bother asking for \"is libcap-ng installed?\" because we know we wouldn\u0027t find it, even if it is...","commit_id":"f064d214d485042b4b6bf5911ecaf296c2bd7464"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ec6b9b54dbaf01825acf8658125bfd5e332a0417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b75a92b5_ca6783c4","updated":"2024-01-04 16:29:56.000000000","message":"I do like the new approach.  Hope to see a test report from ordex (he does this \"linux\" stuff, I have been told).  But I can still +2 it in the meantime and send to the list.","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"d1915e41bc48358f10d37a038cc9ff7fe000cae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1df985e1_b7f9dd3e","updated":"2024-01-04 23:17:56.000000000","message":"Other than the two comments I added in the code, the patch does what it says and it makes very straightforward understanding that pkg-config is now not installed.\nTested a couple of cases on my lovely gentoo and it just worked.","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"}],"configure.ac":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"aade0d4c3e0ea68888e6da952a5fa473febc19f6","unresolved":true,"context_lines":[{"line_number":384,"context_line":"PKG_PROG_PKG_CONFIG"},{"line_number":385,"context_line":"# Add variable to print if pkg-config is found or not. Users often miss that"},{"line_number":386,"context_line":"if test \"${PKG_CONFIG}\" \u003d \"\"; then"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":388,"context_line":"else"},{"line_number":389,"context_line":"    pkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":390,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"40d96ea7_0246b3c8","line":387,"updated":"2023-12-01 14:24:59.000000000","message":"indent","commit_id":"a3681899c32b00421f4271b2cd1af79a5cabb23e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"18260cdbbddf91897ee6e21861e5416f7311d5e9","unresolved":false,"context_lines":[{"line_number":384,"context_line":"PKG_PROG_PKG_CONFIG"},{"line_number":385,"context_line":"# Add variable to print if pkg-config is found or not. Users often miss that"},{"line_number":386,"context_line":"if test \"${PKG_CONFIG}\" \u003d \"\"; then"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":388,"context_line":"else"},{"line_number":389,"context_line":"    pkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":390,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"28017652_1a658295","line":387,"in_reply_to":"1f49058a_883de55c","updated":"2023-12-11 14:04:51.000000000","message":"Done","commit_id":"a3681899c32b00421f4271b2cd1af79a5cabb23e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"76acb9582ef76adec7cef23df22a8c1ce2e60259","unresolved":true,"context_lines":[{"line_number":384,"context_line":"PKG_PROG_PKG_CONFIG"},{"line_number":385,"context_line":"# Add variable to print if pkg-config is found or not. Users often miss that"},{"line_number":386,"context_line":"if test \"${PKG_CONFIG}\" \u003d \"\"; then"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":388,"context_line":"else"},{"line_number":389,"context_line":"    pkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":390,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f49058a_883de55c","line":387,"in_reply_to":"40d96ea7_0246b3c8","updated":"2023-12-11 14:03:21.000000000","message":"Damn indenting with tabs instead of spaces. I will double check all other indents as well.","commit_id":"a3681899c32b00421f4271b2cd1af79a5cabb23e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"aade0d4c3e0ea68888e6da952a5fa473febc19f6","unresolved":true,"context_lines":[{"line_number":870,"context_line":"dnl"},{"line_number":871,"context_line":"case \"$host\" in"},{"line_number":872,"context_line":"\t*-*-linux*)"},{"line_number":873,"context_line":"\t    # We require pkg-config"},{"line_number":874,"context_line":"\t\tPKG_CHECK_MODULES([LIBCAPNG],"},{"line_number":875,"context_line":"\t\t\t\t  [libcap-ng],"},{"line_number":876,"context_line":"\t\t\t\t  [],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"78923a38_48ba8d16","line":873,"updated":"2023-12-01 14:24:59.000000000","message":"indent","commit_id":"a3681899c32b00421f4271b2cd1af79a5cabb23e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"18260cdbbddf91897ee6e21861e5416f7311d5e9","unresolved":false,"context_lines":[{"line_number":870,"context_line":"dnl"},{"line_number":871,"context_line":"case \"$host\" in"},{"line_number":872,"context_line":"\t*-*-linux*)"},{"line_number":873,"context_line":"\t    # We require pkg-config"},{"line_number":874,"context_line":"\t\tPKG_CHECK_MODULES([LIBCAPNG],"},{"line_number":875,"context_line":"\t\t\t\t  [libcap-ng],"},{"line_number":876,"context_line":"\t\t\t\t  [],"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"a9e557dc_cc9d2ae5","line":873,"in_reply_to":"78923a38_48ba8d16","updated":"2023-12-11 14:04:51.000000000","message":"Done","commit_id":"a3681899c32b00421f4271b2cd1af79a5cabb23e"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"d1915e41bc48358f10d37a038cc9ff7fe000cae4","unresolved":true,"context_lines":[{"line_number":382,"context_line":"    if test \"${pkg_config_required}\" \u003d \"yes\"; then"},{"line_number":383,"context_line":"        AC_MSG_ERROR([pkg-config is required])"},{"line_number":384,"context_line":"    fi"},{"line_number":385,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":386,"context_line":"else"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":388,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"a58bb3dc_c4b892a1","line":385,"updated":"2024-01-04 23:17:56.000000000","message":"am I wrong or there is some indentation havoc here? The line above uses 8blanks tab, but the lines before have 4 spaces indentation?\n\nI think we uses tabs everywhere else.","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"302d54fb3ab1278548dc321b29c0f4a0be644dd4","unresolved":false,"context_lines":[{"line_number":382,"context_line":"    if test \"${pkg_config_required}\" \u003d \"yes\"; then"},{"line_number":383,"context_line":"        AC_MSG_ERROR([pkg-config is required])"},{"line_number":384,"context_line":"    fi"},{"line_number":385,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":386,"context_line":"else"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":388,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"dcc958e2_10a99171","line":385,"in_reply_to":"a58bb3dc_c4b892a1","updated":"2024-01-05 12:25:08.000000000","message":"Done","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"d1915e41bc48358f10d37a038cc9ff7fe000cae4","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    fi"},{"line_number":385,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":386,"context_line":"else"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":388,"context_line":"fi"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"AC_PROG_CPP"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5512845f_c09de864","line":387,"updated":"2024-01-04 23:17:56.000000000","message":"many error messages already contain \u0027using pkg-config\u0027, therefore the text above will lead to \u0027using using\u0027, which sounds weird.\nHow about changing \u0027using\u0027 with \u0027path:\u0027?","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"302d54fb3ab1278548dc321b29c0f4a0be644dd4","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    fi"},{"line_number":385,"context_line":"\tpkg_config_found\u003d\"(not found)\""},{"line_number":386,"context_line":"else"},{"line_number":387,"context_line":"\tpkg_config_found\u003d\"(using ${PKG_CONFIG})\""},{"line_number":388,"context_line":"fi"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"AC_PROG_CPP"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2097ad6b_aaa8c8c1","line":387,"in_reply_to":"5512845f_c09de864","updated":"2024-01-05 12:25:08.000000000","message":"Done","commit_id":"8af4d6d432cd051d5a9a1fca0e99e2c188d2450e"}]}