)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8beb45eb0f1760cb0896f5d66da7b2be28ec39ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"521cf75f_282964f5","updated":"2023-12-06 15:27:28.000000000","message":"More unit tests is always better","commit_id":"5822808966b260e6afefeadcd2b7ff632cb960ba"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"7579e2196f972f457dd354221ce28a788041d7ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a6231a92_ee44c9ad","updated":"2024-01-17 21:34:13.000000000","message":"Unfortunately the trees have diverged too much for this to go on neatly.  @frank@lichtenheld.com can you rebase please?","commit_id":"29cbb7968eb7cd81e0f0b6cbad82e6d570a3e7de"}],"CMakeLists.txt":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2593a1d9f7a8f102f555cdba9af7386ed134bd30","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            add_test(${test_name} ${test_name})"},{"line_number":623,"context_line":"            # for compat with autotools make check"},{"line_number":624,"context_line":"            set_tests_properties(${test_name} PROPERTIES"},{"line_number":625,"context_line":"                ENVIRONMENT \"srcdir\u003d${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn\")"},{"line_number":626,"context_line":"        endif ()"},{"line_number":627,"context_line":"        add_executable(${test_name}"},{"line_number":628,"context_line":"            tests/unit_tests/openvpn/${test_name}.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"ced071e8_e7d892e4","line":625,"updated":"2023-12-11 14:42:48.000000000","message":"Why not use a define instead like \n\nadd_compile_definition(${target} -DSRCDIR\u003d\"${CMAKE_CURRENT_SOURCE_DIR}\"? That seems less fragile then an environment variable.","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"140d5cd578b0f7f5151bfa1750871d8eed9fbe8a","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            add_test(${test_name} ${test_name})"},{"line_number":623,"context_line":"            # for compat with autotools make check"},{"line_number":624,"context_line":"            set_tests_properties(${test_name} PROPERTIES"},{"line_number":625,"context_line":"                ENVIRONMENT \"srcdir\u003d${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn\")"},{"line_number":626,"context_line":"        endif ()"},{"line_number":627,"context_line":"        add_executable(${test_name}"},{"line_number":628,"context_line":"            tests/unit_tests/openvpn/${test_name}.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"3e694e97_351c140e","line":625,"in_reply_to":"010f5528_3a64e9cc","updated":"2023-12-11 16:09:44.000000000","message":"srcdir environment variable is the official interface for automake test suite which is why I used it. But we can go for a define as well. Should probably report that as a bug against your IDE though. Just ignoring part of the cmake code seems bad.","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"512c1f65bd9d7978c58841bcb0a012e25fcbbded","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            add_test(${test_name} ${test_name})"},{"line_number":623,"context_line":"            # for compat with autotools make check"},{"line_number":624,"context_line":"            set_tests_properties(${test_name} PROPERTIES"},{"line_number":625,"context_line":"                ENVIRONMENT \"srcdir\u003d${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn\")"},{"line_number":626,"context_line":"        endif ()"},{"line_number":627,"context_line":"        add_executable(${test_name}"},{"line_number":628,"context_line":"            tests/unit_tests/openvpn/${test_name}.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"dee6622f_63f1197f","line":625,"in_reply_to":"3e694e97_351c140e","updated":"2023-12-12 13:34:07.000000000","message":"Using a define breaks the mingw unit tests so still looking into this.","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"0a1abe6920047be3997cc1cc1aeb74193df401eb","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            add_test(${test_name} ${test_name})"},{"line_number":623,"context_line":"            # for compat with autotools make check"},{"line_number":624,"context_line":"            set_tests_properties(${test_name} PROPERTIES"},{"line_number":625,"context_line":"                ENVIRONMENT \"srcdir\u003d${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn\")"},{"line_number":626,"context_line":"        endif ()"},{"line_number":627,"context_line":"        add_executable(${test_name}"},{"line_number":628,"context_line":"            tests/unit_tests/openvpn/${test_name}.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"010f5528_3a64e9cc","line":625,"in_reply_to":"444e8ac1_9c9bf24b","updated":"2023-12-11 15:56:28.000000000","message":"Alternative solution with the define: https://gerrit.openvpn.net/c/openvpn/+/446","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"36c9d311f8cc5bd9d498e20760cf38496eda9bdf","unresolved":true,"context_lines":[{"line_number":622,"context_line":"            add_test(${test_name} ${test_name})"},{"line_number":623,"context_line":"            # for compat with autotools make check"},{"line_number":624,"context_line":"            set_tests_properties(${test_name} PROPERTIES"},{"line_number":625,"context_line":"                ENVIRONMENT \"srcdir\u003d${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn\")"},{"line_number":626,"context_line":"        endif ()"},{"line_number":627,"context_line":"        add_executable(${test_name}"},{"line_number":628,"context_line":"            tests/unit_tests/openvpn/${test_name}.c"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"444e8ac1_9c9bf24b","line":625,"in_reply_to":"ced071e8_e7d892e4","updated":"2023-12-11 14:53:05.000000000","message":"Also my IDE (Clion) does not pick this up, so I have manually configure to add that environment variable to run tests now.","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"}],"tests/unit_tests/openvpn/test_user_pass.c":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"2593a1d9f7a8f102f555cdba9af7386ed134bd30","unresolved":true,"context_lines":[{"line_number":83,"context_line":"{"},{"line_number":84,"context_line":"    assert_true(0);"},{"line_number":85,"context_line":"    return 0;"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"/* tooling */"},{"line_number":89,"context_line":"static void"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c4d4854d_87b23353","line":86,"updated":"2023-12-11 14:42:48.000000000","message":"I think we should be consistent here. Either do the (void) var; in all mocked functions or none. I would prefer not to use them if not necessary.","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"425cb9c4392d76b12853964b26bcdd4ad5ff3aa1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"{"},{"line_number":84,"context_line":"    assert_true(0);"},{"line_number":85,"context_line":"    return 0;"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"/* tooling */"},{"line_number":89,"context_line":"static void"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4030de4e_a0b3b845","line":86,"in_reply_to":"c4d4854d_87b23353","updated":"2023-12-12 13:58:18.000000000","message":"Done","commit_id":"c8002315b4055cd399e466f1a4307e9c6d24c6e0"}]}
