)]}'
{"CMakeLists.txt":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"13f8273b20f29cca3bebac77f127435b4c5cc7c6","unresolved":true,"context_lines":[{"line_number":290,"context_line":"                -DWIN32_LEAN_AND_MEAN"},{"line_number":291,"context_line":"                -DNTDDI_VERSION\u003dNTDDI_VISTA -D_WIN32_WINNT\u003d_WIN32_WINNT_VISTA"},{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        target_compile_options(${target} PRIVATE -municode -UUNICODE)"},{"line_number":294,"context_line":"        target_link_options(${target} PRIVATE -municode)"},{"line_number":295,"context_line":"    endif()"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-cmake","patch_set":3,"id":"b9f47f2d_bf7caf2c","line":293,"updated":"2023-12-20 12:25:20.000000000","message":"combining -municode with -UUNICODE and main(void) just means the -municode has no effect at all. So I would drop that.","commit_id":"c6423433cf160444a2f653bc46c79d735e8fd6bd"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8b2f0582df29fadaa6e2fee3da5c4cf7a9973d30","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                -DWIN32_LEAN_AND_MEAN"},{"line_number":291,"context_line":"                -DNTDDI_VERSION\u003dNTDDI_VISTA -D_WIN32_WINNT\u003d_WIN32_WINNT_VISTA"},{"line_number":292,"context_line":"        )"},{"line_number":293,"context_line":"        target_compile_options(${target} PRIVATE -municode -UUNICODE)"},{"line_number":294,"context_line":"        target_link_options(${target} PRIVATE -municode)"},{"line_number":295,"context_line":"    endif()"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-cmake","patch_set":3,"id":"b683acf6_b1411977","line":293,"in_reply_to":"b9f47f2d_bf7caf2c","updated":"2024-01-03 14:40:16.000000000","message":"I updated the patch to only use the same defines but not the -municode. After looking up -U that it undefines UNICODE I am not really sure anymore why we use that for the normal mingw build.","commit_id":"c6423433cf160444a2f653bc46c79d735e8fd6bd"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"13f8273b20f29cca3bebac77f127435b4c5cc7c6","unresolved":true,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if (MINGW)"},{"line_number":665,"context_line":"            # when compiling with -municode, mingw looks for wmain instead of main"},{"line_number":666,"context_line":"            target_compile_definitions(${test_name} PRIVATE -Dmain\u003dwmain)"},{"line_number":667,"context_line":"        endif ()"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        if (NOT ${test_name} STREQUAL \"test_buffer\")"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"38857a3b_fc89aeff","line":666,"updated":"2023-12-20 12:25:20.000000000","message":"Yeah, just don\u0027t use -municode in the first place.","commit_id":"c6423433cf160444a2f653bc46c79d735e8fd6bd"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8b2f0582df29fadaa6e2fee3da5c4cf7a9973d30","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if (MINGW)"},{"line_number":665,"context_line":"            # when compiling with -municode, mingw looks for wmain instead of main"},{"line_number":666,"context_line":"            target_compile_definitions(${test_name} PRIVATE -Dmain\u003dwmain)"},{"line_number":667,"context_line":"        endif ()"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        if (NOT ${test_name} STREQUAL \"test_buffer\")"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"5b8769bf_b8607c4b","line":666,"in_reply_to":"38857a3b_fc89aeff","updated":"2024-01-03 14:40:16.000000000","message":"Done","commit_id":"c6423433cf160444a2f653bc46c79d735e8fd6bd"}]}