)]}'
{"id":"openvpn~469","triplet_id":"openvpn~master~Ie5aa643ab6190262f7c8b9e614bedb398e85859b","project":"openvpn","branch":"master","topic":"tls-export-cert","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-16 13:23:19.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-08 16:14:06.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ie5aa643ab6190262f7c8b9e614bedb398e85859b","subject":"Use mingw compile definition also to unit tests","status":"MERGED","created":"2023-12-07 17:49:34.000000000","updated":"2024-01-16 13:23:19.000000000","submitted":"2024-01-16 13:23:19.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"469-tls-export-cert","meta_rev_id":"26585db60e6d7c84d7e4a6312927a8fdc35b60b8","_number":469,"virtual_id_number":469,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-07 17:49:35.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-12-07 17:49:35.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"}],"messages":[{"id":"20aaf3412861a71d00673ab33c09f2936fcd30de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-07 17:49:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a28fe0df5f7d5994aafd505ead261864e1390995","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-07 18:27:54.000000000","message":"Topic set to tls-export-cert","accounts_in_message":[],"_revision_number":1},{"id":"5b2cc3972fa568d6e5fd5ddf50bf0292b8addc56","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-11 13:59:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"825abf35a0345586e4adf91426d10e310b9b07c3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-13 14:06:59.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"13f8273b20f29cca3bebac77f127435b4c5cc7c6","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-20 12:25:20.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8b2f0582df29fadaa6e2fee3da5c4cf7a9973d30","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-03 14:40:16.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"aaee621e1639787e33b365da8fa07ef1bada0714","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-03 14:41:34.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":4},{"id":"31f6e047bf95913bb6ff4f0a720c4b77e1a704fb","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-08 16:14:06.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"26585db60e6d7c84d7e4a6312927a8fdc35b60b8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-16 13:23:19.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0ce06893912830fa2044c5d6a62e6333366afd4a","revisions":{"1a8d6dc3e15fb4cce4ffc1c92ca0a6587d07bde4":{"kind":"REWORK","_number":1,"created":"2023-12-07 17:49:34.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/69/469/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/469/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/1 \u0026\u0026 git checkout -b change-469 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/469/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22c27544ddf3e3a75fe7609f8ee0517dcbfd5ed4","subject":"Implement the --tls-export-cert feature"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-07 16:07:06.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-07 17:49:29.000000000","tz":60},"subject":"Use mingw compile definition also to unit tests","message":"Use mingw compile definition also to unit tests\n\nCurrently we only apply the defines for windows APIs and Unicode to\nOpenVPN itself. We should rather treat the unit tests the same as\nour main binary to reduce potential differences.\n\nChange-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"b43e8c79a3bcccca4aa77f01378081a8b969fb63":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-12-11 13:59:45.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/69/469/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/469/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/2 \u0026\u0026 git checkout -b change-469 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/469/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2211fcd0a7c0c52bf4bcfe814b65464c5bfde4ab","subject":"Implement the --tls-export-cert feature"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-07 16:07:06.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-11 13:53:04.000000000","tz":60},"subject":"Use mingw compile definition also to unit tests","message":"Use mingw compile definition also to unit tests\n\nCurrently we only apply the defines for windows APIs and Unicode to\nOpenVPN itself. We should rather treat the unit tests the same as\nour main binary to reduce potential differences.\n\nChange-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"c6423433cf160444a2f653bc46c79d735e8fd6bd":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-12-13 14:06:59.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/69/469/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/469/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/3 \u0026\u0026 git checkout -b change-469 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/469/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41","subject":"Move get_tmp_dir to win32-util.c and error out on failure"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-07 16:07:06.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-13 14:06:50.000000000","tz":60},"subject":"Use mingw compile definition also to unit tests","message":"Use mingw compile definition also to unit tests\n\nCurrently we only apply the defines for windows APIs and Unicode to\nOpenVPN itself. We should rather treat the unit tests the same as\nour main binary to reduce potential differences.\n\nChange-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"cde7337999395935fad19cc87c895a80b07bc8f3":{"kind":"REWORK","_number":4,"created":"2024-01-03 14:41:34.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/69/469/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/469/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/4 \u0026\u0026 git checkout -b change-469 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/469/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"76d11614797617708c31dc3db22e3568fee3de6d","subject":"get_default_gateway() HWADDR overhaul"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-07 16:07:06.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-03 14:41:27.000000000","tz":60},"subject":"Use mingw compile definition also to unit tests","message":"Use mingw compile definition also to unit tests\n\nCurrently we only apply the defines for windows APIs and Unicode to\nOpenVPN itself. We should rather treat the unit tests the same as\nour main binary to reduce potential differences.\n\nChange-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"0ce06893912830fa2044c5d6a62e6333366afd4a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2024-01-16 13:23:19.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/69/469/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/69/469/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/5 \u0026\u0026 git checkout -b change-469 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/69/469/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/69/469/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c58c7c3c669461805956dabc703c1279fe58eeee","subject":"Implement the --tls-export-cert feature"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-16 13:18:31.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-16 13:21:43.000000000","tz":60},"subject":"Use mingw compile definition also to unit tests","message":"Use mingw compile definition also to unit tests\n\nCurrently we only apply the defines for windows APIs and Unicode to\nOpenVPN itself. We should rather treat the unit tests the same as\nour main binary to reduce potential differences.\n\nChange-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240116131831.31217-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28019.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}