)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"db3f46968c823b5520bbf5dd49f325ddacc7eff5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25b88231_15703c30","updated":"2023-12-30 16:00:04.000000000","message":"this fails the GHA mingw builds with\n\n```\n  /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c: In function ‘crypto_pem_encode_certificate’:\n  Error: /home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/test_ssl.c:112:5: error: implicit declaration of function ‘backend_x509_write_pem’ [-Werror\u003dimplicit-function-declaration]\n    112 |     backend_x509_write_pem(cert, tmpfile);\n        |     ^~~~~~~~~~~~~~~~~~~~~~\n  cc1: all warnings being treated as errors\n```\n\n(see https://github.com/cron2/openvpn/actions/runs/7365003797/job/20045892888) so it can\u0027t go in yet.","commit_id":"c3dcde7fa27c2139d29b6845deb2887ce374afe0"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"993b1dc159d510f5d2856540c755788b22e23584","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f44e7d26_eb26fa5f","in_reply_to":"25b88231_15703c30","updated":"2024-01-02 11:35:14.000000000","message":"That is really strange. test_ssl.c includes ssl_verify_backend.h that defines that function. I need to see if I can reproduce this.","commit_id":"c3dcde7fa27c2139d29b6845deb2887ce374afe0"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a8caf2f0f83a7efd45c5bcfe2a6ff4213be720f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"98b1d8de_80e32431","updated":"2024-01-06 16:14:59.000000000","message":"Ah, now I understand where I got confused - this cannot be applied before #466, because otherwise there plainly is no backend function to call.  Sorry for confusing everbody.","commit_id":"36aec6e1fa765f5ff3bf9db0eec5c55bc1722972"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"17a705cc1f91fd9c9e263e057abed546bb4073ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f69b1b1b_1f7b46b2","updated":"2024-01-16 11:41:29.000000000","message":"Something is weird here.  The unit test passes on \"unixy\" platforms, and msbuild in GHA has no complaints (but might not build it either).\n\nmingw+cmake fails with an error related to pulling in wfp\n```\n[115/296] Linking C executable Debug/test_pkt.exe\n364\n  [116/296] Building C object CMakeFiles/test_ssl.dir/Debug/src/openvpn/block_dns.c.obj\n365\n  FAILED: CMakeFiles/test_ssl.dir/Debug/src/openvpn/block_dns.c.obj \n```\n\nwhile building autoconf-based mingw compiles the bits fine, and fails linking\n\n```\n  CC       ../../../src/openvpn/ssl_testdriver-xkey_helper.o\n  CC       ../../../src/openvpn/ssl_testdriver-ssl_util.o\n  CC       ../../../src/openvpn/ssl_testdriver-base64.o\n  CC       ../../../src/openvpn/ssl_testdriver-cryptoapi.o\n  CCLD     ssl_testdriver.exe\n/usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0x27c): undefined reference to `NCryptFreeObject@4\u0027\n/usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0x2b2): undefined reference to `_imp__CertFreeCertificateContext@4\u0027\n...\n/usr/bin/i686-w64-mingw32-ld: ../../../src/openvpn/ssl_testdriver-cryptoapi.o:cryptoapi.c:(.text+0xf9a): undefined reference to `tls_libctx\u0027\n```","commit_id":"69490d0beb7338221573da0d6c12a00ea1a1e230"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6dee0f72c74ec7379b15c385ac1376bf0c537ea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3cf9ab53_7a4641c6","updated":"2024-01-16 21:41:25.000000000","message":"now it passes mingw/autoconf builds as well","commit_id":"7336faf1874d68aa366655a2f948930e06f9acbf"}],"CMakeLists.txt":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":557,"context_line":"        \"test_auth_token\""},{"line_number":558,"context_line":"        \"test_buffer\""},{"line_number":559,"context_line":"        \"test_crypto\""},{"line_number":560,"context_line":"        \"test_ssl\""},{"line_number":561,"context_line":"        \"test_misc\""},{"line_number":562,"context_line":"        \"test_ncp\""},{"line_number":563,"context_line":"        \"test_packet_id\""}],"source_content_type":"text/x-cmake","patch_set":1,"id":"7cbe21a6_5ded543e","line":560,"updated":"2023-12-08 16:40:22.000000000","message":"Those are sorted alphabetically","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":557,"context_line":"        \"test_auth_token\""},{"line_number":558,"context_line":"        \"test_buffer\""},{"line_number":559,"context_line":"        \"test_crypto\""},{"line_number":560,"context_line":"        \"test_ssl\""},{"line_number":561,"context_line":"        \"test_misc\""},{"line_number":562,"context_line":"        \"test_ncp\""},{"line_number":563,"context_line":"        \"test_packet_id\""}],"source_content_type":"text/x-cmake","patch_set":1,"id":"0db70bef_074e855b","line":560,"in_reply_to":"7cbe21a6_5ded543e","updated":"2023-12-11 13:59:24.000000000","message":"Done","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":672,"context_line":"        src/openvpn/mss.c"},{"line_number":673,"context_line":"        )"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    target_sources(test_ssl PRIVATE"},{"line_number":676,"context_line":"            src/openvpn/crypto_mbedtls.c"},{"line_number":677,"context_line":"            src/openvpn/crypto_openssl.c"},{"line_number":678,"context_line":"            src/openvpn/ssl_openssl.c"}],"source_content_type":"text/x-cmake","patch_set":1,"id":"fb6707f8_9e4c3991","line":675,"updated":"2023-12-08 16:40:22.000000000","message":"also sorted alphabetically","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        src/openvpn/mss.c"},{"line_number":673,"context_line":"        )"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    target_sources(test_ssl PRIVATE"},{"line_number":676,"context_line":"            src/openvpn/crypto_mbedtls.c"},{"line_number":677,"context_line":"            src/openvpn/crypto_openssl.c"},{"line_number":678,"context_line":"            src/openvpn/ssl_openssl.c"}],"source_content_type":"text/x-cmake","patch_set":1,"id":"e741cdb3_5a0aaaff","line":675,"in_reply_to":"fb6707f8_9e4c3991","updated":"2023-12-11 13:59:24.000000000","message":"I sorted them like the other ones that include mock files and have the test/mock files first and not strictly alphabetical which would have put them at the end.","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"}],"tests/unit_tests/openvpn/Makefile.am":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"96e00bea720d40877e722ad6fd04b9ae9b3eb778","unresolved":true,"context_lines":[{"line_number":83,"context_line":"\t$(top_srcdir)/src/openvpn/mtu.c \\"},{"line_number":84,"context_line":"\t$(top_srcdir)/src/openvpn/win32-util.c \\"},{"line_number":85,"context_line":"\t$(top_srcdir)/src/openvpn/mss.c \\"},{"line_number":86,"context_line":"    $(top_srcdir)/src/openvpn/xkey_provider.c \\"},{"line_number":87,"context_line":"    $(top_srcdir)/src/openvpn/xkey_helper.c \\"},{"line_number":88,"context_line":"    $(top_srcdir)/src/openvpn/ssl_util.c \\"},{"line_number":89,"context_line":"    $(top_srcdir)/src/openvpn/base64.c \\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"0c7d5a64_4d9a9d5c","line":86,"updated":"2023-12-12 13:10:50.000000000","message":"indent","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"9719153b68d49cc42e0d25b7bfd1f90a3fbb4ea6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t$(top_srcdir)/src/openvpn/mtu.c \\"},{"line_number":84,"context_line":"\t$(top_srcdir)/src/openvpn/win32-util.c \\"},{"line_number":85,"context_line":"\t$(top_srcdir)/src/openvpn/mss.c \\"},{"line_number":86,"context_line":"    $(top_srcdir)/src/openvpn/xkey_provider.c \\"},{"line_number":87,"context_line":"    $(top_srcdir)/src/openvpn/xkey_helper.c \\"},{"line_number":88,"context_line":"    $(top_srcdir)/src/openvpn/ssl_util.c \\"},{"line_number":89,"context_line":"    $(top_srcdir)/src/openvpn/base64.c \\"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"2bd17b5f_bc89de26","line":86,"in_reply_to":"0c7d5a64_4d9a9d5c","updated":"2023-12-13 14:11:20.000000000","message":"Done","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"}],"tests/unit_tests/openvpn/mock_management.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2017-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"013fb9b0_9685277c","line":8,"updated":"2023-12-08 16:40:22.000000000","message":"Copy \u0026 paste error? Or intentional?","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2017-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5b10dbd9_9e007792","line":8,"in_reply_to":"013fb9b0_9685277c","updated":"2023-12-11 13:59:24.000000000","message":"Done","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"96e00bea720d40877e722ad6fd04b9ae9b3eb778","unresolved":true,"context_lines":[{"line_number":46,"context_line":"management_query_pk_sig(struct management *man, const char *b64_data,"},{"line_number":47,"context_line":"                        const char *algorithm)"},{"line_number":48,"context_line":"{"},{"line_number":49,"context_line":"    (void) man;"},{"line_number":50,"context_line":"    (void) b64_data;"},{"line_number":51,"context_line":"    (void) algorithm;"},{"line_number":52,"context_line":"    return NULL;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1c9c81df_b412d262","line":49,"updated":"2023-12-12 13:10:50.000000000","message":"inconsistent (void), used it in one function, but not the other","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"9719153b68d49cc42e0d25b7bfd1f90a3fbb4ea6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"management_query_pk_sig(struct management *man, const char *b64_data,"},{"line_number":47,"context_line":"                        const char *algorithm)"},{"line_number":48,"context_line":"{"},{"line_number":49,"context_line":"    (void) man;"},{"line_number":50,"context_line":"    (void) b64_data;"},{"line_number":51,"context_line":"    (void) algorithm;"},{"line_number":52,"context_line":"    return NULL;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"2c367b9e_17b39eb9","line":49,"in_reply_to":"1c9c81df_b412d262","updated":"2023-12-13 14:11:20.000000000","message":"Done","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"}],"tests/unit_tests/openvpn/mock_ssl_dependencies.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2017-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e183659b_a49b0182","line":8,"updated":"2023-12-08 16:40:22.000000000","message":"intentional?","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2017-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"979d7c62_638080d7","line":8,"in_reply_to":"e183659b_a49b0182","updated":"2023-12-11 13:59:24.000000000","message":"Done","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":21,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":22,"context_line":" */"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"/* Minimal set of mocked management function/globals to get unit tests to"},{"line_number":25,"context_line":" * compile */"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifdef HAVE_CONFIG_H"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8366d424_83a92832","line":24,"updated":"2023-12-08 16:40:22.000000000","message":"\"management\" is probably copy\u0026paste","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":21,"context_line":" *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA."},{"line_number":22,"context_line":" */"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"/* Minimal set of mocked management function/globals to get unit tests to"},{"line_number":25,"context_line":" * compile */"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#ifdef HAVE_CONFIG_H"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"96b5a578_3c274b81","line":24,"in_reply_to":"8366d424_83a92832","updated":"2023-12-11 13:59:24.000000000","message":"Done","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"}],"tests/unit_tests/openvpn/test_ssl.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"76ba1c362c5255c59aae9c7c2179a3a08e1a3c0b","unresolved":true,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2016-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c8cca67b_59a239d1","line":8,"updated":"2023-12-08 16:40:22.000000000","message":"probably not intentional","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"83cc725ebcc53a91061c9f8b43e1793105cec162","unresolved":false,"context_lines":[{"line_number":5,"context_line":" *             packet encryption, packet authentication, and"},{"line_number":6,"context_line":" *             packet compression."},{"line_number":7,"context_line":" *"},{"line_number":8,"context_line":" *  Copyright (C) 2016-2021 Fox Crypto B.V. \u003copenvpn@foxcrypto.com\u003e"},{"line_number":9,"context_line":" *"},{"line_number":10,"context_line":" *  This program is free software; you can redistribute it and/or modify"},{"line_number":11,"context_line":" *  it under the terms of the GNU General Public License version 2"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8b19f7d6_6a5c48d6","line":8,"in_reply_to":"c8cca67b_59a239d1","updated":"2023-12-11 13:59:24.000000000","message":"Done","commit_id":"a752ad6b8b7e6aa87a0d5c2566d444ed78c4f138"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"96e00bea720d40877e722ad6fd04b9ae9b3eb778","unresolved":true,"context_lines":[{"line_number":44,"context_line":"#include \"ssl_verify_backend.h\""},{"line_number":45,"context_line":"#include \"win32.h\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"/* Mock function to be allowed to include win32.c which is required for"},{"line_number":48,"context_line":" * getting the temp directory */"},{"line_number":49,"context_line":"#ifdef _WIN32"},{"line_number":50,"context_line":"struct signal_info siginfo_static; /* GLOBAL */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"f87f0957_64554c69","line":47,"updated":"2023-12-12 13:10:50.000000000","message":"You originally created win32-util.c for the purpose of UT (see commit 5a571fb0f68ce6961cddfa495af2cedf3ee0e216). Maybe just move the win_get_tempdir to that?","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"9719153b68d49cc42e0d25b7bfd1f90a3fbb4ea6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"#include \"ssl_verify_backend.h\""},{"line_number":45,"context_line":"#include \"win32.h\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"/* Mock function to be allowed to include win32.c which is required for"},{"line_number":48,"context_line":" * getting the temp directory */"},{"line_number":49,"context_line":"#ifdef _WIN32"},{"line_number":50,"context_line":"struct signal_info siginfo_static; /* GLOBAL */"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1f8780a6_702527f1","line":47,"in_reply_to":"f87f0957_64554c69","updated":"2023-12-13 14:11:20.000000000","message":"I didn\u0027t like the idea of pulling the dependency of msg() to that file. Currently that util file is standalone. I modified the approach to avoid that dependency.","commit_id":"7c81e0d9b3574b1208785093b38c31b2815ebb16"}]}
