)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5eb1e01f123aeb8044fd4d43f283c7660c332343","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"699a98fd_490cc226","updated":"2023-12-11 14:58:04.000000000","message":"I tried to replicate the leak that is being supressed (with blanking the content of that .txt file) but cannot trigger it at least on macOS. It would be also good to actually have a comment in the unit where the supressed leak is happening.","commit_id":"1d86a394fdf8d8741a794d04b83da7d7200357d1"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ebf063d5120467b70e62f7f7ea5fadbeaffd136f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4b1bfe50_a7b1f834","updated":"2024-01-19 15:44:14.000000000","message":"This test has a bigger problem with the use of files in the source dir. In the github action run we archive the unit test binaries and run them without the source directory present. I am currently facing the same issue in my list test that read COPYRIGHT.","commit_id":"557d9c4a25dbe7174e8fee6dec7a0cc7acd5c693"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"01baa1a98b4fd96e80117a27e420d88a9f367306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9b656d87_6e312912","in_reply_to":"4b1bfe50_a7b1f834","updated":"2024-01-22 13:15:04.000000000","message":"That has nothing to do with this patch. This problem is introduced and solved in https://gerrit.openvpn.net/c/openvpn/+/468. Please discuss there.","commit_id":"557d9c4a25dbe7174e8fee6dec7a0cc7acd5c693"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"6ab7d5b6e2d72c906b37bc2f2850202f5f83404c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bd9d306a_c4b7b77e","updated":"2025-10-10 21:28:37.000000000","message":"While it passes BB and GHA checks(!), it fails for my local builds - both on Linux and FreeBSD.\n\nOutput is just\n\n```\n...\nPASS: ssl_testdriver\nFAIL: user_pass_testdriver\nPASS: push_update_msg_testdriver\n...\n```\n\nif I run the binary from hand (not sure if this is supposed to work, it works for all the other tests) it says\n\n```\ngert@gentoo ~/t_server.git/tests/unit_tests/openvpn $ ./user_pass_testdriver \n[\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d] Running 10 test(s).\n[ RUN      ] test_get_user_pass_defined\n...\n[ RUN      ] test_get_user_pass_authfile_file_assertions\n[  ERROR   ] --- srcdir\n[   LINE   ] --- test_common.h:63: error: Failure!\n[  FAILED  ] test_get_user_pass_authfile_file_assertions\n[\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d] 10 test(s) run.\n[  PASSED  ] 8 test(s).\n[  FAILED  ] 2 test(s), listed below:\n[  FAILED  ] test_get_user_pass_authfile_file\n[  FAILED  ] test_get_user_pass_authfile_file_assertions\n\n 2 FAILED TEST(S)\n[ RUN      ] test_get_user_pass_authfile_file_assertions\n[  ERROR   ] --- srcdir\n[   LINE   ] --- test_common.h:63: error: Failure!\n[  FAILED  ] test_get_user_pass_authfile_file_assertions\n[\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d] 10 test(s) run.\n[  PASSED  ] 8 test(s).\n[  FAILED  ] 2 test(s), listed below:\n[  FAILED  ] test_get_user_pass_authfile_file\n[  FAILED  ] test_get_user_pass_authfile_file_assertions\n\n 2 FAILED TEST(S)\n```\n\nI first thought it\u0027s something with \"in tree builds\", but it also fails \"out of tree\" builds (only tested on FreeBSD).  Maybe cmocka version?  1.1.8 on FreeBSD, 1.1.5-r1 on gentoo.","commit_id":"8085943cc05029140a0912dbded7e643a8086175"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a4af9c547329c4b96759535f623c13770c9c297f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"20361a7b_ffefd0ee","updated":"2025-10-11 09:59:28.000000000","message":"`git am --whitespace\u003dfix` messed up the CR+NL line endings in a way that \"checkouts on windows\" still worked and \"checkouts on unixy systems\" not.  `--whitespace\u003dignore` fixed it.","commit_id":"8085943cc05029140a0912dbded7e643a8086175"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"79f0338adbf2168dd50cf28d6670790631d3c5af","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e802faea_f25437e2","updated":"2025-10-10 21:38:55.000000000","message":"ah, I think I know what happened.  My \"git am\" does whitespace fixes, and it printed something on \"whitespace errors fixed on apply\" - will re-test tomorrow.  Resetting to \"0\" for the time being.","commit_id":"8085943cc05029140a0912dbded7e643a8086175"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a4af9c547329c4b96759535f623c13770c9c297f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"1eff0b93_8616122d","in_reply_to":"bd9d306a_c4b7b77e","updated":"2025-10-11 09:59:28.000000000","message":"Done","commit_id":"8085943cc05029140a0912dbded7e643a8086175"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a4af9c547329c4b96759535f623c13770c9c297f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"18fec491_17419555","in_reply_to":"e802faea_f25437e2","updated":"2025-10-11 09:59:28.000000000","message":"Done","commit_id":"8085943cc05029140a0912dbded7e643a8086175"}],"tests/unit_tests/openvpn/input/leak_suppr.txt":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5eb1e01f123aeb8044fd4d43f283c7660c332343","unresolved":true,"context_lines":[{"line_number":1,"context_line":"leak:_assertions$"}],"source_content_type":"text/plain","patch_set":2,"id":"cf59cf0c_68f7af73","line":1,"updated":"2023-12-11 14:58:04.000000000","message":"This feels unecessarily broad. Especially since we are using it on every unit test that is being run and not only on the input unit tests.","commit_id":"1d86a394fdf8d8741a794d04b83da7d7200357d1"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f4accb38b5a3dfc806a62204a14df65a0734ec08","unresolved":true,"context_lines":[{"line_number":1,"context_line":"leak:_assertions$"}],"source_content_type":"text/plain","patch_set":2,"id":"ba78df38_3f4e21f0","line":1,"in_reply_to":"cf59cf0c_68f7af73","updated":"2023-12-11 16:06:07.000000000","message":"That was intentional. Having a common suffix for tests that can leak due to testing program aborts feels useful. Would you maybe prefer a different suffix? Like _leak?","commit_id":"1d86a394fdf8d8741a794d04b83da7d7200357d1"}]}