)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"fe1bde76439f4e455ab3053b32998e762cd0b5c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2fe336e9_5163c138","updated":"2024-01-02 12:41:22.000000000","message":"The patch does not do what it promises to do. I cherry-picked this patch and the other forked-test-driver patch on my branch and in github actions still only reports that a unit test has failed without any indication of why:\n\nPASS: argv_testdriver\nFAIL: buffer_testdriver\nPASS: crypto_testdriver\n\nhttps://github.com/schwabe/openvpn/actions/runs/7385546211/job/20090514521","commit_id":"cfe8556728e2ada57c5e223b032dda6b673628a0"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"472cd653c06c1fbc9d18cc85837bb3b2a3e3d4e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1521193_287d9d6c","in_reply_to":"2fe336e9_5163c138","updated":"2024-01-09 09:35:44.000000000","message":"Note that the forked-test-driver is only used for the system tests, not the UTs. Your concern was addressed by https://gerrit.openvpn.net/c/openvpn/+/485","commit_id":"cfe8556728e2ada57c5e223b032dda6b673628a0"}],"forked-test-driver":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"3e776c65e504af1ce20feb1ff178862d1cb4531f","unresolved":true,"context_lines":[{"line_number":109,"context_line":"# to ameliorate tests themselves also writing to the log file. Our tests"},{"line_number":110,"context_line":"# don\u0027t, but others can (automake bug#35762)."},{"line_number":111,"context_line":": \u003e\"$log_file\""},{"line_number":112,"context_line":"\"$@\" 2\u003e\u00261 | tee -a \"$log_file\""},{"line_number":113,"context_line":"estatus\u003d$?"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"if test $enable_hard_errors \u003d no \u0026\u0026 test $estatus -eq 99; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f56067ca_738d3288","line":112,"updated":"2023-12-12 13:16:32.000000000","message":"breaks exit status without set -o pipefail. Which is probably not portable... Setting to WIP until I have figured out a solution for that.","commit_id":"b8cb5f3be0a99a6904aa6a509bc9098e8051ae97"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"4a9873105cbd02457fc0b4684df2face7a66e139","unresolved":false,"context_lines":[{"line_number":109,"context_line":"# to ameliorate tests themselves also writing to the log file. Our tests"},{"line_number":110,"context_line":"# don\u0027t, but others can (automake bug#35762)."},{"line_number":111,"context_line":": \u003e\"$log_file\""},{"line_number":112,"context_line":"\"$@\" 2\u003e\u00261 | tee -a \"$log_file\""},{"line_number":113,"context_line":"estatus\u003d$?"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"if test $enable_hard_errors \u003d no \u0026\u0026 test $estatus -eq 99; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf08f7d3_1455cd09","line":112,"in_reply_to":"f56067ca_738d3288","updated":"2023-12-13 10:49:18.000000000","message":"Done","commit_id":"b8cb5f3be0a99a6904aa6a509bc9098e8051ae97"}]}