)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"6164b7093a439630cc0db4b56ff197a9b07babe0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4765f730_8cce1231","updated":"2023-12-13 14:25:28.000000000","message":"Note that we will actually not be broken when tmp_dir is NULL but you end up with tmporary files being created in whatever the current directory is.","commit_id":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"44bde021b2c49909d96f8b6d5ff791596eda1480","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a1ca998_00ab14aa","updated":"2024-01-06 16:26:28.000000000","message":"Looks good to me (just browsed through, not actually tested).  Frank?","commit_id":"7893eb61d0f8509be395f85463220adf816664d2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5ff966161e6357a512f9fdd9ca53aabd30c4e20e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"729b9489_f4e1f6d2","updated":"2024-01-08 17:03:27.000000000","message":"Looks good to me. I verified that this does not break the Windows client tests.","commit_id":"7893eb61d0f8509be395f85463220adf816664d2"}],"src/openvpn/options.c":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2bfb0f1a7b269ca362d630b5c40e5f3cecea74dc","unresolved":true,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    if (!o-\u003etmp_dir)"},{"line_number":890,"context_line":"    {"},{"line_number":891,"context_line":"        /* Warn if we can\u0027t find a valid temporary directory, which should"},{"line_number":892,"context_line":"         * be unlikely. */"},{"line_number":893,"context_line":"        msg(M_USAGE, \"Could not find a suitable temporary directory.\""},{"line_number":894,"context_line":"            \" (GetTempPath() failed).  Consider using --tmp-dir\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"466d524c_f6e1e499","line":891,"updated":"2023-12-13 14:57:14.000000000","message":"M_USAGE is not really \"Warn\"","commit_id":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"24865ca60dfb00b5a3760bb8f86b4461355867a1","unresolved":false,"context_lines":[{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    if (!o-\u003etmp_dir)"},{"line_number":890,"context_line":"    {"},{"line_number":891,"context_line":"        /* Warn if we can\u0027t find a valid temporary directory, which should"},{"line_number":892,"context_line":"         * be unlikely. */"},{"line_number":893,"context_line":"        msg(M_USAGE, \"Could not find a suitable temporary directory.\""},{"line_number":894,"context_line":"            \" (GetTempPath() failed).  Consider using --tmp-dir\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"0aedaf28_cfeef61a","line":891,"in_reply_to":"466d524c_f6e1e499","updated":"2024-01-02 16:52:39.000000000","message":"Done","commit_id":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41"}],"src/openvpn/win32-util.h":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2bfb0f1a7b269ca362d630b5c40e5f3cecea74dc","unresolved":true,"context_lines":[{"line_number":41,"context_line":"bool win_safe_filename(const char *fn);"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"/* Find temporary directory */"},{"line_number":44,"context_line":"const char *win_get_tempdir(void);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"#endif /* OPENVPN_WIN32_UTIL_H */"},{"line_number":47,"context_line":"#endif /* ifdef _WIN32 */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"14243ada_3a632f04","line":44,"updated":"2023-12-13 14:57:14.000000000","message":"corresponding removal from win32.h is missing?","commit_id":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41"},{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"24865ca60dfb00b5a3760bb8f86b4461355867a1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"bool win_safe_filename(const char *fn);"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"/* Find temporary directory */"},{"line_number":44,"context_line":"const char *win_get_tempdir(void);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"#endif /* OPENVPN_WIN32_UTIL_H */"},{"line_number":47,"context_line":"#endif /* ifdef _WIN32 */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fc97a5eb_3cd9a134","line":44,"in_reply_to":"14243ada_3a632f04","updated":"2024-01-02 16:52:39.000000000","message":"yes. Fixed.","commit_id":"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41"}]}