)]}'
{"id":"openvpn~481","triplet_id":"openvpn~master~I525ccf7872880367b248ebebb0ddc83551498042","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-08 21:33:58.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-08 17:03:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I525ccf7872880367b248ebebb0ddc83551498042","subject":"Move get_tmp_dir to win32-util.c and error out on failure","status":"MERGED","created":"2023-12-13 14:06:59.000000000","updated":"2024-01-08 21:33:58.000000000","submitted":"2024-01-08 21:33:58.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"481","meta_rev_id":"5577028ce88ce51ea5d91b6310b65884f6049c65","_number":481,"virtual_id_number":481,"owner":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-13 14:07:01.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2023-12-13 14:07:01.000000000","updated_by":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2024-01-06 16:26:28.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"fe4c187d84903cb890f395b58d53bbb473c56098","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-13 14:06:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6164b7093a439630cc0db4b56ff197a9b07babe0","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2023-12-13 14:25:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2bfb0f1a7b269ca362d630b5c40e5f3cecea74dc","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2023-12-13 14:57:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5d03b05ed37ef2314d256872495c415ae916b85d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-02 16:52:28.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"24865ca60dfb00b5a3760bb8f86b4461355867a1","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-02 16:52:39.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"44bde021b2c49909d96f8b6d5ff791596eda1480","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-06 16:26:28.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5ff966161e6357a512f9fdd9ca53aabd30c4e20e","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-08 17:03:27.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5577028ce88ce51ea5d91b6310b65884f6049c65","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-08 21:33:58.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f0a17ed8513405af0efb1df2ab2bda3956e01910","revisions":{"c45a2c2c79cf34f47e4a1bf7fbb903e3e38c7d41":{"kind":"REWORK","_number":1,"created":"2023-12-13 14:06:59.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/81/481/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/481/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/1 \u0026\u0026 git checkout -b change-481 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/481/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b9173868798d713c03e7e45069be171fc4859f7c","subject":"Implement the --tls-export-cert feature"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-13 13:39:45.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-13 14:06:50.000000000","tz":60},"subject":"Move get_tmp_dir to win32-util.c and error out on failure","message":"Move get_tmp_dir to win32-util.c and error out on failure\n\nCurrently we only warn in get_tmp_dir fails and set o-\u003etmp_dir to\na null pointer. This will not be caught by check_file_access_chroot\neither since that ignores NULL pointers but other parts of OpenVPN\nwill assume that tmp_dir is set to a non-NULL string.\n\nAlso move get_tmp_dir to ssl-utils.c to use it in unit tests.\n\nChange-Id: I525ccf7872880367b248ebebb0ddc83551498042\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"7893eb61d0f8509be395f85463220adf816664d2":{"kind":"REWORK","_number":2,"created":"2024-01-02 16:52:28.000000000","uploader":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"ref":"refs/changes/81/481/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/481/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/2 \u0026\u0026 git checkout -b change-481 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/481/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"76d11614797617708c31dc3db22e3568fee3de6d","subject":"get_default_gateway() HWADDR overhaul"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2023-12-13 13:39:45.000000000","tz":60},"committer":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-02 16:52:25.000000000","tz":60},"subject":"Move get_tmp_dir to win32-util.c and error out on failure","message":"Move get_tmp_dir to win32-util.c and error out on failure\n\nCurrently we only warn in get_tmp_dir fails and set o-\u003etmp_dir to\na null pointer. This will not be caught by check_file_access_chroot\neither since that ignores NULL pointers but other parts of OpenVPN\nwill assume that tmp_dir is set to a non-NULL string.\n\nAlso move get_tmp_dir to ssl-utils.c to use it in unit tests.\n\nChange-Id: I525ccf7872880367b248ebebb0ddc83551498042\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\n"},"branch":"refs/heads/master"},"f0a17ed8513405af0efb1df2ab2bda3956e01910":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2024-01-08 21:33:58.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/81/481/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/81/481/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/3 \u0026\u0026 git checkout -b change-481 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/81/481/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/81/481/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7268e14dba61254b04a0b2db37c12c8ab58423ea","subject":"Fix IPv6 route add/delete message log level"}],"author":{"name":"Arne Schwabe","email":"arne@rfc2549.org","date":"2024-01-08 17:13:49.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-08 21:15:59.000000000","tz":60},"subject":"Move get_tmp_dir to win32-util.c and error out on failure","message":"Move get_tmp_dir to win32-util.c and error out on failure\n\nCurrently we only warn in get_tmp_dir fails and set o-\u003etmp_dir to\na null pointer. This will not be caught by check_file_access_chroot\neither since that ignores NULL pointers but other parts of OpenVPN\nwill assume that tmp_dir is set to a non-NULL string.\n\nAlso move get_tmp_dir to win32-util.c to use it in unit tests.\n\nChange-Id: I525ccf7872880367b248ebebb0ddc83551498042\nSigned-off-by: Arne Schwabe \u003carne@rfc2549.org\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20240108171349.15871-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27964.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}