)]}'
{"src/openvpn/socket.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f458fa8a8f7be41f7713764a5a37ad4fbc20a493","unresolved":true,"context_lines":[{"line_number":2031,"context_line":"                                        false);"},{"line_number":2032,"context_line":"            if (!socket_defined(sock-\u003esd))"},{"line_number":2033,"context_line":"            {"},{"line_number":2034,"context_line":"                if (signal_received)"},{"line_number":2035,"context_line":"                {"},{"line_number":2036,"context_line":"                    register_signal(sig_info, SIGTERM, \"socket-undefined\");"},{"line_number":2037,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"49bd721f_a0919cda","line":2034,"updated":"2024-01-19 08:27:27.000000000","message":"I do not like checking `signal_received` here if what we\u0027re really interested is `sig_info` (I do understand that bother are NULL or none of them, but this way the code is still more confusing than necessary).\n\nThis said, if we know `sig_info` is never NULL anyway, because there is only a single caller, maybe a better fix would be\n\n```\nASSERT(sig_info);\nvolatile int *signal_received \u003d \u0026sig_info-\u003esignal_received;\n```\n\nat the beginning of the function.","commit_id":"878fead12bbc349b0bb53f0dcf6e8e2686b4f02d"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"f0fdc5e6b7e9ff8dc38ab63c71640cd36e78c8f9","unresolved":false,"context_lines":[{"line_number":2031,"context_line":"                                        false);"},{"line_number":2032,"context_line":"            if (!socket_defined(sock-\u003esd))"},{"line_number":2033,"context_line":"            {"},{"line_number":2034,"context_line":"                if (signal_received)"},{"line_number":2035,"context_line":"                {"},{"line_number":2036,"context_line":"                    register_signal(sig_info, SIGTERM, \"socket-undefined\");"},{"line_number":2037,"context_line":"                }"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2bf317a9_1cc5b58d","line":2034,"in_reply_to":"49bd721f_a0919cda","updated":"2024-01-22 10:06:44.000000000","message":"Acknowledged","commit_id":"878fead12bbc349b0bb53f0dcf6e8e2686b4f02d"}]}