)]}'
{"id":"openvpn~490","triplet_id":"openvpn~master~I8ef199463d46303129a3f563fd9eace780a58b8a","project":"openvpn","branch":"master","topic":"coverity-fixes","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-03-25 01:13:51.000000000","reason":"removed on reply"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2024-03-25 17:22:58.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-03-25 17:22:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8ef199463d46303129a3f563fd9eace780a58b8a","subject":"phase2_tcp_server: fix Coverity issue \u0027Dereference after null check\u0027","status":"MERGED","created":"2024-01-09 11:08:56.000000000","updated":"2024-03-25 17:22:58.000000000","submitted":"2024-03-25 17:22:58.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"490-coverity-fixes","meta_rev_id":"d1a421e0ab281465dd63bc94495af79c40badb68","_number":490,"virtual_id_number":490,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2024-01-19 08:27:27.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"816c616619eb35bf1703bc9422216c7fbf4d259c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 11:08:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f458fa8a8f7be41f7713764a5a37ad4fbc20a493","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-19 08:27:27.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f0fdc5e6b7e9ff8dc38ab63c71640cd36e78c8f9","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-22 10:06:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c492654d000444062e7879056fb2508cc3a710d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-22 10:08:25.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c0afeb51e0917c4d34c4654e6d82fb51ea95c600","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-03-25 01:13:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d1a421e0ab281465dd63bc94495af79c40badb68","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-03-25 17:22:58.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e8c629fe64c67ea0a8454753be99db44df7ce53e","revisions":{"878fead12bbc349b0bb53f0dcf6e8e2686b4f02d":{"kind":"REWORK","_number":1,"created":"2024-01-09 11:08:56.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/490/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/490/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/1 \u0026\u0026 git checkout -b change-490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/490/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"03c8f4467eba348c0c0fc81ec978e8301e867b0c","subject":"Fix various \"Uninitialized scalar variable\" warnings from Coverity"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 10:24:17.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 11:08:26.000000000","tz":60},"subject":"phase2_tcp_server: fix Coverity issue \"Dereference after null check\"","message":"phase2_tcp_server: fix Coverity issue \"Dereference after null check\"\n\nAs Coverity says:\nEither the check against null is unnecessary, or there may be a null\npointer dereference.\nIn phase2_tcp_server: Pointer is checked against null but then\ndereferenced anyway\n\nThe check is probably not required since we have an ASSERT(sig_info)\nin the caller. But I really didn\u0027t want to remove the check. So\nmake the code consistent instead.\n\nChange-Id: I8ef199463d46303129a3f563fd9eace780a58b8a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"83fe8cefeb97618c3e9621711bb99cde9bd1acc7":{"kind":"REWORK","_number":2,"created":"2024-01-22 10:08:25.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/90/490/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/490/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/2 \u0026\u0026 git checkout -b change-490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/490/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bc29bd6a3376158b73d069758122739fbf93c022","subject":"buf_string_match_head_str: Fix Coverity issue \u0027Unsigned compared against 0\u0027"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 10:24:17.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-22 10:03:36.000000000","tz":60},"subject":"phase2_tcp_server: fix Coverity issue \"Dereference after null check\"","message":"phase2_tcp_server: fix Coverity issue \"Dereference after null check\"\n\nAs Coverity says:\nEither the check against null is unnecessary, or there may be a null\npointer dereference.\nIn phase2_tcp_server: Pointer is checked against null but then\ndereferenced anyway\n\nThere is only one caller (link_socket_init_phase2) and it already has\nan ASSERT(sig_info). So use that here was well.\n\nv2:\n - fix cleanly by actually asserting that sig_info is defined\n\nChange-Id: I8ef199463d46303129a3f563fd9eace780a58b8a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e8c629fe64c67ea0a8454753be99db44df7ce53e":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2024-03-25 17:22:58.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/90/490/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/90/490/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/3 \u0026\u0026 git checkout -b change-490 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/90/490/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/90/490/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a60d1bef424088df55f4d07efd45ce080fc7132","subject":"Use snprintf instead of sprintf for get_ssl_library_version"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-03-25 07:14:48.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-03-25 16:53:34.000000000","tz":60},"subject":"phase2_tcp_server: fix Coverity issue \u0027Dereference after null check\u0027","message":"phase2_tcp_server: fix Coverity issue \u0027Dereference after null check\u0027\n\nAs Coverity says:\nEither the check against null is unnecessary, or there may be a null\npointer dereference.\nIn phase2_tcp_server: Pointer is checked against null but then\ndereferenced anyway\n\nThere is only one caller (link_socket_init_phase2) and it already has\nan ASSERT(sig_info). So use that here was well.\n\nv2:\n - fix cleanly by actually asserting that sig_info is defined\n\nChange-Id: I8ef199463d46303129a3f563fd9eace780a58b8a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20240325071448.12143-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28452.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}