)]}'
{"id":"openvpn~491","triplet_id":"openvpn~master~I64f094eeb0ca8c3953a94d742adf468faf27dab3","project":"openvpn","branch":"master","full_branch":"refs/heads/master","topic":"coverity-fixes","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2024-01-19 11:56:10.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2024-01-19 13:12:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I64f094eeb0ca8c3953a94d742adf468faf27dab3","subject":"buf_string_match_head_str: Fix Coverity issue \u0027Unsigned compared against 0\u0027","status":"MERGED","created":"2024-01-09 11:08:56.000000000","updated":"2024-01-19 13:12:29.000000000","submitted":"2024-01-19 13:12:29.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"491-coverity-fixes","meta_rev_id":"08cafca8213c5be6c2b9f87e08d21f0610173179","_number":491,"virtual_id_number":491,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2024-01-09 11:08:57.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"4330135758a6b078384087f5c0c2467400128a39","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2024-01-09 11:08:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5294b3f8eb52dfbe3397ce2a5e44ffd216b5791","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-19 11:56:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9fd6373a3f13c5569bed92f0a67d5b6366069870","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2024-01-19 11:58:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"08cafca8213c5be6c2b9f87e08d21f0610173179","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2024-01-19 13:12:29.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc29bd6a3376158b73d069758122739fbf93c022","revisions":{"0dffb9edac25f59c5f49b71d3e8902707e80e337":{"kind":"REWORK","_number":1,"created":"2024-01-09 11:08:56.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/91/491/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/491/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/1 \u0026\u0026 git checkout -b change-491 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/91/491/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"878fead12bbc349b0bb53f0dcf6e8e2686b4f02d","subject":"phase2_tcp_server: fix Coverity issue \"Dereference after null check\""}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 10:34:57.000000000","tz":60},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-09 11:08:26.000000000","tz":60},"subject":"buf_string_match_head_str: Fix Coverity issue \"Unsigned compared against 0\"","message":"buf_string_match_head_str: Fix Coverity issue \"Unsigned compared against 0\"\n\nAs Coverity says:\nAn unsigned value can never be negative, so this test will always\nevaluate the same way.\n\nWas changed from int to size_t in commit\n7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,\nbut the check did not make sense before, either.\n\nChange-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"bc29bd6a3376158b73d069758122739fbf93c022":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2024-01-19 13:12:29.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/91/491/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/91/491/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/2 \u0026\u0026 git checkout -b change-491 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/91/491/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/91/491/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b541a86948d7e9866b33e876fcf070fad00b3dce","subject":"NTLM: when NTLMv1 is requested, try NTLMv2 instead"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2024-01-19 12:03:41.000000000","tz":60},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2024-01-19 13:08:15.000000000","tz":60},"subject":"buf_string_match_head_str: Fix Coverity issue \u0027Unsigned compared against 0\u0027","message":"buf_string_match_head_str: Fix Coverity issue \u0027Unsigned compared against 0\u0027\n\nAs Coverity says:\nAn unsigned value can never be negative, so this test will always\nevaluate the same way.\n\nWas changed from int to size_t in commit\n7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning,\nbut the check did not make sense before, either.\n\nChange-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20240119120341.22933-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28093.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
